Add the bgp_fact test new item#995
Closed
vincent201881 wants to merge 3 commits intosonic-net:masterfrom
vincent201881:patch-6
Closed
Add the bgp_fact test new item#995vincent201881 wants to merge 3 commits intosonic-net:masterfrom vincent201881:patch-6
vincent201881 wants to merge 3 commits intosonic-net:masterfrom
vincent201881:patch-6
Conversation
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
5331ecd [vslib]: Fix MACsec bug in SCI and XPN (sonic-net#1003) ac04509 Fix build issues on gcc-10 (sonic-net#999) 1b8ce97 [pipeline] Download swss common artifact in a separated directory (sonic-net#995) 7a2e096 Change sonic-buildimage.vs artifact source from CI build to official build. (sonic-net#992) d5866a3 [vslib]: fix create MACsec SA error (sonic-net#986) f36f7ce Added Support for enum query capability of Nexthop Group Type. (sonic-net#989) 323b89b Support for MACsec statistics (sonic-net#892) 26a8a12 Prevent other notification event storms to keep enqueue unchecked and drained all memory that leads to crashing the switch router (sonic-net#968) 0cb253a Fix object availability conversion (sonic-net#974)
sdszhang
pushed a commit
to sdszhang/sonic-mgmt
that referenced
this pull request
Mar 23, 2026
…net#995) <!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Summary: Fix multi-port portchannels to T0 VMs by shutdown/startup all LAG member ports one by one We can't directly do it to the LAG interface because it is removed after applying T0 removal patch Fixes # (issue) ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [x] Test case improvement ### Back port request - [x] 202503 - [x] 202511 ### Approach #### What is the motivation for this PR? test_add_rack.py failed on t1-f2-d10u8 topo #### How did you do it? Fix multi-port portchannels to T0 VMs by shutdown/startup all LAG member ports one by one #### How did you verify/test it? test_add_rack.py passed on t1-f2-d10u8 topo #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Approach
How did you do it?
How did you verify/test it?
Verified the bgp_fact case in my own testbed environment.
Test result:
TASK [test : include] **********************************************************
task path: /var/clsnet/git-sw-csa/sonic-mgmt/ansible/roles/test/tasks/main.yml:8
Friday 05 July 2019 10:44:50 +0000 (0:00:00.034) 0:00:22.195 ***********
skipping: [cel-seastone-01] => {"changed": false, "skip_reason": "Conditional check failed", "skipped": true}
PLAY ***************************************************************************
skipping: no hosts matched
PLAY RECAP *********************************************************************
cel-seastone-01 : ok=52 changed=7 unreachable=0 failed=0
Friday 05 July 2019 10:44:50 +0000 (0:00:00.031) 0:00:22.227 ***********
TASK: test : Gather facts from bgp container ---------------------------- 1.35s
TASK: test : gather system version information -------------------------- 1.34s
TASK: test : Compare the bgp neighbors name with minigraph bgp neigbhors name --- 1.32s
TASK: test : Verify locat ASNs in bgp sessions -------------------------- 1.31s
TASK: test : Verify the peer hold time value ---------------------------- 1.31s
TASK: test : Verify bgp sessions are established ------------------------ 1.30s
TASK: test : Compare the bgp neighbors ASN with minigraph --------------- 1.27s
TASK: test : Compare the local address value ---------------------------- 1.22s
TASK: setup ------------------------------------------------------------- 1.10s
TASK: test : Get interface facts ---------------------------------------- 0.86s
TASK: test : Get interface facts ---------------------------------------- 0.82s
TASK: test : Get process information in syncd docker -------------------- 0.62s
TASK: test : Get process information in syncd docker -------------------- 0.54s
TASK: test : Gathering minigraph facts about the device ----------------- 0.45s
TASK: test : validate all interfaces are up after test ------------------ 0.45s
TASK: test : Gather minigraph facts about the device -------------------- 0.42s
TASK: test : Gathering minigraph facts about the device ----------------- 0.41s
TASK: test : Gather minigraph facts about the device -------------------- 0.41s
TASK: test : do basic sanity check after each test ---------------------- 0.38s
TASK: test : Get orchagent process information -------------------------- 0.27s
clsnet@29750a2b930a:~/git-sw-csa/sonic-mgmt/ansible$
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation