Workaound for ansible module executed twice issue of pytest-ansible#9530
Merged
wangxin merged 1 commit intosonic-net:masterfrom Aug 18, 2023
Merged
Workaound for ansible module executed twice issue of pytest-ansible#9530wangxin merged 1 commit intosonic-net:masterfrom
wangxin merged 1 commit intosonic-net:masterfrom
Conversation
This is to workaround pytest-ansible plugin issue:
Even no extra-inventory is specified, extra_inventory_manager will still be initialized.
ansible/pytest-ansible#135
As of today, pytest-ansible supports host manager and module dispatcher v29, v212, v213.
While initializing the pytest-ansible plugin, it tries to collect default ansible configurations and
command line options. These options are used for creating host manager. When no extra_inventory is specified,
the options passed to host manager will include extra_inventory=None. However, the host manager will still
try to create extra_inventory_manager with None as the inventory source. This will cause the module dispatcher
to run the module on hosts matching host pattern in both inventory and extra inventory. This would cause an
ansible module executed twice on the same host. In case we wish to use the shell module to run command like
"rm <some_file>" to delete a file. The second run would fail because the file has been deleted in the first run.
For more details, please refer to the Github issue mentioned above.
The fix is to overwrite the pytest-ansible plugin's initialize method and remove the extra_inventory option
if it is None. This will prevent the host manager from creating extra_inventory_manager with None as the
inventory source.
Signed-off-by: Xin Wang <[email protected]>
Contributor
|
Can we add a test for this issue? |
11 tasks
Collaborator
Author
This is an issue of third party package. I don't think it is within our own scope. |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Aug 18, 2023
…onic-net#9530) What is the motivation for this PR? This is to workaround pytest-ansible plugin issue: Even no extra-inventory is specified, extra_inventory_manager will still be initialized. ansible/pytest-ansible#135 As of today, pytest-ansible supports host manager and module dispatcher v29, v212, v213. While initializing the pytest-ansible plugin, it tries to collect default ansible configurations and command line options. These options are used for creating host manager. When no extra_inventory is specified, the options passed to host manager will include extra_inventory=None. However, the host manager will still try to create extra_inventory_manager with None as the inventory source. This will cause the module dispatcher to run the module on hosts matching host pattern in both inventory and extra inventory. This would cause an ansible module executed twice on the same host. In case we wish to use the shell module to run command like "rm <some_file>" to delete a file. The second run would fail because the file has been deleted in the first run. For more details, please refer to the Github issue mentioned above. This change is only required for python3. Currently master and 202305 branch are using python3. For older branches, they are still using python2 and an older version of pytest-ansible which does not have the bug. How did you do it? The fix is to overwrite the pytest-ansible plugin's initialize method and remove the extra_inventory option if it is None. This will prevent the host manager from creating extra_inventory_manager with None as the inventory source. How did you verify/test it? Tried run a few tests with pytest-ansible 3.2.1 and 4.0.0. Signed-off-by: Xin Wang <[email protected]>
Collaborator
|
Cherry-pick PR to 202305: #9544 |
6 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Aug 18, 2023
…9530) What is the motivation for this PR? This is to workaround pytest-ansible plugin issue: Even no extra-inventory is specified, extra_inventory_manager will still be initialized. ansible/pytest-ansible#135 As of today, pytest-ansible supports host manager and module dispatcher v29, v212, v213. While initializing the pytest-ansible plugin, it tries to collect default ansible configurations and command line options. These options are used for creating host manager. When no extra_inventory is specified, the options passed to host manager will include extra_inventory=None. However, the host manager will still try to create extra_inventory_manager with None as the inventory source. This will cause the module dispatcher to run the module on hosts matching host pattern in both inventory and extra inventory. This would cause an ansible module executed twice on the same host. In case we wish to use the shell module to run command like "rm <some_file>" to delete a file. The second run would fail because the file has been deleted in the first run. For more details, please refer to the Github issue mentioned above. This change is only required for python3. Currently master and 202305 branch are using python3. For older branches, they are still using python2 and an older version of pytest-ansible which does not have the bug. How did you do it? The fix is to overwrite the pytest-ansible plugin's initialize method and remove the extra_inventory option if it is None. This will prevent the host manager from creating extra_inventory_manager with None as the inventory source. How did you verify/test it? Tried run a few tests with pytest-ansible 3.2.1 and 4.0.0. Signed-off-by: Xin Wang <[email protected]>
mssonicbld
added
Included in 202305 branch
and removed
Created PR to 202305 branch
labels
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Jan 25, 2024
…onic-net#9530) What is the motivation for this PR? This is to workaround pytest-ansible plugin issue: Even no extra-inventory is specified, extra_inventory_manager will still be initialized. ansible/pytest-ansible#135 As of today, pytest-ansible supports host manager and module dispatcher v29, v212, v213. While initializing the pytest-ansible plugin, it tries to collect default ansible configurations and command line options. These options are used for creating host manager. When no extra_inventory is specified, the options passed to host manager will include extra_inventory=None. However, the host manager will still try to create extra_inventory_manager with None as the inventory source. This will cause the module dispatcher to run the module on hosts matching host pattern in both inventory and extra inventory. This would cause an ansible module executed twice on the same host. In case we wish to use the shell module to run command like "rm <some_file>" to delete a file. The second run would fail because the file has been deleted in the first run. For more details, please refer to the Github issue mentioned above. This change is only required for python3. Currently master and 202305 branch are using python3. For older branches, they are still using python2 and an older version of pytest-ansible which does not have the bug. How did you do it? The fix is to overwrite the pytest-ansible plugin's initialize method and remove the extra_inventory option if it is None. This will prevent the host manager from creating extra_inventory_manager with None as the inventory source. How did you verify/test it? Tried run a few tests with pytest-ansible 3.2.1 and 4.0.0. Signed-off-by: Xin Wang <[email protected]>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
Why I did it Fix the following issues for Seastone platform: - system-health issue: show system-health detail will not complete sonic-net#9530, Celestica Seastone DX010-C32: show system-health detail fails with 'Chassis' object has no attribute 'initizalize_system_led' sonic-net#11322 - show platform firmware updates issue: Celestica Seastone DX010-C32: show platform firmware updates sonic-net#11317 - other platform optimization How I did it Modify and optimize the platform implememtation. How to verify it Manual run the test commands described in these issues.
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
Why I did it Fix the following issues for Seastone platform: - system-health issue: show system-health detail will not complete sonic-net#9530, Celestica Seastone DX010-C32: show system-health detail fails with 'Chassis' object has no attribute 'initizalize_system_led' sonic-net#11322 - show platform firmware updates issue: Celestica Seastone DX010-C32: show platform firmware updates sonic-net#11317 - other platform optimization How I did it Modify and optimize the platform implememtation. How to verify it Manual run the test commands described in these issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
This is to workaround pytest-ansible plugin issue:
Even no extra-inventory is specified, extra_inventory_manager will still be initialized.
ansible/pytest-ansible#135
As of today, pytest-ansible supports host manager and module dispatcher v29, v212, v213. While initializing the pytest-ansible plugin, it tries to collect default ansible configurations and command line options. These options are used for creating host manager. When no extra_inventory is specified, the options passed to host manager will include extra_inventory=None. However, the host manager will still try to create extra_inventory_manager with None as the inventory source. This will cause the module dispatcher to run the module on hosts matching host pattern in both inventory and extra inventory. This would cause an ansible module executed twice on the same host. In case we wish to use the shell module to run command like "rm <some_file>" to delete a file. The second run would fail because the file has been deleted in the first run. For more details, please refer to the Github issue mentioned above.
This change is only required for python3. Currently master and 202305 branch are using python3. For older branches, they are still using python2 and an older version of pytest-ansible which does not have the bug.
How did you do it?
The fix is to overwrite the pytest-ansible plugin's initialize method and remove the extra_inventory option if it is None. This will prevent the host manager from creating extra_inventory_manager with None as the inventory source.
How did you verify/test it?
Tried run a few tests with pytest-ansible 3.2.1 and 4.0.0.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation