[sonic-mgmt docker]Specify the pytest-ansible version for the python3 in sonic-mgmt docker#15814
[sonic-mgmt docker]Specify the pytest-ansible version for the python3 in sonic-mgmt docker#15814nhe-NV wants to merge 1 commit intosonic-net:masterfrom
Conversation
1. For python 3.8.10, pytest-ansible dose not recommend to use the version upper than 3.0.0. 2. There is a bug in the latest pytest-ansible:ansible/pytest-ansible#135
|
@yxieca could you please review? |
|
@nhe-NV Your fix should work. However, my concern is that this will cause us stuck with a pretty old pytest-ansible plugin. It would be difficult to move forward with newer ansible and pytest-ansible versions. Sometimes, vulnerability could be identified with old packages and we need to upgrade them to address those security issues. I am about to hack it from sonic-mgmt side. I’ll send out the PR soon. It would be great if you could help review. |
|
I agree that it is a good idea to specify a fixed version of dependent packages. However, instead of using pytest-ansible v2.2.4, maybe it is a better idea to use later version like v4.0.0. |
|
@nhe-NV can you please followup on the failures? |
|
HI @liat-grozovik I will close this PR since Xin already have a fix in the sonic-mgmt: sonic-net/sonic-mgmt#9530 |
|
There is already a PR in the sonic-mgmt to fix the issue: sonic-net/sonic-mgmt#9530 |
Why I did it
Work item tracking
How I did it
Specify the pytest-ansible verion to always use 2.2.4 instead of latest one.
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)