Skip bfd/test_bfd_static_route.py for single_asic systems and non cisco platforms - Fix for Issue #12948#13356
Merged
abdosi merged 1 commit intosonic-net:masterfrom Jun 20, 2024
Merged
Conversation
Contributor
|
Thanks, this looks good to me |
Contributor
|
Can we revise the PR's title and content so that we know what the PR is. |
vperumal
changed the title
Collaborator
Author
|
Done @wsycqyz - Kindly let me know if you need any more details |
wsycqyz
approved these changes
Jun 20, 2024
Contributor
|
I am ok with this PR. |
abdosi
approved these changes
Jun 20, 2024
Contributor
|
@StormLiangMS can you please help to port this PR to 202405 branch? |
Contributor
|
@wangxin for viz can you please help to port this PR to 202405 branch? |
Contributor
|
Is it possible to get this PR casted to 202405? Arista is waiting for this PR. |
Collaborator
|
Cherry-pick PR to 202405: #14619 |
8 tasks
mssonicbld
added
Included in 202405 branch
and removed
Created PR to 202405 branch
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Issue:
bfd/test_bfd_static_route.py assumes that config_db.json is a mulit-asic system.
If it's a single asic it will use the wrong file name.
Resolution
The test is supposed to run only on a multi-asic system and on specific cisco LC, Modified the conditional mark to skip accordingly. This PR is a fix for Jira #12948
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
PR is a fix for Jira #12948
How did you do it?
How did you verify/test it?
Verified that the testcase skips on single_asic system. Would request @arista-nwolfe to confirm that it skips for them too.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation