[SNMP]: Add snmp test case using link local as snmpagent address by SuvarnaMeenakshi · Pull Request #9268 · sonic-net/sonic-mgmt

SuvarnaMeenakshi · 2023-08-04T00:48:24Z

Description of PR

Summary:
Fixes # (issue)

Type of change

Bug fix
Testbed and Framework(new/improvement)
Test case(new/improvement)

Back port request

201911
202012
202205

Approach

What is the motivation for this PR?

Test added to use link local IP address as snmpagent address.

How did you do it?

Use ink local IP of eth0 IP address, configure that as MGMT address.
Restart SNMP service so that snmpd.conf uses newly assigned MGMT address as snmpagent address
Query using link local address
Check if snmpresult is as expected.
reload config to remove the MGMT link local IP assignment.

How did you verify/test it?

Verified on VS testbed,.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

…#8988)" This reverts commit d88236c.

…ic-net#9208)" This reverts commit 1c5b8dd.

…9232)" This reverts commit a3c0642.

Signed-off-by: Suvarna Meenakshi <[email protected]>

…nic-net#9232)"" This reverts commit a12ac1e.

…ry` (sonic-net#9208)"" This reverts commit 6ceebe4.

…onic-net#8988)"" This reverts commit d51c9a6.

mssonicbld · 2023-08-04T00:49:24Z

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed fix end of files.........................................................Passed check yaml...............................................................Passed check for added large files..............................................Passed check python ast.........................................................Passed flake8...................................................................Failed - hook id: flake8 - exit code: 1 tests/snmp/test_snmp_link_local.py:13:9: E128 continuation line under-indented for visual indent tests/snmp/test_snmp_link_local.py:21:24: E128 continuation line under-indented for visual indent tests/snmp/test_snmp_link_local.py:46:78: E502 the backslash is redundant between brackets tests/snmp/test_snmp_link_local.py:50:97: E502 the backslash is redundant between brackets tests/snmp/test_snmp_link_local.py:51:13: E128 continuation line under-indented for visual indent flake8...............................................(no files to check)Skipped check conditional mark sort..............................................Passed

To run the pre-commit checks locally, you can follow below steps:

Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
docker container.
Ensure that the pre-commit package is installed:

sudo pip install pre-commit

Go to repository root folder
Install the pre-commit hooks:

pre-commit install

Use pre-commit to check staged file:

pre-commit

Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

mssonicbld · 2023-08-04T00:50:33Z

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed fix end of files.........................................................Passed check yaml...............................................................Passed check for added large files..............................................Passed check python ast.........................................................Passed flake8...................................................................Failed - hook id: flake8 - exit code: 1 tests/snmp/test_snmp_link_local.py:13:9: E128 continuation line under-indented for visual indent tests/snmp/test_snmp_link_local.py:21:24: E128 continuation line under-indented for visual indent tests/snmp/test_snmp_link_local.py:46:78: E502 the backslash is redundant between brackets tests/snmp/test_snmp_link_local.py:50:97: E502 the backslash is redundant between brackets tests/snmp/test_snmp_link_local.py:51:13: E128 continuation line under-indented for visual indent flake8...............................................(no files to check)Skipped check conditional mark sort..............................................Passed

To run the pre-commit checks locally, you can follow below steps:

Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
docker container.
Ensure that the pre-commit package is installed:

sudo pip install pre-commit

Go to repository root folder
Install the pre-commit hooks:

pre-commit install

Use pre-commit to check staged file:

pre-commit

Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

Signed-off-by: Suvarna Meenakshi <[email protected]>

qiluo-msft · 2023-08-08T00:08:53Z

tests/snmp/test_snmp_link_local.py

+            break
+    # configure link local IP in config_db
+    duthost.shell(
+            'redis-cli -n 4 hset "MGMT_INTERFACE|eth0|{}" "gwaddr" "fe80::1"'


redis-cli -n 4

sonic-db-cli CONFIG_DB is better. #Closed

qiluo-msft · 2023-08-08T00:10:17Z

tests/snmp/test_snmp_link_local.py

+    # link local IP configured in MGMT_INTERFACE
+    duthost.shell("systemctl restart snmp")
+    stdout_lines = duthost.shell("docker exec snmp snmpget \
+                                 -v2c -c {} {}%eth0 1.3.6.1.2.1.1.1.0"


1.3.6.1.2.1.1.1.0

Better to have a named constant, so audience could understand what is the OID meaning. #Closed

Signed-off-by: Suvarna Meenakshi <[email protected]>

…#8988)" This reverts commit d88236c.

…onic-net#8988)"" This reverts commit 87ad5db.

PR checker. Signed-off-by: Suvarna Meenakshi <[email protected]>

SuvarnaMeenakshi · 2023-08-11T19:28:58Z

/azp run

azure-pipelines · 2023-08-11T19:29:07Z

Azure Pipelines successfully started running 1 pipeline(s).

wangxin · 2023-08-16T23:28:54Z

@SuvarnaMeenakshi This is to add a new test. Do we really need it in 202205 branch?

…ic-net#9268) What is the motivation for this PR? Test added to use link local IP address as snmpagent address. How did you do it? Use ink local IP of eth0 IP address, configure that as MGMT address. Restart SNMP service so that snmpd.conf uses newly assigned MGMT address as snmpagent address Query using link local address Check if snmpresult is as expected. reload config to remove the MGMT link local IP assignment. How did you verify/test it? Verified on VS testbed,.

mssonicbld · 2023-08-16T23:28:56Z

Cherry-pick PR to 202305: #9490

What is the motivation for this PR? Test added to use link local IP address as snmpagent address. How did you do it? Use ink local IP of eth0 IP address, configure that as MGMT address. Restart SNMP service so that snmpd.conf uses newly assigned MGMT address as snmpagent address Query using link local address Check if snmpresult is as expected. reload config to remove the MGMT link local IP assignment. How did you verify/test it? Verified on VS testbed,.

SuvarnaMeenakshi · 2023-08-18T15:56:42Z

@SuvarnaMeenakshi This is to add a new test. Do we really need it in 202205 branch?

@wangxin The change to support IPv6 SNMP is merged in 202205 and this change caused SNMP over link local IPv6 to fail.
As the change is added in 202205, it will be good to add this test in 202205 also.
@qiluo-msft any suggestion.

…ic-net#9268) What is the motivation for this PR? Test added to use link local IP address as snmpagent address. How did you do it? Use ink local IP of eth0 IP address, configure that as MGMT address. Restart SNMP service so that snmpd.conf uses newly assigned MGMT address as snmpagent address Query using link local address Check if snmpresult is as expected. reload config to remove the MGMT link local IP assignment. How did you verify/test it? Verified on VS testbed,.

mssonicbld · 2023-08-28T09:30:33Z

Cherry-pick PR to 202205: #9710

What is the motivation for this PR? Test added to use link local IP address as snmpagent address. How did you do it? Use ink local IP of eth0 IP address, configure that as MGMT address. Restart SNMP service so that snmpd.conf uses newly assigned MGMT address as snmpagent address Query using link local address Check if snmpresult is as expected. reload config to remove the MGMT link local IP assignment. How did you verify/test it? Verified on VS testbed,.

…ic-net#9268) What is the motivation for this PR? Test added to use link local IP address as snmpagent address. How did you do it? Use ink local IP of eth0 IP address, configure that as MGMT address. Restart SNMP service so that snmpd.conf uses newly assigned MGMT address as snmpagent address Query using link local address Check if snmpresult is as expected. reload config to remove the MGMT link local IP assignment. How did you verify/test it? Verified on VS testbed,.

What is the motivation for this PR? In PR #9268, a test script named test_snmp_link_local.py was introduced, but it was incorrectly listed as snmp/test_snmp_link_local_ip.py in .azure-pipelines/pr_test_scripts.yaml. This PR corrects the entry in .azure-pipelines/pr_test_scripts.yaml to resolve the mismatch. How did you do it? This PR corrects the entry in .azure-pipelines/pr_test_scripts.yaml to resolve the mismatch. How did you verify/test it?

What is the motivation for this PR? In PR sonic-net#9268, a test script named test_snmp_link_local.py was introduced, but it was incorrectly listed as snmp/test_snmp_link_local_ip.py in .azure-pipelines/pr_test_scripts.yaml. This PR corrects the entry in .azure-pipelines/pr_test_scripts.yaml to resolve the mismatch. How did you do it? This PR corrects the entry in .azure-pipelines/pr_test_scripts.yaml to resolve the mismatch. How did you verify/test it?

SuvarnaMeenakshi added 9 commits August 3, 2023 23:12

Revert "Change run_tests.sh to use python3 unconditionally (sonic-net…

d51c9a6

…#8988)" This reverts commit d88236c.

Revert "[tests/crm] Fix python3 syntax error in test_acl_entry (son…

6ceebe4

…ic-net#9208)" This reverts commit 1c5b8dd.

Revert "Fix import issue of tests/snappi_tests in python3 (sonic-net#…

a12ac1e

…9232)" This reverts commit a3c0642.

[SNMP]: Add snmp test case using link local as snmpagent address

3491d00

Signed-off-by: Suvarna Meenakshi <[email protected]>

Add test to PR checker

9316dd2

Signed-off-by: Suvarna Meenakshi <[email protected]>

Merge remote-tracking branch 'origin/master' into link_local

6b8f998

Revert "Revert "Fix import issue of tests/snappi_tests in python3 (so…

66cdd4d

…nic-net#9232)"" This reverts commit a12ac1e.

Revert "Revert "[tests/crm] Fix python3 syntax error in `test_acl_ent…

878fa97

…ry` (sonic-net#9208)"" This reverts commit 6ceebe4.

Revert "Revert "Change run_tests.sh to use python3 unconditionally (s…

de9a166

…onic-net#8988)"" This reverts commit d51c9a6.

SuvarnaMeenakshi marked this pull request as draft August 4, 2023 00:49

SuvarnaMeenakshi mentioned this pull request Aug 4, 2023

[SNMP][IPv6]: Fix to use link local IPv6 address as snmp agentAddress sonic-net/sonic-buildimage#16013

Merged

11 tasks

Fix flake8 errors

2e9ecf9

Signed-off-by: Suvarna Meenakshi <[email protected]>

SuvarnaMeenakshi requested review from dgsudharsan and qiluo-msft August 7, 2023 23:28

qiluo-msft reviewed Aug 8, 2023

View reviewed changes

SuvarnaMeenakshi added 5 commits August 8, 2023 00:35

Fix as per review comments

dd256cd

Signed-off-by: Suvarna Meenakshi <[email protected]>

Revert "Change run_tests.sh to use python3 unconditionally (sonic-net…

87ad5db

…#8988)" This reverts commit d88236c.

Revert "Revert "Change run_tests.sh to use python3 unconditionally (s…

28e6321

…onic-net#8988)"" This reverts commit 87ad5db.

Add test_snmp_link_local_ip test to multi-asic VS

21281b9

PR checker. Signed-off-by: Suvarna Meenakshi <[email protected]>

Merge remote-tracking branch 'origin/master' into HEAD

249cf13

SuvarnaMeenakshi marked this pull request as ready for review August 11, 2023 19:28

qiluo-msft approved these changes Aug 11, 2023

View reviewed changes

SuvarnaMeenakshi added Request for 202205 branch Request for 202305 branch labels Aug 14, 2023

SuvarnaMeenakshi merged commit f55ba68 into sonic-net:master Aug 14, 2023

wangxin added the Approved for 202305 branch label Aug 16, 2023

mssonicbld added the Created PR to 202305 branch label Aug 16, 2023

mssonicbld mentioned this pull request Aug 16, 2023

[action] [PR:9268] [SNMP]: Add snmp test case using link local as snmpagent address #9490

Merged

6 tasks

mssonicbld added Included in 202305 branch and removed Created PR to 202305 branch labels Aug 18, 2023

wangxin added the Approved for 202205 branch label Aug 28, 2023

mssonicbld added the Created PR to 202205 branch label Aug 28, 2023

mssonicbld mentioned this pull request Aug 28, 2023

[action] [PR:9268] [SNMP]: Add snmp test case using link local as snmpagent address #9710

Merged

6 tasks

mssonicbld added Included in 202205 branch and removed Created PR to 202205 branch labels Aug 31, 2023

yutongzhang-microsoft mentioned this pull request Oct 25, 2024

Fix mismatch of snmp/test_snmp_link_local.py in .azure-pipelines/pr_test_scripts.yaml #15175

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SNMP]: Add snmp test case using link local as snmpagent address#9268

[SNMP]: Add snmp test case using link local as snmpagent address#9268
SuvarnaMeenakshi merged 15 commits intosonic-net:masterfrom
SuvarnaMeenakshi:link_local

SuvarnaMeenakshi commented Aug 4, 2023 •

edited

Loading

Uh oh!

mssonicbld commented Aug 4, 2023

Uh oh!

mssonicbld commented Aug 4, 2023

Uh oh!

qiluo-msft Aug 8, 2023 •

edited

Loading

Uh oh!

SuvarnaMeenakshi Aug 8, 2023

Uh oh!

qiluo-msft Aug 8, 2023 •

edited

Loading

Uh oh!

SuvarnaMeenakshi Aug 8, 2023

Uh oh!

SuvarnaMeenakshi commented Aug 11, 2023

Uh oh!

azure-pipelines bot commented Aug 11, 2023

Uh oh!

wangxin commented Aug 16, 2023

Uh oh!

mssonicbld commented Aug 16, 2023

Uh oh!

SuvarnaMeenakshi commented Aug 18, 2023

Uh oh!

mssonicbld commented Aug 28, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

SuvarnaMeenakshi commented Aug 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of PR

Type of change

Back port request

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Uh oh!

mssonicbld commented Aug 4, 2023

Uh oh!

mssonicbld commented Aug 4, 2023

Uh oh!

qiluo-msft Aug 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SuvarnaMeenakshi Aug 8, 2023

Choose a reason for hiding this comment

Uh oh!

qiluo-msft Aug 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SuvarnaMeenakshi Aug 8, 2023

Choose a reason for hiding this comment

Uh oh!

SuvarnaMeenakshi commented Aug 11, 2023

Uh oh!

azure-pipelines bot commented Aug 11, 2023

Uh oh!

wangxin commented Aug 16, 2023

Uh oh!

mssonicbld commented Aug 16, 2023

Uh oh!

SuvarnaMeenakshi commented Aug 18, 2023

Uh oh!

mssonicbld commented Aug 28, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

SuvarnaMeenakshi commented Aug 4, 2023 •

edited

Loading

qiluo-msft Aug 8, 2023 •

edited

Loading

qiluo-msft Aug 8, 2023 •

edited

Loading