Fix import issue of tests/snappi_tests in python3#9232
Merged
wangxin merged 2 commits intosonic-net:masterfrom Aug 3, 2023
Merged
Fix import issue of tests/snappi_tests in python3#9232wangxin merged 2 commits intosonic-net:masterfrom
wangxin merged 2 commits intosonic-net:masterfrom
Conversation
To support smooth python3 migration, we need to explicitly specify the python version to be used in each branch. For master branch, default python should be python3. Need to use python3 to run the collect-only check as well. Signed-off-by: Xin Wang <xiwang5@microsoft.com>
wangxin
changed the title
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Aug 3, 2023
What is the motivation for this PR? To support smooth python3 migration, we need to explicitly specify the python version to be used in each branch. For master branch, default python should be python3. Need to use python3 to run the collect-only check as well. Because of the gap in collect-only check of PR testing, some import issues under tests/snappi_tests are not caught. How did you do it? * Use "python3 -m pytest" instead of directly run "pytest" command to do collect-only check. * Fixed all the import issues of tests/snappi_tests in python3. Signed-off-by: Xin Wang <xiwang5@microsoft.com>
Collaborator
|
Cherry-pick PR to 202305: #9246 |
6 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Aug 3, 2023
What is the motivation for this PR? To support smooth python3 migration, we need to explicitly specify the python version to be used in each branch. For master branch, default python should be python3. Need to use python3 to run the collect-only check as well. Because of the gap in collect-only check of PR testing, some import issues under tests/snappi_tests are not caught. How did you do it? * Use "python3 -m pytest" instead of directly run "pytest" command to do collect-only check. * Fixed all the import issues of tests/snappi_tests in python3. Signed-off-by: Xin Wang <xiwang5@microsoft.com>
mssonicbld
added
Included in 202305 branch
and removed
Created PR to 202305 branch
labels
SuvarnaMeenakshi
added a commit
to SuvarnaMeenakshi/sonic-mgmt
that referenced
this pull request
Aug 4, 2023
SuvarnaMeenakshi
added a commit
to SuvarnaMeenakshi/sonic-mgmt
that referenced
this pull request
Aug 4, 2023
…nic-net#9232)"" This reverts commit a12ac1e.
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Jan 25, 2024
What is the motivation for this PR? To support smooth python3 migration, we need to explicitly specify the python version to be used in each branch. For master branch, default python should be python3. Need to use python3 to run the collect-only check as well. Because of the gap in collect-only check of PR testing, some import issues under tests/snappi_tests are not caught. How did you do it? * Use "python3 -m pytest" instead of directly run "pytest" command to do collect-only check. * Fixed all the import issues of tests/snappi_tests in python3. Signed-off-by: Xin Wang <xiwang5@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
To support smooth python3 migration, we need to explicitly specify the python version to be used in each branch. For master branch, default python should be python3. Need to use python3 to run the collect-only check as well.
Because of the gap in collect-only check of PR testing, some import issues under tests/snappi_tests are not caught.
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation