[tests/crm] Fix python3 syntax error in test_acl_entry#9208
Merged
lizhijianrd merged 2 commits intosonic-net:masterfrom Aug 1, 2023
lizhijianrd:fix-crm-test-acl-entry
Merged
[tests/crm] Fix python3 syntax error in test_acl_entry#9208lizhijianrd merged 2 commits intosonic-net:masterfrom lizhijianrd:fix-crm-test-acl-entry
test_acl_entry#9208lizhijianrd merged 2 commits intosonic-net:masterfrom
lizhijianrd:fix-crm-test-acl-entry
Conversation
Blueve
previously approved these changes
Aug 1, 2023
test_acl_entrytest_acl_entry
Blueve
approved these changes
Aug 1, 2023
SuvarnaMeenakshi
added a commit
to SuvarnaMeenakshi/sonic-mgmt
that referenced
this pull request
Aug 4, 2023
…ic-net#9208)" This reverts commit 1c5b8dd.
SuvarnaMeenakshi
added a commit
to SuvarnaMeenakshi/sonic-mgmt
that referenced
this pull request
Aug 4, 2023
…ry` (sonic-net#9208)"" This reverts commit 6ceebe4.
Collaborator
|
Cherry-pick PR to 202305: #9338 |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Aug 8, 2023
) What is the motivation for this PR? Fix a python3 syntax error in testcase crm/test_crm.py::test_acl_entry. In python2 dict.keys() returns a list object, but in python3 it returns a dict_keys object which is not sortable. How did you do it? Use sorted() function instead of dict.keys().sort(). sorted() function can put the keys of a dict in a list in sorted order, and it has same action in Python2 and Python3. How did you verify/test it? Verified by running testcase on Marvell testbed. Signed-off-by: Zhijian Li <[email protected]>
6 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Aug 9, 2023
What is the motivation for this PR? Fix a python3 syntax error in testcase crm/test_crm.py::test_acl_entry. In python2 dict.keys() returns a list object, but in python3 it returns a dict_keys object which is not sortable. How did you do it? Use sorted() function instead of dict.keys().sort(). sorted() function can put the keys of a dict in a list in sorted order, and it has same action in Python2 and Python3. How did you verify/test it? Verified by running testcase on Marvell testbed. Signed-off-by: Zhijian Li <[email protected]>
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Jan 25, 2024
) What is the motivation for this PR? Fix a python3 syntax error in testcase crm/test_crm.py::test_acl_entry. In python2 dict.keys() returns a list object, but in python3 it returns a dict_keys object which is not sortable. How did you do it? Use sorted() function instead of dict.keys().sort(). sorted() function can put the keys of a dict in a list in sorted order, and it has same action in Python2 and Python3. How did you verify/test it? Verified by running testcase on Marvell testbed. Signed-off-by: Zhijian Li <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Testcase
crm/test_crm.py::test_acl_entryhit below error in Python3 env:The root cause is, in python2
dict.keys()returns alistobject, but in python3 it returns adict_keysobject which is not sortable.Use
sorted()function instead ofdict.keys().sort().sorted()function can put the keys of a dict in a list in sorted order, and it has same action in Python2 and Python3.Type of change
Back port request
Approach
What is the motivation for this PR?
Fix a python3 syntax error in testcase
crm/test_crm.py::test_acl_entry.How did you do it?
Use
sorted()function instead ofdict.keys().sort().sorted()function can put the keys of a dict in a list in sorted order, and it has same action in Python2 and Python3.How did you verify/test it?
Verified by running testcase on Marvell testbed.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation