Skip to content

[action] [PR:20095] [dualotr] Fix disruptions after config reload#20222

Open
mssonicbld wants to merge 1 commit intosonic-net:202411from
mssonicbld:cherry/202411/20095
Open

[action] [PR:20095] [dualotr] Fix disruptions after config reload#20222
mssonicbld wants to merge 1 commit intosonic-net:202411from
mssonicbld:cherry/202411/20095

Conversation

@mssonicbld
Copy link
Collaborator

The device could be unstable after config reload, which results in possible packet drop and test failure.
Let's wait for more time after config reload.
And decrease the I/O verification time to 60s to reduce the test runtime.

Description of PR

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
  • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202205
  • 202305
  • 202311
  • 202405
  • 202411
  • 202505

Approach

What is the motivation for this PR?

The device could be unstable after config reload, which results in
possible packet drop and test failure.
Let's wait for more time after config reload.
And decrease the I/O verification time to 60s to reduce the test runtime.

Signed-off-by: Longxiang Lyu <[email protected]

How did you do it?

Reload with safe_reload and wait_for_bgp to allow the DUT to recover.

How did you verify/test it?

dualtor_io/test_link_failure.py::test_active_link_admin_down_config_reload_downstream[active-active-1-10] PASSED [ 10%]
dualtor_io/test_link_failure.py::test_active_link_admin_down_config_reload_downstream[active-active-2-10] PASSED [ 20%]
dualtor_io/test_link_failure.py::test_active_link_admin_down_config_reload_downstream[active-active-3-10] PASSED [ 30%]
dualtor_io/test_link_failure.py::test_active_link_admin_down_config_reload_downstream[active-active-4-10] PASSED [ 40%]
dualtor_io/test_link_failure.py::test_active_link_admin_down_config_reload_downstream[active-active-5-10] PASSED [ 50%]
dualtor_io/test_link_failure.py::test_active_link_admin_down_config_reload_downstream[active-active-6-10] PASSED [ 60%]
dualtor_io/test_link_failure.py::test_active_link_admin_down_config_reload_downstream[active-active-7-10] PASSED [ 70%]
dualtor_io/test_link_failure.py::test_active_link_admin_down_config_reload_downstream[active-active-8-10] PASSED [ 80%]
dualtor_io/test_link_failure.py::test_active_link_admin_down_config_reload_downstream[active-active-9-10] PASSED [ 90%]
dualtor_io/test_link_failure.py::test_active_link_admin_down_config_reload_downstream[active-active-10-10] PASSED [100%]

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

The device could be unstable after config reload, which results in
possible packet drop and test failure.
Let's wait for more time after config reload.
And decrease the I/O verification time to 60s to reduce the test runtime.

Signed-off-by: Longxiang Lyu <[email protected]>
@mssonicbld
Copy link
Collaborator Author

Original PR: #20095

@mssonicbld
Copy link
Collaborator Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator Author

/azp run Azure.sonic-mgmt

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator Author

/azp run Azure.sonic-mgmt

@azure-pipelines
Copy link

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
…omatically (sonic-net#20222)

src/sonic-swss-common

* 3d9f52b - (HEAD -> 202311, origin/202311) Account for control character as part of zmq_read_part (sonic-net#906) (sonic-net#910) (6 hours ago) [mssonicbld]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants