Skip to content

Fix wrong parameter for function check_interfaces_and_services in test_reboot.py#8741

Closed
ZhaohuiS wants to merge 1 commit intosonic-net:masterfrom
ZhaohuiS:fix/test_reboot
Closed

Fix wrong parameter for function check_interfaces_and_services in test_reboot.py#8741
ZhaohuiS wants to merge 1 commit intosonic-net:masterfrom
ZhaohuiS:fix/test_reboot

Conversation

@ZhaohuiS
Copy link
Copy Markdown
Contributor

…t_reboot.py

Description of PR

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205

Approach

What is the motivation for this PR?

It carries wrong parameter into check_interfaces_and_services.
check_interfaces_and_services(dut, interfaces, xcvr_skip_list, reboot_type)

reboot_type is wrongly considered as interfaces_wait_time and causes the following issue.

>       while elapsed_time < timeout:
E       TypeError: '<' not supported between instances of 'int' and 'str'

delay      = 0
elapsed_time = 0
interval   = 20
kwargs     = {}
start_time = 1687524370.1760564
timeout    = 'cold'
def check_interfaces_and_services(dut, interfaces, xcvr_skip_list,
                                  interfaces_wait_time=MAX_WAIT_TIME_FOR_INTERFACES, reboot_type=None):

How did you do it?

Define reboot_type as reboot type, otherwise it is in the position of parameter of interfaces_wait_time.

How did you verify/test it?

Run platform_tests/test_reboot.py

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@wenyiz2021
Copy link
Copy Markdown
Contributor

#8725 this PR fixes same

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants