Fix wrong parameter for function check_interfaces_and_services in test_reboot.py#8741
Closed
ZhaohuiS wants to merge 1 commit intosonic-net:masterfrom
Closed
Fix wrong parameter for function check_interfaces_and_services in test_reboot.py#8741ZhaohuiS wants to merge 1 commit intosonic-net:masterfrom
ZhaohuiS wants to merge 1 commit intosonic-net:masterfrom
Conversation
…t_reboot.py Signed-off-by: Zhaohui Sun <[email protected]>
Contributor
|
#8725 this PR fixes same |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…t_reboot.py
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
It carries wrong parameter into
check_interfaces_and_services.check_interfaces_and_services(dut, interfaces, xcvr_skip_list, reboot_type)reboot_typeis wrongly considered asinterfaces_wait_timeand causes the following issue.How did you do it?
Define reboot_type as reboot type, otherwise it is in the position of parameter of interfaces_wait_time.
How did you verify/test it?
Run
platform_tests/test_reboot.pyAny platform specific information?
Supported testbed topology if it's a new test case?
Documentation