Skip to content

Added ACL tests#87

Merged
pavel-shirshov merged 9 commits intosonic-net:masterfrom
antonpatenko:acl_tests
Jan 23, 2017
Merged

Added ACL tests#87
pavel-shirshov merged 9 commits intosonic-net:masterfrom
antonpatenko:acl_tests

Conversation

@antonpatenko
Copy link
Contributor

@antonpatenko antonpatenko commented Jan 16, 2017

A number of tests, which perform testing the ACL functionality and its' ability to react to incorrect configurations.

@hrachya-m
Copy link

hrachya-m commented Jan 16, 2017

I think you'd also need to add 'expected_files' related files and facts to fib.yml, otherwise it will break.

@pavel-shirshov
Copy link
Contributor

pavel-shirshov commented Jan 18, 2017

Please fix following:

  1. You don't need to use "{{ }}" for constants. You need this construction to expand a variable. See here:
    http://docs.ansible.com/ansible/playbooks_variables.html
    Example from your code:
    loganalyzer_init: "{{ 'roles/test/files/tools/loganalyzer/loganalyzer_init.yml' }}"
    I'd write it as:
    loganalyzer_init: roles/test/files/tools/loganalyzer/loganalyzer_init.yml

  2. You're using a lot of set_fact: in your playbooks. I'd suggest to define vars. You could do this inside of the test role, in individual var files, inside of the playbooks.
    See: http://docs.ansible.com/ansible/playbooks_variables.html

pavel-shirshov
pavel-shirshov suggested changes Jan 18, 2017
View reviewed changes
ansible/roles/test/tasks/acl.yml

- block:
- name: Test file input.
include: "{{ tests_location }}/acl_input_test/acl_input_test.yml"
Copy link
Contributor

@pavel-shirshov pavel-shirshov Jan 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose of {{ tests_location }} ?
Are you going to change the tests location?
For me it is a constant.

Copy link
Contributor Author

@antonpatenko antonpatenko Jan 19, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The using of path to the ACL tests occurs pretty often during the tests execution, so I decided to put it into variable.

Copy link
Contributor

@pavel-shirshov pavel-shirshov Jan 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it Thanks

ansible/roles/test/tasks/acl/acl_counter_traffic_test/acl_counter_traffic_test.yml Outdated
failed_when: ping_result.rc != 0

- name: Wait for counters to update (it updates every 10 sec) ...
shell: sleep 10
Copy link
Contributor

@pavel-shirshov pavel-shirshov Jan 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better use "pause:" instead of shell: sleep 10

@antonpatenko antonpatenko reopened this Jan 20, 2017
@antonpatenko
ACL testing: added files input test.
4ba14d6
@antonpatenko
ACL testing: added port bind test.
17b8ef8
@antonpatenko
ACL testing: added orchagent logic test:
4bf5c70 
    1) syntax testing
    2) configuration removing testing
@antonpatenko
ACL testing: added traffic test.
46183f4
@antonpatenko
ACL testing: added counters test (by running traffic)
6975aff
@antonpatenko
ACL testing: added L4 port ranges test:
4d57486 
1) syntax test
2) traffic test
@antonpatenko
Loganalyzer: fixes to the scripts and common_match:
a44751a 
1) fixed common_match.txt (removed empty line in the end,
   which caused loganalyzer error)
2) changed init- and analyze-scripts according to
   expect-errors-functionality
@antonpatenko
ACL testing: removed ports speed setting.
04fe629
@antonpatenko
ACL tests fixes:
54f2c4c 
1) Removed "set_fact" blocks and moved vars into separated files per each test.
2) Replaced "command: sleep" with "pause".
3) Removed brackets around constants declarations.
@pavel-shirshov pavel-shirshov merged commit d0067bd into sonic-net:master Jan 23, 2017
wangxin pushed a commit to wangxin/sonic-mgmt that referenced this pull request Feb 21, 2025
@yejianquan
Merge pull request sonic-net#87 from yejianquan/jianquanye/202405_nex…
497ea9c 
…t_hop

[Chassis] Fix flakiness of nhop_group, routes not programmed into hardware after port toggle (sonic-net#16959)

Description of PR
Summary:
Fixes flakiness nhop_group failures on chassis.

Approach
What is the motivation for this PR?
Fixes flakiness nhop_group failures on chassis.
We observe flakiness failure on chassis devices
Suspect it's because the route is not programmed into hardware Add external sleep to make sure route is in hardware

How did you do it?
Add extra waiting time for chassis device port toggle tests.

How did you verify/test it?
Run on PR test, and physical test passes

ipfwd/test_nhop_group.py::test_nhop_group_member_count PASSED [ 20%] ipfwd/test_nhop_group.py::test_nhop_group_member_order_capability[str3-xx-1-2] SKIPPED (Order ECMP is not configured so skipping the test-case) [ 40%] ipfwd/test_nhop_group.py::test_nhop_group_interface_flap[str3-xx-1-2] PASSED [ 60%] ipfwd/test_nhop_group.py::test_nhop_group_member_order_capability[str3-xx-1-0] SKIPPED (Order ECMP is not configured so skipping the test-case) [ 80%] ipfwd/test_nhop_group.py::test_nhop_group_interface_flap[str3-xx-1-2] PASSED [100%]

authorized by: jianquanye@microsoft.com
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
@xumia
[Submodule]: update sonic-restapi (sonic-net#10295)
56be714 
[Submodule]: update sonic-restapi
bd97dfe Fix urllib3 CVE-2021-33503 issue (sonic-net#104)
f159bfa Upgrade the containers to be based on Debian Buster (sonic-net#103)
a1830c1 Fix OpenAPI spec to be readable by autorest (sonic-net#101)
94805a3 Identify and report Vnet GUID for conflicting VNI (sonic-net#99)
4832dfd Static route expiry if not specified as persistent (sonic-net#98)
5cc4358 Add support for overlay ECMP (sonic-net#96)
6822a46 [CI] Set diff cover threshold to 50% (sonic-net#97)
dcc826a Add PR diff coverage (sonic-net#95)
e842c5f Generate code coverage for Unit Tests (sonic-net#94)
f9bbed3 Convert Unit Tests from unittest framework to pytest framework (sonic-net#93)
e466ac2 Reject incorrect CIDR addresses while configuring routes (sonic-net#91)
07cf59d [CI] Set up Azure pipeline (sonic-net#89)
47476ac Upgrade Go version to 1.14 (sonic-net#90)
ee887c7 Added flag to make go/pkg/ folder writable (removable) (sonic-net#87)
6cfc8fe (origin/shilongliu/azp) Default Vrf static route support (sonic-net#85)
d3e8b8e Add BFD config to subinterface and neighbor (sonic-net#68)
8d4fd4a Fix WS-2018-0594 potential non-random UUIDs security issue (sonic-net#78)
fad87fa Update API description for default vrf and ecmp routes (sonic-net#82)

Some of them have been updated in 202012 branch, should be added in 202106 as well.
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
@xumia
[Submodule]: Update submodule for sonic-telemetry (sonic-net#10667)
f9f2235 
Why I did it
Update sonic-telemetry submodules (to fix CVE-2021-3121 alert).

e56e9b4 Fix CVE-2021-3121 warning (sonic-net#96)
bf1be4f [ci]: Support code diff coverage threshold 50% (sonic-net#94)
64e516c Ported Marvell armhf build on x86 for debian buster to use cross-compilation instead of qemu emulation (sonic-net#80)
e426388 [ci]: Support azp code coverage (sonic-net#87)
0443e66 Remove DB Directory removal as part of make clean (sonic-net#84)
085f29d Fix unhandled nil err check to prevent rpc causing a crash (sonic-net#78)
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
@xumia @judyjoseph
[Submodule]: Update submodule for sonic-telemetry (sonic-net#10124)
7b84abc 
e56e9b4 Fix CVE-2021-3121 warning (sonic-net#96)
bf1be4f [ci]: Support code diff coverage threshold 50% (sonic-net#94)
64e516c Ported Marvell armhf build on x86 for debian buster to use cross-compilation instead of qemu emulation (sonic-net#80)
e426388 [ci]: Support azp code coverage (sonic-net#87)
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
@abdosi
[submodule update] sonic-platform-daemons
942c86f 
  [MultiDB] shoule use multiDB API (sonic-net#57)
 [Thermal] Fix for 'show platform fan' command (sonic-net#71)
  [xcvrd] Return non-zero error code on SFP error (sonic-net#67)
Multi-asic changes commit (PR sonic-net#64 ) into 201911
  [ledd][multi-ASIC] Update to ledd based on sonic-swss-common updates (sonic-net#87)

Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
@abdosi
[Submodule Update] sonic-restapi
44d2ec6 
e466ac226c48cf87f83aa5564efd7155ac97a0c1 (HEAD -> master, origin/master, origin/HEAD) Reject incorrect CIDR addresses while configuring routes (sonic-net#91)
07cf59d866914ef7cb6901d51f289f0bee721e44 [CI] Set up Azure pipeline (sonic-net#89)
47476acdfaf668ab0cd9ae2443205a3bdc2e9ef9 Upgrade Go version to 1.14 (sonic-net#90)
ee887c785c10d8b4f70db90ca50cc398327c5d73 Added flag to make go/pkg/ folder writable (removable) (sonic-net#87)
6cfc8fe110c46a1ee5a8430e02a440b5a7b4006d (origin/shilongliu/azp) Default Vrf static route support (sonic-net#85)
d3e8b8e4aee278fa11d7d86acabdab3fffc70d5a Add BFD config to subinterface and neighbor (sonic-net#68)
8d4fd4a56b637d3b7403c321aef36b8dff58cd62 Fix WS-2018-0594 potential non-random UUIDs security issue (sonic-net#78)
fad87fa20f6b15e28c90e02a131c44d236d6a751 Update API description for default vrf and ecmp routes (sonic-net#82)

Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@pavel-shirshov pavel-shirshov pavel-shirshov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@antonpatenko @hrachya-m @pavel-shirshov