[Chassis] Fix flakiness of nhop_group, routes not programmed into har…#16959
Merged
yejianquan merged 1 commit intosonic-net:masterfrom Feb 14, 2025
Merged
[Chassis] Fix flakiness of nhop_group, routes not programmed into har…#16959yejianquan merged 1 commit intosonic-net:masterfrom
yejianquan merged 1 commit intosonic-net:masterfrom
Conversation
…dward after port toggle
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
auspham
approved these changes
Feb 14, 2025
Collaborator
Author
|
ipfwd/test_nhop_group.py::test_nhop_group_member_count PASSED [ 20%] |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Feb 14, 2025
…dward after port toggle (sonic-net#16959) …dward after port toggle Description of PR Summary: Fixes flakiness nhop_group failures on chassis. Approach What is the motivation for this PR? Fixes flakiness nhop_group failures on chassis. We observe flakiness failure on chassis devices Suspect it's because the route is not programmed into hardware Add external sleep to make sure route is in hardware How did you do it? Add extra waiting time for chassis device port toggle tests. How did you verify/test it? Run on PR test, and physical test passes ipfwd/test_nhop_group.py::test_nhop_group_member_count PASSED [ 20%] ipfwd/test_nhop_group.py::test_nhop_group_member_order_capability[str3-xx-1-2] SKIPPED (Order ECMP is not configured so skipping the test-case) [ 40%] ipfwd/test_nhop_group.py::test_nhop_group_interface_flap[str3-xx-1-2] PASSED [ 60%] ipfwd/test_nhop_group.py::test_nhop_group_member_order_capability[str3-xx-1-0] SKIPPED (Order ECMP is not configured so skipping the test-case) [ 80%] ipfwd/test_nhop_group.py::test_nhop_group_interface_flap[str3-xx-1-2] PASSED [100%] authorized by: [email protected]
Collaborator
|
Cherry-pick PR to 202411: #16974 |
Merged
11 tasks
Collaborator
Author
|
202405.msft: Azure/sonic-mgmt.msft#87 |
yejianquan
added
Included in msft-202405 Branch
and removed
Cherry Pick Conflict_msft-202405
labels
mssonicbld
pushed a commit
that referenced
this pull request
Feb 14, 2025
…dward after port toggle (#16959) …dward after port toggle Description of PR Summary: Fixes flakiness nhop_group failures on chassis. Approach What is the motivation for this PR? Fixes flakiness nhop_group failures on chassis. We observe flakiness failure on chassis devices Suspect it's because the route is not programmed into hardware Add external sleep to make sure route is in hardware How did you do it? Add extra waiting time for chassis device port toggle tests. How did you verify/test it? Run on PR test, and physical test passes ipfwd/test_nhop_group.py::test_nhop_group_member_count PASSED [ 20%] ipfwd/test_nhop_group.py::test_nhop_group_member_order_capability[str3-xx-1-2] SKIPPED (Order ECMP is not configured so skipping the test-case) [ 40%] ipfwd/test_nhop_group.py::test_nhop_group_interface_flap[str3-xx-1-2] PASSED [ 60%] ipfwd/test_nhop_group.py::test_nhop_group_member_order_capability[str3-xx-1-0] SKIPPED (Order ECMP is not configured so skipping the test-case) [ 80%] ipfwd/test_nhop_group.py::test_nhop_group_interface_flap[str3-xx-1-2] PASSED [100%] authorized by: [email protected]
mssonicbld
added
Included in 202411 branch
and removed
Created PR to 202411 branch
labels
wangxin
pushed a commit
to wangxin/sonic-mgmt
that referenced
this pull request
Feb 21, 2025
…dward after port toggle (sonic-net#16959) …dward after port toggle Description of PR Summary: Fixes flakiness nhop_group failures on chassis. Approach What is the motivation for this PR? Fixes flakiness nhop_group failures on chassis. We observe flakiness failure on chassis devices Suspect it's because the route is not programmed into hardware Add external sleep to make sure route is in hardware How did you do it? Add extra waiting time for chassis device port toggle tests. How did you verify/test it? Run on PR test, and physical test passes ipfwd/test_nhop_group.py::test_nhop_group_member_count PASSED [ 20%] ipfwd/test_nhop_group.py::test_nhop_group_member_order_capability[str3-xx-1-2] SKIPPED (Order ECMP is not configured so skipping the test-case) [ 40%] ipfwd/test_nhop_group.py::test_nhop_group_interface_flap[str3-xx-1-2] PASSED [ 60%] ipfwd/test_nhop_group.py::test_nhop_group_member_order_capability[str3-xx-1-0] SKIPPED (Order ECMP is not configured so skipping the test-case) [ 80%] ipfwd/test_nhop_group.py::test_nhop_group_interface_flap[str3-xx-1-2] PASSED [100%] authorized by: [email protected]
wangxin
pushed a commit
to wangxin/sonic-mgmt
that referenced
this pull request
Feb 21, 2025
…t_hop [Chassis] Fix flakiness of nhop_group, routes not programmed into hardware after port toggle (sonic-net#16959) Description of PR Summary: Fixes flakiness nhop_group failures on chassis. Approach What is the motivation for this PR? Fixes flakiness nhop_group failures on chassis. We observe flakiness failure on chassis devices Suspect it's because the route is not programmed into hardware Add external sleep to make sure route is in hardware How did you do it? Add extra waiting time for chassis device port toggle tests. How did you verify/test it? Run on PR test, and physical test passes ipfwd/test_nhop_group.py::test_nhop_group_member_count PASSED [ 20%] ipfwd/test_nhop_group.py::test_nhop_group_member_order_capability[str3-xx-1-2] SKIPPED (Order ECMP is not configured so skipping the test-case) [ 40%] ipfwd/test_nhop_group.py::test_nhop_group_interface_flap[str3-xx-1-2] PASSED [ 60%] ipfwd/test_nhop_group.py::test_nhop_group_member_order_capability[str3-xx-1-0] SKIPPED (Order ECMP is not configured so skipping the test-case) [ 80%] ipfwd/test_nhop_group.py::test_nhop_group_interface_flap[str3-xx-1-2] PASSED [100%] authorized by: [email protected]
nnelluri-cisco
pushed a commit
to nnelluri-cisco/sonic-mgmt
that referenced
this pull request
Mar 15, 2025
…dward after port toggle (sonic-net#16959) …dward after port toggle Description of PR Summary: Fixes flakiness nhop_group failures on chassis. Approach What is the motivation for this PR? Fixes flakiness nhop_group failures on chassis. We observe flakiness failure on chassis devices Suspect it's because the route is not programmed into hardware Add external sleep to make sure route is in hardware How did you do it? Add extra waiting time for chassis device port toggle tests. How did you verify/test it? Run on PR test, and physical test passes ipfwd/test_nhop_group.py::test_nhop_group_member_count PASSED [ 20%] ipfwd/test_nhop_group.py::test_nhop_group_member_order_capability[str3-xx-1-2] SKIPPED (Order ECMP is not configured so skipping the test-case) [ 40%] ipfwd/test_nhop_group.py::test_nhop_group_interface_flap[str3-xx-1-2] PASSED [ 60%] ipfwd/test_nhop_group.py::test_nhop_group_member_order_capability[str3-xx-1-0] SKIPPED (Order ECMP is not configured so skipping the test-case) [ 80%] ipfwd/test_nhop_group.py::test_nhop_group_interface_flap[str3-xx-1-2] PASSED [100%] authorized by: [email protected]
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…dward after port toggle
Description of PR
Summary:
Fixes flakiness nhop_group failures on chassis.
Type of change
Back port request
Approach
What is the motivation for this PR?
Fixes flakiness nhop_group failures on chassis.
We observe flakiness failure on chassis devices
Suspect it's because the route is not programmed into hardware
Add external sleep to make sure route is in hardware
How did you do it?
Add extra waiting time for chassis device port toggle tests.
How did you verify/test it?
Run on PR test, and physical testbed.
ipfwd/test_nhop_group.py::test_nhop_group_member_count PASSED [ 20%]
ipfwd/test_nhop_group.py::test_nhop_group_member_order_capability[str3-xx-1-2] SKIPPED (Order ECMP is not configured so skipping the test-case) [ 40%]
ipfwd/test_nhop_group.py::test_nhop_group_interface_flap[str3-xx-1-2] PASSED [ 60%]
ipfwd/test_nhop_group.py::test_nhop_group_member_order_capability[str3-xx-1-0] SKIPPED (Order ECMP is not configured so skipping the test-case) [ 80%]
ipfwd/test_nhop_group.py::test_nhop_group_interface_flap[str3-xx-1-2] PASSED [100%]
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation