[fib][j2][routes] Generate route with port indices#67
Merged
lguohan merged 1 commit intosonic-net:masterfrom Dec 12, 2016
Merged
[fib][j2][routes] Generate route with port indices#67lguohan merged 1 commit intosonic-net:masterfrom
lguohan merged 1 commit intosonic-net:masterfrom
Conversation
lguohan
reviewed
Dec 12, 2016
ansible/roles/test/templates/fib.j2
Outdated
Contributor
There was a problem hiding this comment.
filter for "fortyGigE/0" is not needed since you already applied the reverse map. the interface name are standardized to Ethernet{n}.
lguohan
requested changes
Dec 12, 2016
Contributor
lguohan
left a comment
lguohan
left a comment
There was a problem hiding this comment.
please remove fortyGigE/0 related filter.
lguohan
reviewed
Dec 12, 2016
ansible/roles/test/templates/fib.j2
Outdated
Contributor
There was a problem hiding this comment.
why 02d? what if the port number is 3-digit?
* Generating route info file to have port indices instead of port names. signed-off-by [email protected]
lguohan
approved these changes
Dec 12, 2016
wangxin
pushed a commit
to wangxin/sonic-mgmt
that referenced
this pull request
Feb 21, 2025
<!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Summary: Increase some tolerance for m2o cases since the normal `round()` requires exactly .5 above to be rounded up. Fixes # (issue) 3192364 ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [ ] Test case improvement ### Back port request - [ ] 202012 - [ ] 202205 - [ ] 202305 - [ ] 202311 - [x] 202405 - [x] 202411 ### Approach #### What is the motivation for this PR? Increase some tolerance for our test case #### How did you do it? #### How did you verify/test it? validated on T2 testbed 8800 #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
- Adding instructions to build telemetry server/go client inside docker (sonic-net#68) - Add RBAC, gNOI, API Versioning and Bulk Set operations. (sonic-net#61) … - Support NonTLS option for testing purpose only. (sonic-net#67) … - Oc gnmi examples (sonic-net#62) …
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
[sonic-linkmgrd][202012] submodule update 3d13ff2 Jing Zhang Wed May 4 10:07:14 2022 -0700 Add doc for default route related changes (sonic-net#63) c703be4 Jing Zhang Mon May 2 13:27:54 2022 -0700 Reset WaitActiveUp count before switching to active (sonic-net#70) 86eb727 Jing Zhang Wed Apr 27 10:35:05 2022 -0700 lower log level to warning (sonic-net#69) e22c736 Jing Zhang Mon May 2 13:33:24 2022 -0700 [202012] Avoid proactively switching to active if default route is missing (sonic-net#67) d4f282b Jing Zhang Thu Apr 28 18:35:11 2022 -0700 [202012] Add support to enable switchover time measurement (with link prober interval decreased to 10ms) feature (sonic-net#66) sign-off: Jing Zhang [[email protected]](mailto:[email protected])
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
[MultiDB] shoule use multiDB API (sonic-net#57) [Thermal] Fix for 'show platform fan' command (sonic-net#71) [xcvrd] Return non-zero error code on SFP error (sonic-net#67) Multi-asic changes commit (PR sonic-net#64 ) into 201911 [ledd][multi-ASIC] Update to ledd based on sonic-swss-common updates (sonic-net#87) Signed-off-by: Abhishek Dosi <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
signed-off-by [email protected]