Skip to content

[chassis] accommodate snmp test that uses pdu controller for chassis #8674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wenyiz2021 merged 7 commits into from
Jun 26, 2023
Merged

[chassis] accommodate snmp test that uses pdu controller for chassis #8674

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f77e544
Update utilities.py
wenyiz2021 Jun 16, 2023
2424c02
Update __init__.py
wenyiz2021 Jun 16, 2023
5312269
Update test_platform_info.py
wenyiz2021 Jun 16, 2023
3d023ba
move power off reboot to separate file
wenyiz2021 Jun 16, 2023
ebc1caa
Create test_power_off_reboot.py
wenyiz2021 Jun 16, 2023
dea90df
Merge branch 'sonic-net:master' into pdu_controller
wenyiz2021 Jun 20, 2023
8ab5ff8
Update test_snmp_phy_entity.py
wenyiz2021 Jun 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/snmp/test_snmp_phy_entity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -619,7 +619,7 @@ def _get_transceiver_sensor_data(duthost, name):


@pytest.mark.disable_loganalyzer
def test_turn_off_psu_and_check_psu_info(duthosts, enum_rand_one_per_hwsku_hostname,
def test_turn_off_psu_and_check_psu_info(duthosts, enum_supervisor_dut_hostname,
localhost, creds_all_duts,
pdu_controller):
"""
Expand All @@ -630,7 +630,7 @@ def test_turn_off_psu_and_check_psu_info(duthosts, enum_rand_one_per_hwsku_hostn
:param pdu_controller: PDU controller
:return:
"""
duthost = duthosts[enum_rand_one_per_hwsku_hostname]
duthost = duthosts[enum_supervisor_dut_hostname]
Copy link
Copy Markdown
Contributor

@SuvarnaMeenakshi SuvarnaMeenakshi Jun 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change seems ok.
Shouldn't skip handle this scenario, why do we need to run only on supervisor?

Copy link
Copy Markdown
Contributor Author

@wenyiz2021 wenyiz2021 Jun 21, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

old behavior should also be fine.
old:
for chassis it choose sup and cards, but cards were skipped
new:
for chassis it choose sup only

the only pros is we can avoid some skipped tests in pipeline result.

if not pdu_controller:
pytest.skip('psu_controller is None, skipping this test')
outlet_status = pdu_controller.get_outlet_status()
Expand Down