Skip to content

add /etc/mlnx/msn2700 start/stop in syncd service#74

Merged
lguohan merged 1 commit intosonic-net:masterfrom
lguohan:msn2700
Jan 4, 2017
Merged

add /etc/mlnx/msn2700 start/stop in syncd service#74
lguohan merged 1 commit intosonic-net:masterfrom
lguohan:msn2700

Conversation

@lguohan
Copy link
Contributor

@lguohan lguohan commented Jan 4, 2017

No description provided.

@marian-pritsak
Copy link
Contributor

Is hw-management going to be used by syncd or some other docker?

@lguohan
Copy link
Contributor Author

lguohan commented Jan 4, 2017

hw-management is not going to be used by syncd. The reason to add here is that sx-kernel stop will fail if we do not do msn2700 stop as drivers in hw-management depends on the drivers in sx-kernel.

@marian-pritsak
Copy link
Contributor

Yes, but if it is going to be used by another entity, my concern is if we will have any troubles with synchronization between hw-management and its client

@lguohan
Copy link
Contributor Author

lguohan commented Jan 4, 2017

agree with your concern, but I do not have any other solution.

@marian-pritsak
Copy link
Contributor

Ok then
Anyway, if we'll have such a problem, systemd allows to put dependencies between cervices

@lguohan lguohan merged commit 18c28d5 into sonic-net:master Jan 4, 2017
@lguohan
Copy link
Contributor Author

lguohan commented Jan 4, 2017

btw, I think the solution is to not to restart sx-kernel when you update the sdk, or make the hw-management not to depend on the sx-kernel. that requires some work on your side.

@marian-pritsak
Copy link
Contributor

I'm afraid it is not possible
If we update sdk, sx-kernel is always restarted because it is simply another binary
And hw-management uses sx-core from sx-kernel as a backbone to talk to ASIC, It cannot be standalone

wangxin pushed a commit to wangxin/sonic-mgmt that referenced this pull request Feb 21, 2025
<!--
Please make sure you've read and understood our contributing guidelines;
https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md

Please provide following information to help code review process a bit easier:
-->
### Description of PR
<!--
- Please include a summary of the change and which issue is fixed.
- Please also include relevant motivation and context. Where should reviewer start? background context?
- List any dependencies that are required for this change.
-->

Summary:
Fixes sonic-net#16898

### Type of change

<!--
- Fill x for your type of change.
- e.g.
- [x] Bug fix
-->

- [x] Bug fix
- [ ] Testbed and Framework(new/improvement)
- [ ] New Test case
 - [ ] Skipped for non-supported platforms
- [ ] Test case improvement

### Back port request
- [ ] 202012
- [ ] 202205
- [ ] 202305
- [ ] 202311
- [ ] 202405
- [ ] 202411

### Approach
#### What is the motivation for this PR?
PR sonic-net#16736 reintroduces bug that we previously fixed in sonic-net#16313 by making it only applying it to Cisco chassis.

#### How did you do it?
Let `duthosts` be passed to `reboot_and_check` for all T2/chassis devices

#### How did you verify/test it?
Run on non Cisco T2 device

#### Any platform specific information?
N/A

#### Supported testbed topology if it's a new test case?
N/A

### Documentation
<!--
(If it's a new feature, new test case)
Did you update documentation/Wiki relevant to your implementation?
Link to the wiki page?
-->
N/A
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
3893844 2018-12-14 | uart: fix race in uart_write() (sonic-net#74) (HEAD, azure/201803) [lguohan]

Signed-off-by: Guohan Lu <[email protected]>
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
[Chassis base] Add sfp error event definition sonic-net#80
SFP(sff8472 attributes) transciever eeprom attribute support sonic-net#74
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
 [MultiDB]: use python class composition to avoid confusion in base
class (sonic-net#74)
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
cc4c4db14439a2b91690df0189b62e011ec41f4c (HEAD -> 201911, origin/201911) Merge pull request sonic-net#74 from project-arlo/fix_otel_dep_error
44df06e0d44bdf7ce49d4eb05ced34f06eb65133 Make sure redis library is checkout with correct commit ID
7ab88143fa4b89d2d7b8030c9ac7b5e6dba16251 Remove unsupported commands (sonic-net#62)

Signed-off-by: Abhishek Dosi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants