Add T2 support to test_power_off_reboot.py#16313
Merged
arlakshm merged 2 commits intosonic-net:masterfrom Jan 29, 2025
Merged
Conversation
* Change checking each PDU for power, to checkings sets of PDUs associated to PSU for at least one power * Add duthosts to reboot_and_check for support on sup cards Signed-off-by: Javier Tan javiertan@microsoft.com
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Javier-Tan
changed the title
arlakshm
previously approved these changes
Jan 4, 2025
|
Commenter does not have sufficient privileges for PR 16313 in repo sonic-net/sonic-mgmt |
liamkearney-msft
approved these changes
Jan 5, 2025
Contributor
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…grouped PDUs * Simplify an iterator operation * Change power_on_seq to use PDUs by PSUs rather than individual PDUs Signed-off-by: Javier Tan javiertan@microsoft.com
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
arlakshm
approved these changes
Jan 11, 2025
Javier-Tan
changed the title
Javier-Tan
added
Request for msft-202405 Branch
and removed
Request for 202405 branch
labels
8 tasks
Collaborator
|
Cherry-pick PR to msft-202405: Azure/sonic-mgmt.msft#31 |
11 tasks
This was referenced Feb 11, 2025
yejianquan
pushed a commit
that referenced
this pull request
Feb 12, 2025
…2 devices get test_power_off_reboot.py fix (#16899) Description of PR Summary: Fixes #16898 Approach What is the motivation for this PR? PR #16736 reintroduces bug that we previously fixed in #16313 by making it only applying it to Cisco chassis. How did you do it? Let duthosts be passed to reboot_and_check for all T2/chassis devices How did you verify/test it? Run on non Cisco T2 device Signed-off-by: Javier Tan javiertan@microsoft.com
mssonicbld
added a commit
to mssonicbld/sonic-mgmt.msft
that referenced
this pull request
Feb 12, 2025
<!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Summary: Fixes #16898 ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [x] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [ ] Test case improvement ### Back port request - [ ] 202012 - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 ### Approach #### What is the motivation for this PR? PR sonic-net/sonic-mgmt#16736 reintroduces bug that we previously fixed in sonic-net/sonic-mgmt#16313 by making it only applying it to Cisco chassis. #### How did you do it? Let `duthosts` be passed to `reboot_and_check` for all T2/chassis devices #### How did you verify/test it? Run on non Cisco T2 device #### Any platform specific information? N/A #### Supported testbed topology if it's a new test case? N/A ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? --> N/A
Merged
11 tasks
mssonicbld
added a commit
to Azure/sonic-mgmt.msft
that referenced
this pull request
Feb 12, 2025
<!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Summary: Fixes #16898 ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [x] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [ ] Test case improvement ### Back port request - [ ] 202012 - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 ### Approach #### What is the motivation for this PR? PR sonic-net/sonic-mgmt#16736 reintroduces bug that we previously fixed in sonic-net/sonic-mgmt#16313 by making it only applying it to Cisco chassis. #### How did you do it? Let `duthosts` be passed to `reboot_and_check` for all T2/chassis devices #### How did you verify/test it? Run on non Cisco T2 device #### Any platform specific information? N/A #### Supported testbed topology if it's a new test case? N/A ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? --> N/A
nnelluri-cisco
pushed a commit
to nnelluri-cisco/sonic-mgmt
that referenced
this pull request
Mar 15, 2025
What is the motivation for this PR? Test failures on T2 devices How did you do it? Change check for power on each PDU to check for power on sets of PDUs (by PSU), add duthosts argument to reboot_and_check function to support sup cards How did you verify/test it? Perform regression test on T1 https://elastictest.org/scheduler/testplan/677b439de1be6860ea024869?testcase=platform_tests%2Ftest_power_off_reboot.py&type=console Perform test on T2 to ensure these failures are gone (still failure in sonic-net#16289) Signed-off-by: Javier Tan javiertan@microsoft.com
nnelluri-cisco
pushed a commit
to nnelluri-cisco/sonic-mgmt
that referenced
this pull request
Mar 15, 2025
…2 devices get test_power_off_reboot.py fix (sonic-net#16899) Description of PR Summary: Fixes sonic-net#16898 Approach What is the motivation for this PR? PR sonic-net#16736 reintroduces bug that we previously fixed in sonic-net#16313 by making it only applying it to Cisco chassis. How did you do it? Let duthosts be passed to reboot_and_check for all T2/chassis devices How did you verify/test it? Run on non Cisco T2 device Signed-off-by: Javier Tan javiertan@microsoft.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes #16279, update platform_tests/power_off_reboot.py to support T2 devices
Type of change
Back port request
Approach
What is the motivation for this PR?
Test failures on T2 devices
How did you do it?
Change check for power on each PDU to check for power on sets of PDUs (by PSU), add duthosts argument to
reboot_and_checkfunction to support sup cardsHow did you verify/test it?
Perform regression test on T1 https://elastictest.org/scheduler/testplan/677b439de1be6860ea024869?testcase=platform_tests%2Ftest_power_off_reboot.py&type=console
Perform test on T2 to ensure these failures are gone (still failure in #16289)
Any platform specific information?
N/A
Supported testbed topology if it's a new test case?
N/A
Documentation