[Snappi] Increase number of calls for ARP wait#7370
Merged
yxieca merged 1 commit intosonic-net:masterfrom Feb 7, 2023
Merged
Conversation
neethajohn
approved these changes
Feb 1, 2023
wangxin
pushed a commit
that referenced
this pull request
Feb 8, 2023
Description of PR Summary: For specific snappi test runs, especially during the reboot test cases, the existing wait time on ARP was not sufficient, causing an ARP timeout. Hence, the number of rounds for waiting on ARP resolution has been increased from 10 to 30. What is the motivation for this PR? Prevent ARP resolution failures during PFC/PFCWD test runs using the Snappi API. How did you do it? Increased the max number of attempts for establishing a connection from 10 to 30. How did you verify/test it? Ran the entire test suite - passed.
wangxin
pushed a commit
that referenced
this pull request
Feb 8, 2023
Description of PR Summary: For specific snappi test runs, especially during the reboot test cases, the existing wait time on ARP was not sufficient, causing an ARP timeout. Hence, the number of rounds for waiting on ARP resolution has been increased from 10 to 30. What is the motivation for this PR? Prevent ARP resolution failures during PFC/PFCWD test runs using the Snappi API. How did you do it? Increased the max number of attempts for establishing a connection from 10 to 30. How did you verify/test it? Ran the entire test suite - passed.
kellyyeh
pushed a commit
to kellyyeh/sonic-mgmt
that referenced
this pull request
Mar 31, 2023
Description of PR Summary: For specific snappi test runs, especially during the reboot test cases, the existing wait time on ARP was not sufficient, causing an ARP timeout. Hence, the number of rounds for waiting on ARP resolution has been increased from 10 to 30. What is the motivation for this PR? Prevent ARP resolution failures during PFC/PFCWD test runs using the Snappi API. How did you do it? Increased the max number of attempts for establishing a connection from 10 to 30. How did you verify/test it? Ran the entire test suite - passed.
auspham
added a commit
to auspham/sonic-mgmt
that referenced
this pull request
Jan 21, 2025
Signed-off-by: Austin Pham <austinpham@microsoft.com>
auspham
added a commit
to auspham/sonic-mgmt
that referenced
this pull request
Jan 21, 2025
Signed-off-by: Austin Pham <austinpham@microsoft.com>
auspham
added a commit
to auspham/sonic-mgmt
that referenced
this pull request
Jan 22, 2025
fix: migrate sonic-net#7370 to multidut code Signed-off-by: Austin Pham <austinpham@microsoft.com> fix: migrate sonic-net#9567 to multidut code Signed-off-by: Austin Pham <austinpham@microsoft.com> fix: migrate sonic-net#7367 to multidut code Signed-off-by: Austin Pham <austinpham@microsoft.com> fix: migrate sonic-net#7712 Signed-off-by: Austin Pham <austinpham@microsoft.com> fix: migrate sonic-net#7712 to pfcwd_multidut_runtime_traffic_helper Signed-off-by: Austin Pham <austinpham@microsoft.com> chore: update a2a parameterize Signed-off-by: Austin Pham <austinpham@microsoft.com>
auspham
added a commit
to auspham/sonic-mgmt
that referenced
this pull request
Jan 22, 2025
fix: migrate sonic-net#7370 to multidut code Signed-off-by: Austin Pham <austinpham@microsoft.com> fix: migrate sonic-net#9567 to multidut code Signed-off-by: Austin Pham <austinpham@microsoft.com> fix: migrate sonic-net#7367 to multidut code Signed-off-by: Austin Pham <austinpham@microsoft.com> fix: migrate sonic-net#7712 Signed-off-by: Austin Pham <austinpham@microsoft.com> fix: migrate sonic-net#7712 to pfcwd_multidut_runtime_traffic_helper Signed-off-by: Austin Pham <austinpham@microsoft.com> chore: update a2a parameterize Signed-off-by: Austin Pham <austinpham@microsoft.com>
11 tasks
yejianquan
pushed a commit
that referenced
this pull request
Jan 29, 2025
Summary: Update the missing T0 T1 tests feature in multidut Fixes # (issue) 30929279 The following PR were migrated for pfcwd [Snappi] Increase number of calls for ARP wait #7370 [Snappi] PFCWD Tolerance Fixes #9567 [Snappi] Modifications to pfcwd a2a test design for mlnx 4600c #7367 to multidut code [Snappi] Modified pfcwd tests to add warm-up traffic #7712 Signed-off-by: Austin Pham <austinpham@microsoft.com>
mssonicbld
added a commit
to mssonicbld/sonic-mgmt.msft
that referenced
this pull request
Jan 29, 2025
Summary: Update the missing T0 T1 tests feature in multidut Fixes # (issue) 30929279 The following PR were migrated for pfcwd - sonic-net/sonic-mgmt#7370 - sonic-net/sonic-mgmt#9567 - sonic-net/sonic-mgmt#7367 to multidut code - sonic-net/sonic-mgmt#7712 ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [ ] Test case improvement ### Back port request - [ ] 202012 - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 ### Approach #### What is the motivation for this PR? #### How did you do it? #### How did you verify/test it? #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? --> snappi_tests/multidut/pfcwd/test_multidut_pfcwd_m2o_with_snappi.py ``` -- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html - generated xml file: /var/src/sonic-mgmt_vmsvc5-t2-8800-ixia_669de75fbbfea63e8b73b319/tests/logs/snappi_tests/multidut/pfcwd/test_multidut_pfcwd_m2o_with_snappi.xml - ================== 4 passed, 7 warnings in 1235.72s (0:20:35) ================== ``` snappi_tests/multidut/pfcwd/test_multidut_pfcwd_burst_storm_with_snappi.py ``` -- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html - generated xml file: /var/src/sonic-mgmt_vmsvc5-t2-8800-ixia_669de75fbbfea63e8b73b319/tests/logs/snappi_tests/multidut/pfcwd/test_multidut_pfcwd_burst_storm_with_snappi.xml - ================== 2 passed, 5 warnings in 858.60s (0:14:18) =================== ``` snappi_tests/multidut/pfcwd/test_multidut_pfcwd_basic_with_snappi.py (known failure on T2, fail as expected) ``` SKIPPED [4] snappi_tests/multidut/pfcwd/test_multidut_pfcwd_basic_with_snappi.py:190: Reboot type fast is not supported on cisco-8000 switches FAILED snappi_tests/multidut/pfcwd/test_multidut_pfcwd_basic_with_snappi.py::test_pfcwd_basic_multi_lossless_prio_restart_service[multidut_port_info0-True-swss] ===== 1 failed, 23 passed, 16 skipped, 27 warnings in 27779.49s (7:42:59) ====== ``` snappi_tests/multidut/pfcwd/test_multidut_pfcwd_a2a_with_snappi.py ``` -- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html - generated xml file: /var/src/sonic-mgmt_vmsvc5-t2-8800-ixia_669de75fbbfea63e8b73b319/tests/logs/snappi_tests/multidut/pfcwd/test_multidut_pfcwd_a2a_with_snappi.xml - ================== 4 passed, 7 warnings in 1157.40s (0:19:17) ================== ``` snappi_tests/multidut/pfcwd/test_multidut_pfcwd_runtime_traffic_with_snappi.py ``` -- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html - generated xml file: /var/src/sonic-mgmt_vmsvc5-t2-8800-ixia_669de75fbbfea63e8b73b319/tests/logs/snappi_tests/multidut/pfcwd/test_multidut_pfcwd_runtime_traffic_with_snappi.xml - ================== 2 passed, 6 warnings in 1162.35s (0:19:22) ================== ```
11 tasks
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jan 29, 2025
Summary: Update the missing T0 T1 tests feature in multidut Fixes # (issue) 30929279 The following PR were migrated for pfcwd [Snappi] Increase number of calls for ARP wait sonic-net#7370 [Snappi] PFCWD Tolerance Fixes sonic-net#9567 [Snappi] Modifications to pfcwd a2a test design for mlnx 4600c sonic-net#7367 to multidut code [Snappi] Modified pfcwd tests to add warm-up traffic sonic-net#7712 Signed-off-by: Austin Pham <austinpham@microsoft.com>
11 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Jan 29, 2025
Summary: Update the missing T0 T1 tests feature in multidut Fixes # (issue) 30929279 The following PR were migrated for pfcwd [Snappi] Increase number of calls for ARP wait #7370 [Snappi] PFCWD Tolerance Fixes #9567 [Snappi] Modifications to pfcwd a2a test design for mlnx 4600c #7367 to multidut code [Snappi] Modified pfcwd tests to add warm-up traffic #7712 Signed-off-by: Austin Pham <austinpham@microsoft.com>
nnelluri-cisco
pushed a commit
to nnelluri-cisco/sonic-mgmt
that referenced
this pull request
Mar 15, 2025
Summary: Update the missing T0 T1 tests feature in multidut Fixes # (issue) 30929279 The following PR were migrated for pfcwd [Snappi] Increase number of calls for ARP wait sonic-net#7370 [Snappi] PFCWD Tolerance Fixes sonic-net#9567 [Snappi] Modifications to pfcwd a2a test design for mlnx 4600c sonic-net#7367 to multidut code [Snappi] Modified pfcwd tests to add warm-up traffic sonic-net#7712 Signed-off-by: Austin Pham <austinpham@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: For specific snappi test runs, especially during the reboot test cases, the existing wait time on ARP was not sufficient, causing an ARP timeout. Hence, the number of rounds for waiting on ARP resolution has been increased from 10 to 30.
Type of change
Back port request
Approach
What is the motivation for this PR?
Prevent ARP resolution failures during PFC/PFCWD test runs using the Snappi API.
How did you do it?
Increased the max number of attempts for establishing a connection from 10 to 30.
How did you verify/test it?
Ran the entire test suite - passed.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation