[Snappi] Modifications to pfcwd a2a test design for mlnx 4600c by developfast · Pull Request #7367 · sonic-net/sonic-mgmt

developfast · 2023-01-31T20:11:34Z

Description of PR

Summary: The Mellanox 4600c switch does not drop packets on the Rx port when a PFC storm is generated on a port, thereby triggering the PFC watch dog. The existing pfcwd a2a (all-to-all) test assumed that packets would be dropped on the Rx port, regardless of switch HwSKU. This change modifies how the test will verify the flow of packets for the Mellanox 4600c during a PFCWD all-to-all test.

Fixes # (issue)

Type of change

Bug fix
Testbed and Framework(new/improvement)
Test case(new/improvement)

Back port request

201911
202012
202205

Approach

What is the motivation for this PR?

Pfcwd a2a test failure on mellanox 4600c switch.

How did you do it?

Added a condition that checks for whether the switch is a mellanox 4600c switch, and have a check to ensure that no packets are dropped on the Rx port.

How did you verify/test it?

Ran the test on the mellanox 4600c - it passed.

Any platform specific information?

Platform - x86_64-mlnx_msn4600c-r0

Supported testbed topology if it's a new test case?

Documentation

developfast · 2023-01-31T20:12:38Z

@baiwei0427 please review

tests/snappi/pfcwd/files/pfcwd_multi_node_helper.py

neethajohn · 2023-02-03T17:52:36Z

tests/snappi/pfcwd/files/pfcwd_multi_node_helper.py

    speed_gbps = int(speed_str.split('_')[1])

+    """ Retrieve platform information for DUT """
+    platform = duthost.facts['platform']


please get the asic_type instead of platform. All mellanox devices have this behavior

neethajohn · 2023-02-03T17:53:37Z

@developfast, please modify all the other pfcwd snappi testcases as well for mellanox platform to exclude the rx drop check

developfast · 2023-02-09T18:06:17Z

@developfast, please modify all the other pfcwd snappi testcases as well for mellanox platform to exclude the rx drop check

only applies to this test - have verified with Wei

wangxin · 2023-02-21T19:08:15Z

The pre-commit check detected issues in the files touched by this pull request.
The detected issues may be old or new. For new issues, please try to fix them.

For old issues, it is not mandatory to fix them because they were not caused by this change. It is unfair to blame
author of this pull request. But if you can take extra effort to fix the old issues as well, that would be great!

Detailed pre-commit check results:
trim trailing whitespace.................................................Failed - hook id: trailing-whitespace - exit code: 1 - files were modified by this hook Fixing tests/snappi/pfcwd/files/pfcwd_multi_node_helper.py fix end of files.........................................................Passed check yaml...........................................(no files to check)Skipped check for added large files..............................................Passed check python ast.........................................................Passed flake8...................................................................Failed - hook id: flake8 - exit code: 1 tests/snappi/pfcwd/files/pfcwd_multi_node_helper.py:6:1: F401 'tests.common.fixtures.conn_graph_facts.conn_graph_facts' imported but unused tests/snappi/pfcwd/files/pfcwd_multi_node_helper.py:6:1: F401 'tests.common.fixtures.conn_graph_facts.fanout_graph_facts' imported but unused tests/snappi/pfcwd/files/pfcwd_multi_node_helper.py:91:64: E502 the backslash is redundant between brackets tests/snappi/pfcwd/files/pfcwd_multi_node_helper.py:92:52: E502 the backslash is redundant between brackets tests/snappi/pfcwd/files/pfcwd_multi_node_helper.py:95:60: E502 the backslash is redundant between brackets ... [truncated extra lines, please run pre-commit locally to view full check results]

To run the pre-commit checks locally, you can follow below steps:

Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
docker container.
Ensure that the pre-commit package is installed:

sudo pip install pre-commit

Go to repository root folder
Install the pre-commit hooks:

pre-commit install

Use pre-commit to check staged file:

pre-commit

Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

* changes to pfcwd a2a test for mlnx 4600c * changes to pfcwd a2a test for mlnx 4600c * modified test case to take in platform as parameter * changed from platform to asic_type

Signed-off-by: Austin Pham <austinpham@microsoft.com>

fix: migrate sonic-net#7370 to multidut code Signed-off-by: Austin Pham <austinpham@microsoft.com> fix: migrate sonic-net#9567 to multidut code Signed-off-by: Austin Pham <austinpham@microsoft.com> fix: migrate sonic-net#7367 to multidut code Signed-off-by: Austin Pham <austinpham@microsoft.com> fix: migrate sonic-net#7712 Signed-off-by: Austin Pham <austinpham@microsoft.com> fix: migrate sonic-net#7712 to pfcwd_multidut_runtime_traffic_helper Signed-off-by: Austin Pham <austinpham@microsoft.com> chore: update a2a parameterize Signed-off-by: Austin Pham <austinpham@microsoft.com>

Summary: Update the missing T0 T1 tests feature in multidut Fixes # (issue) 30929279 The following PR were migrated for pfcwd [Snappi] Increase number of calls for ARP wait #7370 [Snappi] PFCWD Tolerance Fixes #9567 [Snappi] Modifications to pfcwd a2a test design for mlnx 4600c #7367 to multidut code [Snappi] Modified pfcwd tests to add warm-up traffic #7712 Signed-off-by: Austin Pham <austinpham@microsoft.com>

Summary: Update the missing T0 T1 tests feature in multidut Fixes # (issue) 30929279 The following PR were migrated for pfcwd - sonic-net/sonic-mgmt#7370 - sonic-net/sonic-mgmt#9567 - sonic-net/sonic-mgmt#7367 to multidut code - sonic-net/sonic-mgmt#7712 ### Type of change  - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [ ] Test case improvement ### Back port request - [ ] 202012 - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 ### Approach #### What is the motivation for this PR? #### How did you do it? #### How did you verify/test it? #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation  snappi_tests/multidut/pfcwd/test_multidut_pfcwd_m2o_with_snappi.py ``` -- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html - generated xml file: /var/src/sonic-mgmt_vmsvc5-t2-8800-ixia_669de75fbbfea63e8b73b319/tests/logs/snappi_tests/multidut/pfcwd/test_multidut_pfcwd_m2o_with_snappi.xml - ================== 4 passed, 7 warnings in 1235.72s (0:20:35) ================== ``` snappi_tests/multidut/pfcwd/test_multidut_pfcwd_burst_storm_with_snappi.py ``` -- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html - generated xml file: /var/src/sonic-mgmt_vmsvc5-t2-8800-ixia_669de75fbbfea63e8b73b319/tests/logs/snappi_tests/multidut/pfcwd/test_multidut_pfcwd_burst_storm_with_snappi.xml - ================== 2 passed, 5 warnings in 858.60s (0:14:18) =================== ``` snappi_tests/multidut/pfcwd/test_multidut_pfcwd_basic_with_snappi.py (known failure on T2, fail as expected) ``` SKIPPED [4] snappi_tests/multidut/pfcwd/test_multidut_pfcwd_basic_with_snappi.py:190: Reboot type fast is not supported on cisco-8000 switches FAILED snappi_tests/multidut/pfcwd/test_multidut_pfcwd_basic_with_snappi.py::test_pfcwd_basic_multi_lossless_prio_restart_service[multidut_port_info0-True-swss] ===== 1 failed, 23 passed, 16 skipped, 27 warnings in 27779.49s (7:42:59) ====== ``` snappi_tests/multidut/pfcwd/test_multidut_pfcwd_a2a_with_snappi.py ``` -- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html - generated xml file: /var/src/sonic-mgmt_vmsvc5-t2-8800-ixia_669de75fbbfea63e8b73b319/tests/logs/snappi_tests/multidut/pfcwd/test_multidut_pfcwd_a2a_with_snappi.xml - ================== 4 passed, 7 warnings in 1157.40s (0:19:17) ================== ``` snappi_tests/multidut/pfcwd/test_multidut_pfcwd_runtime_traffic_with_snappi.py ``` -- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html - generated xml file: /var/src/sonic-mgmt_vmsvc5-t2-8800-ixia_669de75fbbfea63e8b73b319/tests/logs/snappi_tests/multidut/pfcwd/test_multidut_pfcwd_runtime_traffic_with_snappi.xml - ================== 2 passed, 6 warnings in 1162.35s (0:19:22) ================== ```

Summary: Update the missing T0 T1 tests feature in multidut Fixes # (issue) 30929279 The following PR were migrated for pfcwd [Snappi] Increase number of calls for ARP wait sonic-net#7370 [Snappi] PFCWD Tolerance Fixes sonic-net#9567 [Snappi] Modifications to pfcwd a2a test design for mlnx 4600c sonic-net#7367 to multidut code [Snappi] Modified pfcwd tests to add warm-up traffic sonic-net#7712 Signed-off-by: Austin Pham <austinpham@microsoft.com>

Summary: Update the missing T0 T1 tests feature in multidut Fixes # (issue) 30929279 The following PR were migrated for pfcwd [Snappi] Increase number of calls for ARP wait #7370 [Snappi] PFCWD Tolerance Fixes #9567 [Snappi] Modifications to pfcwd a2a test design for mlnx 4600c #7367 to multidut code [Snappi] Modified pfcwd tests to add warm-up traffic #7712 Signed-off-by: Austin Pham <austinpham@microsoft.com>

Summary: Update the missing T0 T1 tests feature in multidut Fixes # (issue) 30929279 The following PR were migrated for pfcwd [Snappi] Increase number of calls for ARP wait sonic-net#7370 [Snappi] PFCWD Tolerance Fixes sonic-net#9567 [Snappi] Modifications to pfcwd a2a test design for mlnx 4600c sonic-net#7367 to multidut code [Snappi] Modified pfcwd tests to add warm-up traffic sonic-net#7712 Signed-off-by: Austin Pham <austinpham@microsoft.com>

developfast added 2 commits January 31, 2023 20:00

changes to pfcwd a2a test for mlnx 4600c

8767fa3

changes to pfcwd a2a test for mlnx 4600c

7803701

baiwei0427 requested changes Jan 31, 2023

View reviewed changes

tests/snappi/pfcwd/files/pfcwd_multi_node_helper.py Outdated Show resolved Hide resolved

modified test case to take in platform as parameter

bd02d65

baiwei0427 previously approved these changes Feb 1, 2023

View reviewed changes

neethajohn reviewed Feb 3, 2023

View reviewed changes

changed from platform to asic_type

50dafbf

developfast dismissed baiwei0427’s stale review via 50dafbf February 21, 2023 18:20

developfast requested review from baiwei0427 and neethajohn February 21, 2023 19:19

baiwei0427 approved these changes Feb 21, 2023

View reviewed changes

developfast added Request for 202012 branch Request for 202205 branch labels Feb 24, 2023

neethajohn approved these changes Feb 24, 2023

View reviewed changes

developfast merged commit b64baf6 into sonic-net:master Feb 24, 2023

wangxin added the Included in 202012 branch label Feb 27, 2023

wangxin added the Included in 202205 branch label Feb 27, 2023

auspham added a commit to auspham/sonic-mgmt that referenced this pull request Jan 21, 2025

fix: migrate sonic-net#7367 to multidut code

de183ad

Signed-off-by: Austin Pham <austinpham@microsoft.com>

auspham mentioned this pull request Jan 24, 2025

[T0 T1 merge] update multidut pfcwd tests #16657

Merged

11 tasks

mssonicbld mentioned this pull request Jan 29, 2025

[action] [PR:16657] [T0 T1 merge] update multidut pfcwd tests Azure/sonic-mgmt.msft#29

Merged

11 tasks

mssonicbld mentioned this pull request Jan 29, 2025

[action] [PR:16657] [T0 T1 merge] update multidut pfcwd tests #16707

Merged

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Snappi] Modifications to pfcwd a2a test design for mlnx 4600c#7367

[Snappi] Modifications to pfcwd a2a test design for mlnx 4600c#7367
developfast merged 4 commits intosonic-net:masterfrom
developfast:dojha/mlnx_pfcwd_test_mod

developfast commented Jan 31, 2023

Uh oh!

developfast commented Jan 31, 2023

Uh oh!

Uh oh!

neethajohn Feb 3, 2023

Uh oh!

neethajohn commented Feb 3, 2023

Uh oh!

developfast commented Feb 9, 2023

Uh oh!

wangxin commented Feb 21, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

developfast commented Jan 31, 2023

Description of PR

Type of change

Back port request

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Uh oh!

developfast commented Jan 31, 2023

Uh oh!

Uh oh!

neethajohn Feb 3, 2023

Choose a reason for hiding this comment

Uh oh!

neethajohn commented Feb 3, 2023

Uh oh!

developfast commented Feb 9, 2023

Uh oh!

wangxin commented Feb 21, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants