Skip to content

Test merge a2a with snappi#16587

Closed
auspham wants to merge 1 commit intosonic-net:masterfrom
auspham:austinpham/30931168-test-merge-a2a-with-snappi
Closed

Test merge a2a with snappi#16587
auspham wants to merge 1 commit intosonic-net:masterfrom
auspham:austinpham/30931168-test-merge-a2a-with-snappi

Conversation

@auspham
Copy link
Contributor

@auspham auspham commented Jan 20, 2025

Description of PR

This PR merge the RDMA test for test_pfcwd_a2a_with_snappi.py

Summary: 30931168
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405
  • 202411

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@auspham
Copy link
Contributor Author

auspham commented Jan 20, 2025

@sdszhang please help reviewing

@auspham auspham requested a review from developfast January 20, 2025 05:36
@sdszhang
Copy link
Contributor

start_pfcwd, enable_packet_aging, get_pfcwd_poll_interval, get_pfcwd_detect_time, sec_to_nanosec
from tests.common.snappi_tests.port import select_ports
from tests.common.snappi_tests.snappi_helpers import wait_for_arp
from tests.common.fixtures.conn_graph_facts import conn_graph_facts, fanout_graph_facts # noqa: F401
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is shared by test_pfcwd_m2o_with_snappi.py. can we include it in this change too to avoid regression?


logger.info('Wait for Arp to Resolve ...')
wait_for_arp(api, max_attempts=30, poll_interval_sec=2)
wait_for_arp(api, max_attempts=10, poll_interval_sec=2)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like we are missing #7370 fix in multidut?


""" Retrieve ASIC information for DUT """
asic_type = duthost.facts['asic_type']
rx_tx_tol_thrhlds = [0.0001, 0.0002] # Maintain a 0.01% and 0.02% deviation between tx and rx frames
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like multidut missing #9567 fix.

@auspham auspham force-pushed the austinpham/30931168-test-merge-a2a-with-snappi branch from 02c84ba to 0e34fdb Compare January 20, 2025 23:12
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@auspham
Copy link
Contributor Author

auspham commented Jan 21, 2025

Close as discussed

@auspham auspham closed this Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants