Skip to content

[Snappi] Modifications to pfcwd a2a test design for mlnx 4600c #7367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
developfast merged 4 commits into from
Feb 24, 2023
Merged

[Snappi] Modifications to pfcwd a2a test design for mlnx 4600c #7367

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8767fa3
changes to pfcwd a2a test for mlnx 4600c
developfast Jan 31, 2023
7803701
changes to pfcwd a2a test for mlnx 4600c
developfast Jan 31, 2023
bd02d65
modified test case to take in platform as parameter
developfast Jan 31, 2023
50dafbf
changed from platform to asic_type
developfast Feb 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 19 additions & 4 deletions tests/snappi/pfcwd/files/pfcwd_multi_node_helper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,9 @@ def run_pfcwd_multi_node_test(api,
speed_str = testbed_config.layer1[0].speed
speed_gbps = int(speed_str.split('_')[1])

""" Retrieve ASIC information for DUT """
asic_type = duthost.facts['asic_type']

__verify_results(rows=flow_stats,
speed_gbps=speed_gbps,
pause_flow_name=PAUSE_FLOW_NAME,
Expand All @@ -136,7 +139,8 @@ def run_pfcwd_multi_node_test(api,
data_pkt_size=DATA_PKT_SIZE,
trigger_pfcwd=trigger_pfcwd,
pause_port_id=port_id,
tolerance=TOLERANCE_THRESHOLD)
tolerance=TOLERANCE_THRESHOLD,
asic_type=asic_type)


def __data_flow_name(name_prefix, src_id, dst_id, prio):
Expand Down Expand Up @@ -517,7 +521,8 @@ def __verify_results(rows,
data_pkt_size,
trigger_pfcwd,
pause_port_id,
tolerance):
tolerance,
asic_type):
"""
Verify if we get expected experiment results

Expand All @@ -534,10 +539,15 @@ def __verify_results(rows,
trigger_pfcwd (bool): if PFC watchdog is expected to be triggered
pause_port_id (int): ID of the port to send PFC pause frames
tolerance (float): maximum allowable deviation
asic_type (str): asic_type information for DUT

Returns:
N/A
"""

""" Check for whether DUT is a Mellanox device """
is_mlnx_device = True if "mellanox" in asic_type.lower() else False

for row in rows:
flow_name = row.name
tx_frames = row.frames_tx
Expand Down Expand Up @@ -568,11 +578,16 @@ def __verify_results(rows,
exp_test_flow_rx_pkts = test_flow_rate_percent / 100.0 * speed_gbps \
* 1e9 * data_flow_dur_sec / 8.0 / data_pkt_size

if trigger_pfcwd and\
(src_port_id == pause_port_id or dst_port_id == pause_port_id):
if trigger_pfcwd and dst_port_id == pause_port_id:
""" Once PFC watchdog is triggered, it will impact bi-directional traffic """
pytest_assert(tx_frames > rx_frames,
'{} should have dropped packets'.format(flow_name))

elif trigger_pfcwd and src_port_id == pause_port_id:
if is_mlnx_device:
""" During a pfc storm with pfcwd triggered, Mellanox devices do not drop Rx packets """
pytest_assert(tx_frames == rx_frames,
'{} should not have dropped packets for Mellanox device'.format(flow_name))

elif not trigger_pfcwd and dst_port_id == pause_port_id:
""" This test flow is delayed by PFC storm """
Expand Down