Add test case for trap flow counter feature#4456
Merged
wangxin merged 2 commits intosonic-net:masterfrom Nov 16, 2021
Merged
Conversation
Contributor
Author
|
@yxieca could you assign someone to review this? |
wangxin
reviewed
Nov 1, 2021
tests/copp/test_copp.py
Outdated
| trap_type = protocol.lower() | ||
|
|
||
| # wait until the trap counter is enabled | ||
| assert wait_until(10, 1, _check_trap_counter_enabled, duthost, trap_type), 'counter is not created for {}'.format(trap_type) |
Collaborator
There was a problem hiding this comment.
The wait_until interface has been changed in PR #4516. This function call needs to be updated.
Contributor
Author
There was a problem hiding this comment.
Will do a rebase.
Change-Id: I7f6b77dcb320fce1d9ea0be021486bb6b8e3ec87
Change-Id: I6e8491cf88330e141b5e0d8c809488c10a0be79f
Junchao-Mellanox
force-pushed
the
flow-counter
branch
from
18c2054 to
4a5e316
Compare
Contributor
Author
|
/azpw run |
2 similar comments
Contributor
Author
|
/azpw run |
Contributor
|
/azpw run |
Contributor
Author
|
Hi @wangxin , could you help trigger the build again? |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
Hi @wangxin - could you please approve the PR |
wangxin
approved these changes
Nov 16, 2021
wangxin
approved these changes
Nov 16, 2021
Contributor
|
@wangxin, this feature is not yet merged into master. sonic-net/SONiC#858 |
4 tasks
yejianquan
added a commit
that referenced
this pull request
Nov 19, 2021
Approach What is the motivation for this PR? Enable test_copp on t0, eliminate test gap #4588 How did you do it? Modify prepare logic to make it suitable to both t0 and t1 topologies. Install another required package. How did you verify/test it? Run it on physical testbeds, including: 3 t0 testbeds with different platforms 1 t1 testbed to make sure it doesn't influence existing testbed 1 t1 backend testbed All of them passed the test_policer and test_no_policer test functions, but the new test function test_counter brought by #4456 raised errors due to the command mismatch of the bin file, it should be the issue of the new test case so we can ignore it for now. Supported testbed topology if it's a new test case? t0, t0-64, t0-52, t0-116 Co-authored-by: Jianquan Ye <[email protected]>
neethajohn
added a commit
that referenced
this pull request
Nov 22, 2021
This reverts commit c630ea1.
neethajohn
added a commit
that referenced
this pull request
Nov 23, 2021
This reverts commit c630ea1 Reverts #4456 This feature has not yet been reviewed sonic-net/SONiC#858 Affecting nighty run results because of this new testcase without feature support
AntonHryshchuk
pushed a commit
to AntonHryshchuk/sonic-mgmt
that referenced
this pull request
Jan 4, 2022
What is the motivation for this PR? Add test case for trap flow counter feature. How did you do it? This new test case is verifying the packet send number and packet rate. Test flow is like: * Enable and clear trap flow counter * Send packets via ptf * Verify the send number equals to the counter value, and the send rate is close to counter value How did you verify/test it? Manually run the test Any platform specific information? Any platform that support trap flow counter
AntonHryshchuk
pushed a commit
to AntonHryshchuk/sonic-mgmt
that referenced
this pull request
Jan 4, 2022
Approach What is the motivation for this PR? Enable test_copp on t0, eliminate test gap sonic-net#4588 How did you do it? Modify prepare logic to make it suitable to both t0 and t1 topologies. Install another required package. How did you verify/test it? Run it on physical testbeds, including: 3 t0 testbeds with different platforms 1 t1 testbed to make sure it doesn't influence existing testbed 1 t1 backend testbed All of them passed the test_policer and test_no_policer test functions, but the new test function test_counter brought by sonic-net#4456 raised errors due to the command mismatch of the bin file, it should be the issue of the new test case so we can ignore it for now. Supported testbed topology if it's a new test case? t0, t0-64, t0-52, t0-116 Co-authored-by: Jianquan Ye <[email protected]>
AntonHryshchuk
pushed a commit
to AntonHryshchuk/sonic-mgmt
that referenced
this pull request
Jan 4, 2022
…sonic-net#4747) This reverts commit c630ea1 Reverts sonic-net#4456 This feature has not yet been reviewed sonic-net/SONiC#858 Affecting nighty run results because of this new testcase without feature support
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change-Id: I7f6b77dcb320fce1d9ea0be021486bb6b8e3ec87
Description of PR
Summary:
Add test case for trap flow counter feature
Type of change
Back port request
Approach
What is the motivation for this PR?
Add test case for trap flow counter feature.
How did you do it?
This new test case is verifying the packet send number and packet rate. Test flow is like:
How did you verify/test it?
Manually run the test
Any platform specific information?
Any platform that support trap flow coutner
Supported testbed topology if it's a new test case?
ptf32/ptf64
Documentation