[test_gap] enable test copp on t0#4723
Merged
yejianquan merged 1 commit intosonic-net:masterfrom Nov 19, 2021
Merged
Conversation
yxieca
approved these changes
Nov 18, 2021
AntonHryshchuk
pushed a commit
to AntonHryshchuk/sonic-mgmt
that referenced
this pull request
Jan 4, 2022
Approach What is the motivation for this PR? Enable test_copp on t0, eliminate test gap sonic-net#4588 How did you do it? Modify prepare logic to make it suitable to both t0 and t1 topologies. Install another required package. How did you verify/test it? Run it on physical testbeds, including: 3 t0 testbeds with different platforms 1 t1 testbed to make sure it doesn't influence existing testbed 1 t1 backend testbed All of them passed the test_policer and test_no_policer test functions, but the new test function test_counter brought by sonic-net#4456 raised errors due to the command mismatch of the bin file, it should be the issue of the new test case so we can ignore it for now. Supported testbed topology if it's a new test case? t0, t0-64, t0-52, t0-116 Co-authored-by: Jianquan Ye <jianquanye@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Enable test_copp on t0, eliminate test gap #4588
Type of change
Back port request
Approach
What is the motivation for this PR?
Enable test_copp on t0, eliminate test gap #4588
How did you do it?
How did you verify/test it?
Run it on physical testbeds, including:
All of them passed the test_policer and test_no_policer test functions,
but the new test function test_counter brought by #4456 raised errors due to the command mismatch of the bin file, it should be the issue of the new test case so we can ignore it for now.
Any platform specific information?
Supported testbed topology if it's a new test case?
t0, t0-64, t0-52, t0-116
Documentation