Improves wait_until to support initial delay before periodic check and wait#4516
Merged
diaryevil merged 4 commits intosonic-net:masterfrom Oct 22, 2021
Merged
Improves wait_until to support initial delay before periodic check and wait#4516diaryevil merged 4 commits intosonic-net:masterfrom
diaryevil merged 4 commits intosonic-net:masterfrom
Conversation
lolyu
reviewed
Oct 20, 2021
wangxin
changed the title
lolyu
approved these changes
Oct 21, 2021
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yuxuan Ye [email protected]
Description of PR
Improves function
wait_until, allow to set a delay for environment preparingType of change
Back port request
Approach
What is the motivation for this PR?
Improves function
wait_until, allow to set a delay for environment preparingHow did you do it?
Add a parameter
delayfor functionwait_until, if it is set greater than 0, it will delay for the set time.How did you verify/test it?
On vs, find a test case contains
wait_until(I use test_bgpmom) and test whether it worksAny platform specific information?
No
Supported testbed topology if it's a new test case?
Documentation