collect_dut_info to check if we have front-end and/or back-end asics#4070
Merged
yxieca merged 2 commits intosonic-net:masterfrom Oct 22, 2021
Merged
collect_dut_info to check if we have front-end and/or back-end asics#4070yxieca merged 2 commits intosonic-net:masterfrom
yxieca merged 2 commits intosonic-net:masterfrom
Conversation
sanmalho-git
force-pushed
the
collect_dut_info
branch
from
3e43020 to
0363ccc
Compare
Contributor
|
There are lot of places where "is_multi_asic" is used. There could be other issues popping up. Have you explored adding a new sonichost type? |
Contributor
Author
|
@smaheshm MultiAsicSonicHost in tests/common/devices/multi_asic.py is the class that represents a SonicHost with multiple asics - this has a list of asics in the SonicHost. Even a single asic box is an instance of MultiAsicSonicHost with a single asic. This class allows for seemless compatibility between single and multi-asic DUTs with minimal changes to be made to make a test be able to run on both DUT types. |
3 tasks
Contributor
|
@sanmalho-git, can you fix the conflicts ? |
sanmalho-git
force-pushed
the
collect_dut_info
branch
from
0363ccc to
cb50f91
Compare
Contributor
Author
|
@arlakshm - Fixed the conflicts |
Contributor
|
/Azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
arlakshm
approved these changes
Oct 15, 2021
Contributor
|
Waiting for LGTM analysis to finish... |
yxieca
approved these changes
Oct 20, 2021
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
PR# 3696 added container names in meta data file for frontend and backend ASIC on which autorestart test will be performed for multi-asic platform. This assumes that on a multi-asic platform, there are always front-end and back-end asics. However, on a VoQ chassis - linecards don't have back-end asics. - supervisor card has niether front-end nor back-end asics So, need to check if we have front-end or back-end asics before trying to add them to asic_services.
sanmalho-git
force-pushed
the
collect_dut_info
branch
from
91c244b to
fb0236d
Compare
Contributor
Author
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
- What I did Ported a fix from libteam master to our master. Fixes sonic-net#4070 Fixes sonic-net#3649 - How I did it Applied patch jpirko/libteam@c723737 from upstream. - How to verify it Build image for your DUT and warm-reboot your DUT 10 times. Check that all PortChannels are up and no error messages in teamd.log
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…lly (#24970) #### Why I did it src/sonic-swss ``` * 3c6ec95c - (HEAD -> 202511, origin/202511) [portsorch] fix crash when number of PGs returned 0 (sonic-net#4106) (29 hours ago) [mssonicbld] * f4c0865a - [orchagent] support single ASIC VOQ Fixed-System (sonic-net#4105) (30 hours ago) [mssonicbld] * 2a8deda1 - Change DB that DPU orchagents listens to for all orchs (sonic-net#4070) (2 days ago) [mssonicbld] * 15e017e8 - [ssw][ha] add ACTION_COUNTER to acl table type (sonic-net#4078) (2 days ago) [mssonicbld] ``` #### How I did it #### How to verify it #### Description for the changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
PR #3696 added container names in meta data file for frontend and backend ASIC on which autorestart test will be performed for multi-asic platform. This assumes that on a multi-asic platform, there are always front-end and back-end asics.
However, on a VoQ chassis
So, need to check if we have front-end or back-end asics before trying to add them to asic_services.
How did you do it?
If we have front-end or back-end asics, (len != 0), only then pick up randomly and add it to asic_services.
How did you verify/test it?
Tested on multi-asic linecard and supervisor card in a VoQ chassis.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation