Replace 'urllib2' with 'requests' for making HTTP requests#4105
Merged
wangxin merged 2 commits intosonic-net:masterfrom Aug 26, 2021
Merged
Replace 'urllib2' with 'requests' for making HTTP requests#4105wangxin merged 2 commits intosonic-net:masterfrom
wangxin merged 2 commits intosonic-net:masterfrom
Conversation
The mux_simulator_control.py script uses 'urllib2' for making HTTP requests. This is not compatible between python2 and python3. This change replaced 'urllib2' with 'requests'. Signed-off-by: Xin Wang <[email protected]>
lolyu
approved these changes
Aug 26, 2021
vmittal-msft
pushed a commit
to vmittal-msft/sonic-mgmt
that referenced
this pull request
Sep 28, 2021
…#4105) What is the motivation for this PR? The mux_simulator_control.py script uses 'urllib2' for making HTTP requests. This is incompatible between python2 and python3. How did you do it? This change replaced 'urllib2' with 'requests'. How did you verify/test it? Test run decap/test_decap.py on dualtor testbed with sanity check enabled. Signed-off-by: Xin Wang <[email protected]>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…lly (#24970) #### Why I did it src/sonic-swss ``` * 3c6ec95c - (HEAD -> 202511, origin/202511) [portsorch] fix crash when number of PGs returned 0 (sonic-net#4106) (29 hours ago) [mssonicbld] * f4c0865a - [orchagent] support single ASIC VOQ Fixed-System (sonic-net#4105) (30 hours ago) [mssonicbld] * 2a8deda1 - Change DB that DPU orchagents listens to for all orchs (sonic-net#4070) (2 days ago) [mssonicbld] * 15e017e8 - [ssw][ha] add ACTION_COUNTER to acl table type (sonic-net#4078) (2 days ago) [mssonicbld] ``` #### How I did it #### How to verify it #### Description for the changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
The mux_simulator_control.py script uses 'urllib2' for making HTTP requests.
This is incompatible between python2 and python3.
How did you do it?
This change replaced 'urllib2' with 'requests'.
How did you verify/test it?
Test run decap/test_decap.py on dualtor testbed with sanity check enabled.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation