[chassis] get frontend or backend asic only when present in metadata#4442
Closed
arlakshm wants to merge 2 commits intosonic-net:masterfrom
Closed
[chassis] get frontend or backend asic only when present in metadata#4442arlakshm wants to merge 2 commits intosonic-net:masterfrom
arlakshm wants to merge 2 commits intosonic-net:masterfrom
Conversation
Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>
Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>
arlakshm
changed the title
smaheshm
approved these changes
Oct 8, 2021
Contributor
Contributor
Author
|
The change present is #4070. Closing this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes #4441
closes #4441
Type of change
Back port request
Approach
What is the motivation for this PR?
In chassis, the
test_update_testbed_metadatafails in the functioncollect_dut_info.This is because, the current assumption is a multi asic device will have frontend and backend asic.
In case of the chassis that may not be true. The supervisor will have only backend or fabric asic and linecard will have only frontend asics. The PR address this issue
How did you do it?
Add check to get the asic_services of frontend and/or backend asic only when they are present on the DUT
How did you verify/test it?
run
test_pretest.pyAny platform specific information?
None
Supported testbed topology if it's a new test case?
Documentation