[test_ro_user] Add a delay for 'test_ro_user_banned_command' after recent change#3741
Merged
liat-grozovik merged 1 commit intosonic-net:masterfrom Jul 8, 2021
shlomibitton:shlomi_add_delay_ro_user
Merged
[test_ro_user] Add a delay for 'test_ro_user_banned_command' after recent change#3741liat-grozovik merged 1 commit intosonic-net:masterfrom shlomibitton:shlomi_add_delay_ro_user
liat-grozovik merged 1 commit intosonic-net:masterfrom
shlomibitton:shlomi_add_delay_ro_user
Conversation
…allow 'hostcfgd' to start and configure tacas authorization. PR: sonic-net/sonic-buildimage#7965 Change-Id: Ie8b4a9129c2a0a6a417b9922bc26c2d5f9a40352 Signed-off-by: Shlomi Bitton <[email protected]>
wangxin
approved these changes
Jul 7, 2021
| ] | ||
|
|
||
| # Wait until hostcfgd started and configured tacas authorization | ||
| time.sleep(100) |
Collaborator
There was a problem hiding this comment.
should we check that tacas configuration is done before moving a head?
maybe it can be resolved much less than 100seconds?
Collaborator
There was a problem hiding this comment.
Checked the code in sonic-buildimage, the wait time is hard coded to 90 seconds. So, the 100 seconds waiting here makes sense.
5 tasks
liat-grozovik
approved these changes
Jul 8, 2021
4 tasks
vmittal-msft
pushed a commit
to vmittal-msft/sonic-mgmt
that referenced
this pull request
Sep 28, 2021
…allow 'hostcfgd' to start and configure tacas authorization. (sonic-net#3741) - What is the motivation for this PR? After recent change introduced on this PR's: sonic-net/sonic-buildimage#7965 and sonic-net/sonic-buildimage#8117 'hostcfgd' will be delayed in 90 seconds. If the test will run before the daemon has started, it will fail the test. This is to align with the new change and make sure the test will pass. - How did you do it? Add a delay of 100 seconds before executing authorized commands. - How did you verify/test it? Run the test. Signed-off-by: Shlomi Bitton <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
After recent change introduced on this PR's:
sonic-net/sonic-buildimage#7965
sonic-net/sonic-buildimage#8117
'hostcfgd' will be delayed in 90 seconds.
If the test will run before the daemon has started, it will fail the test.
This is to align with the new change and make sure the test will pass.
How did you do it?
Add a delay of 100 seconds before executing authorized commands.
How did you verify/test it?
Run the test.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation