Skip to content

[test_ro_user] Add a delay for 'test_ro_user_banned_command' after recent change #3741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
liat-grozovik merged 1 commit into from
Jul 8, 2021
Merged

[test_ro_user] Add a delay for 'test_ro_user_banned_command' after recent change #3741

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions tests/tacacs/test_ro_user.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import pytest
import time
from tests.common.helpers.assertions import pytest_assert

pytestmark = [
Expand Down Expand Up @@ -151,6 +152,8 @@ def test_ro_user_banned_command(localhost, duthosts, enum_rand_one_per_hwsku_hos
'sudo config'
]

# Wait until hostcfgd started and configured tacas authorization
time.sleep(100)
Copy link
Collaborator

@liat-grozovik liat-grozovik Jul 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we check that tacas configuration is done before moving a head?
maybe it can be resolved much less than 100seconds?

Copy link
Collaborator

@wangxin wangxin Jul 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the code in sonic-buildimage, the wait time is hard coded to 90 seconds. So, the 100 seconds waiting here makes sense.

for command in commands:
banned = ssh_remote_ban_run(localhost, dutip, creds_all_duts[duthost]['tacacs_ro_user'],
creds_all_duts[duthost]['tacacs_ro_user_passwd'], command)
Expand Down