[test_ro_user] improve the delay for 'test_ro_user_banned_command' due to hostcfgd delay on boot#3775
Merged
lguohan merged 2 commits intosonic-net:masterfrom Jul 24, 2021
shlomibitton:shlomi_add_delay_ro_user
Merged
[test_ro_user] improve the delay for 'test_ro_user_banned_command' due to hostcfgd delay on boot#3775lguohan merged 2 commits intosonic-net:masterfrom shlomibitton:shlomi_add_delay_ro_user
lguohan merged 2 commits intosonic-net:masterfrom
shlomibitton:shlomi_add_delay_ro_user
Conversation
Contributor
Author
|
@wangxin Can you please check this PR? this one improves #3741 because the CI is still failing, it looks like even after the daemon started the tacacs is not configured and the test is failing. |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…allow 'hostcfgd' to start and configure tacas authorization. PR: sonic-net/sonic-buildimage#7965 Change-Id: Ie8b4a9129c2a0a6a417b9922bc26c2d5f9a40352 Signed-off-by: Shlomi Bitton <shlomibi@nvidia.com>
liat-grozovik
approved these changes
Jul 15, 2021
Collaborator
|
@wangxin can you please review recent changes? once it is merged i can trigger other PRs which are pending on it. |
liat-grozovik
changed the title
qiluo-msft
reviewed
Jul 18, 2021
wangxin
reviewed
Jul 19, 2021
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
lguohan
approved these changes
Jul 24, 2021
vmittal-msft
pushed a commit
to vmittal-msft/sonic-mgmt
that referenced
this pull request
Sep 28, 2021
…e to hostcfgd delay on boot (sonic-net#3775) What is the motivation for this PR? After recent change introduced on this PR's: sonic-net/sonic-buildimage#7965 sonic-net/sonic-buildimage#8117 'hostcfgd' will be delayed in 90 seconds. If the test will run before the daemon has started, it will fail the test. This is to align with the new change and make sure the test will pass. Profiling the time it takes to configure tacacs after the daemon started can take time: main started -> Mon 12 Jul 2021 02:07:06 PM UTC 'tacacs_server_update' function finished -> Mon 12 Jul 2021 02:08:10 PM UTC Signed-off-by: Shlomi Bitton <shlomibi@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
After recent change introduced on this PR's:
sonic-net/sonic-buildimage#7965
sonic-net/sonic-buildimage#8117
'hostcfgd' will be delayed in 90 seconds.
If the test will run before the daemon has started, it will fail the test.
This is to align with the new change and make sure the test will pass.
Profiling the time it takes to configure tacacs after the daemon started can take time:
main started -> Mon 12 Jul 2021 02:07:06 PM UTC
'tacacs_server_update' function finished -> Mon 12 Jul 2021 02:08:10 PM UTC
This PR is to improve the previous delay introduced on PR #3741
Since the test is still failing on Azure CI.
How did you do it?
Check hostcfgd status and if the daemon started wait until tacacs is well configured.
How did you verify/test it?
Run the test.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation