[garp_service]: Only send GARPs once at startup#3053
Closed
theasianpianist wants to merge 1 commit intosonic-net:masterfrom
Closed
[garp_service]: Only send GARPs once at startup#3053theasianpianist wants to merge 1 commit intosonic-net:masterfrom
theasianpianist wants to merge 1 commit intosonic-net:masterfrom
Conversation
Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
Collaborator
|
We need to clear neigh on standby tor for some test cases, how can we restore it if garp is only sent one round? |
Contributor
Author
|
@bingwang-ms that is a good point. What if we changed this to a function level fixture? We could guarantee that the neighbors are learnt at the start of each test case. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lawrence Lee lawlee@microsoft.com
MUST wait to merge until sonic-net/sonic-buildimage#6912 and sonic-net/sonic-utilities#1465 are merged and have been propagated into the internal 202012 image.
Description of PR
Summary:
Fixes # (issue)
Type of change
Approach
What is the motivation for this PR?
Soon (after the linked PRs above are merged and in the internal image) constantly sending GARP requests will be unnecessary since the ARP table on the standby ToR will be restored after config reload.
How did you do it?
Remove the
--intervalargument when startinggarp_serviceto make it a oneshot service.How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation