[config reload]: On dual ToR systems, cache ARP and FDB tables#1465
Merged
theasianpianist merged 1 commit intosonic-net:masterfrom Mar 4, 2021
Merged
Conversation
Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
theasianpianist
requested review from
jleveque,
lguohan,
prsunny and
tahmed-dev
prsunny
reviewed
Feb 25, 2021
|
|
||
| # If we are able to successfully cache ARP table info, signal SWSS to restore from our cache | ||
| # by creating /host/config-reload/needs-restore | ||
| if success: |
Contributor
There was a problem hiding this comment.
is this required? in a similar way, swss can check if the (arp.json and fdb.json) file exists and restore, correct?
Contributor
Author
There was a problem hiding this comment.
SWSS checks for file existence, but also checks /proc/cmdline to make sure fast-reboot actually occurred. I wanted to have a similar check for config reload for redundancy.
This was referenced Feb 26, 2021
tahmed-dev
approved these changes
Mar 1, 2021
Contributor
tahmed-dev
left a comment
tahmed-dev
left a comment
There was a problem hiding this comment.
LGTM! minor question.
yxieca
pushed a commit
that referenced
this pull request
Mar 4, 2021
Use the fast-reboot-dump and filter_fdb_entries scripts to cache the current ARP and FDB tables in /host/config-reload. Also create a file in the same directory to indicate to SWSS that it should restore from the cache. Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
This was referenced Apr 27, 2022
vaibhavhd
added a commit
that referenced
this pull request
Apr 29, 2022
Fix the path to config_db.json in config-reload for dual-tor device. Presently, there exists a typo in config_db.json filename that is sent as an argument to filter_fdb_entries. This causes failure during config reload. Related PR: #1465
theasianpianist
added a commit
to theasianpianist/sonic-utilities
that referenced
this pull request
Oct 27, 2022
sonic-net#1465)" This reverts commit 10de91d. Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
theasianpianist
added a commit
to theasianpianist/sonic-utilities
that referenced
this pull request
Oct 27, 2022
sonic-net#1465)" This reverts commit 10de91d. Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
theasianpianist
added a commit
to theasianpianist/sonic-utilities
that referenced
this pull request
Oct 27, 2022
sonic-net#1465)" This reverts commit 10de91d. Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
theasianpianist
added a commit
to theasianpianist/sonic-utilities
that referenced
this pull request
Oct 27, 2022
sonic-net#1465)" This reverts commit 10de91d. Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
theasianpianist
added a commit
that referenced
this pull request
Oct 27, 2022
theasianpianist
added a commit
that referenced
this pull request
Oct 28, 2022
theasianpianist
added a commit
to theasianpianist/sonic-utilities
that referenced
this pull request
Nov 10, 2022
sonic-net#2460) …s (sonic-net#1465)" - This reverts commit 10de91d. - Also removes '--disable-arp-cache' option from config reload tests that was added in sonic-net#2325 Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
preetham-singh
pushed a commit
to preetham-singh/sonic-utilities
that referenced
this pull request
Nov 21, 2022
sonic-net#2460) …s (sonic-net#1465)" - This reverts commit 10de91d. - Also removes '--disable-arp-cache' option from config reload tests that was added in sonic-net#2325 Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
theasianpianist
added a commit
that referenced
this pull request
Dec 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lawrence Lee lawlee@microsoft.com
What I did
On dual ToR systems, before performing
config reloadcache the ARP and FDB tables (similar to fast reboot) so that the standby ToR is able to resume normal operation afterwards.Note: will require a separate change in sonic-buildimage for the
docker_image_ctl.j2file for the SWSS containerHow I did it
Add an optional flag to disable caching behavior (enabled by default for dual ToR systems, disabled for all others).
Use the
fast-reboot-dumpandfilter_fdb_entriesscripts to cache the current ARP and FDB tables in/host/config-reload. Also create a file in the same directory to indicate to SWSS that it should restore from the cache.How to verify it
config reload -don a dual ToR system. Confirm that no cache is created in/host/config-reload.config reloadon a dual ToR system. Confirm a cache IS created in/host/config-reload. There should be anarp.json,fdb.json, anddefault_routes.json(this one will be unused)config reloadandconfig reload -don a dual ToR system. Confirm that no cache is created in/host/config-reload.Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)