Fix interface_check failure in test_cont_warm_reboot#2932
Merged
vaibhavhd merged 2 commits intosonic-net:masterfrom Feb 5, 2021
Merged
Fix interface_check failure in test_cont_warm_reboot#2932vaibhavhd merged 2 commits intosonic-net:masterfrom
vaibhavhd merged 2 commits intosonic-net:masterfrom
Conversation
neethajohn
approved these changes
Feb 4, 2021
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…lly (sonic-net#17094) src/sonic-swss * 01bf3b19 - (HEAD -> 202205, origin/202205) [muxorch] Fixing updateRoute logic (sonic-net#2950) (5 hours ago) [Nikola Dancejic] * 1e264e01 - Handle Mac address 'none' (sonic-net#2593) (9 hours ago) [Prince Sunny] * dc0e29b4 - [202205][teamd]: Clean teamd process if LAG creation fails (sonic-net#2888) (sonic-net#2932) (4 days ago) [Lawrence Lee]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: Fix
test_cont_warm_rebootthat has started failing after the recent restructuring done in https://github.com/Azure/sonic-mgmt/pull/2883/files#Fixes # (issue)
Type of change
Approach
test_cont_warm_rebootis failing with:This error is due to recent refactoring which made
check_interfacesa fixture (previously a method).What is the motivation for this PR?
How did you do it?
Added changes to access fixture on demand, and perform the interface status validation.
How did you verify/test it?
Tested on a KVM switch and the test passed. With interface made manually down, following error is gracefully generated avoiding a test crash:
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation