Skip to content

Fix interface_check failure in test_cont_warm_reboot #2932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vaibhavhd merged 2 commits into from
Feb 5, 2021
Merged

Fix interface_check failure in test_cont_warm_reboot #2932

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd7adb5
Fix continuous_warm_reboot interface_check failure
vaibhavhd Feb 4, 2021
7f62655
Fix continuous_warm_reboot interface_check failure
vaibhavhd Feb 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions tests/platform_tests/test_cont_warm_reboot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
from tests.common.helpers.assertions import pytest_assert
from tests.common.reboot import get_reboot_cause
from tests.common.platform.transceiver_utils import parse_transceiver_info
from tests.common.plugins.sanity_check import checks
from tests.common.fixtures.advanced_reboot import AdvancedReboot

from tests.common.fixtures.ptfhost_utils import copy_ptftests_directory # lgtm[py/unused-import]
Expand Down Expand Up @@ -156,9 +155,11 @@ def check_interfaces_and_transceivers(self):
@param interfaces: DUT's interfaces defined by minigraph
"""
logging.info("Check if all the interfaces are operational")
result = checks.check_interfaces(self.duthost)
if result["failed"]:
raise ContinuousRebootError("Interface check failed, not all interfaces are up")
check_interfaces = self.request.getfixturevalue("check_interfaces")
results = check_interfaces()
failed = [result for result in results if "failed" in result and result["failed"]]
if failed:
raise ContinuousRebootError("Interface check failed, not all interfaces are up. Failed: {}".format(failed))

# Skip this step for virtual testbed - KVM testbed has transeivers marked as "Not present"
# and the DB returns an "empty array" for "keys TRANSCEIVER_INFO*"
Expand Down