Fix system_health: accept similar fault LED colors using color groups#23344
Open
mkim-upscaleai wants to merge 1 commit intosonic-net:masterfrom
Open
Fix system_health: accept similar fault LED colors using color groups#23344mkim-upscaleai wants to merge 1 commit intosonic-net:masterfrom
mkim-upscaleai wants to merge 1 commit intosonic-net:masterfrom
Conversation
Some platforms (Mellanox) configure 'orange' as the fault LED color but the platform api reports 'red' on read (e.g. via _get_primary_color()). The previous exact match caused false failures on those platforms. Introduce FAULT_COLOR_GROUPS to treat similar colors (red/orange/amber) as equivalent fault indicators. Also fix a latent UnboundLocalError when the LED line is absent from CLI output. Signed-off-by: Matthew Kim <[email protected]>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
github-actions
bot
requested review from
Junchao-Mellanox,
anamehra and
xwjiang-ms
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Some platforms (Mellanox) configure 'orange' as the fault LED color but the platform api reports 'red' on read (e.g. via _get_primary_color()). The previous exact match caused false failures on those platforms.
Original PR for the test: #20716
PR that introduced the bug we are fixing: #22675
Fixes #23055:
Type of change
Back port request
Approach
What is the motivation for this PR?
Bug #23055 filed -
Bug: inconsistent system status LED color on mlnx sn2700How did you do it?
Introduce FAULT_COLOR_GROUPS to treat similar colors (red/orange/amber) as equivalent fault indicators. Also fix a latent UnboundLocalError when the LED line is absent from CLI output.
How did you verify/test it?
Ran on 202511 sonic-mgmt T0 topology.
Any platform specific information?
Issue is seen on Mellanox, but test case updates should not effect other platforms.
Supported testbed topology if it's a new test case?
Documentation