Skip to content

Update test_system_health case#20716

Merged
roy-sror merged 1 commit intosonic-net:masterfrom
JibinBao:sys_led
Oct 28, 2025
Merged

Update test_system_health case#20716
roy-sror merged 1 commit intosonic-net:masterfrom
JibinBao:sys_led

Conversation

@JibinBao
Copy link
Contributor

@JibinBao JibinBao commented Sep 18, 2025

Description of PR

  1. Add a checker for system led status
  2. Skip some case when device doesn't have fan and psu

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202205
  • 202305
  • 202311
  • 202405
  • 202411
  • 202505

Approach

What is the motivation for this PR?

  1. Add a checker for system led status
  2. Skip some case when device doesn't have fan and psu

How did you do it?

  1. Add a checker for system led status
  2. Skip some case when device doesn't have fan and psu

How did you verify/test it?

Run the test_system_health case

Any platform specific information?

Any

Supported testbed topology if it's a new test case?

Documentation

@JibinBao JibinBao requested a review from prgeor as a code owner September 18, 2025 03:36
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JibinBao JibinBao changed the title Add checker for system led status Update test_system_health case Sep 18, 2025
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@roy-sror roy-sror merged commit 232c895 into sonic-net:master Oct 28, 2025
19 checks passed
@judyjoseph
Copy link
Contributor

@roy-sror there is a regression to due to this change : #21183

Please could you fix/ or revert this change

@roy-sror
Copy link
Contributor

roy-sror commented Nov 5, 2025

@JibinBao - pls address

@JibinBao
Copy link
Contributor Author

JibinBao commented Nov 6, 2025

will handle it

@JibinBao
Copy link
Contributor Author

@JibinBao - pls address

Done: #21216

dcaugher pushed a commit to dcaugher/sonic-mgmt that referenced this pull request Nov 12, 2025
Add a checker for system led status
Skip some case when device doesn't have fan and psu
dcaugher pushed a commit to dcaugher/sonic-mgmt that referenced this pull request Nov 12, 2025
Add a checker for system led status
Skip some case when device doesn't have fan and psu
vikumarks pushed a commit to vikumarks/sonic-mgmt that referenced this pull request Dec 1, 2025
Add a checker for system led status
Skip some case when device doesn't have fan and psu

Signed-off-by: vikumarks <[email protected]>
albertovillarreal-keys pushed a commit to albertovillarreal-keys/sonic-mgmt that referenced this pull request Dec 2, 2025
Add a checker for system led status
Skip some case when device doesn't have fan and psu

Signed-off-by: Alberto Villarreal <[email protected]>
opcoder0 pushed a commit to opcoder0/sonic-mgmt that referenced this pull request Dec 8, 2025
Add a checker for system led status
Skip some case when device doesn't have fan and psu

Signed-off-by: opcoder0 <[email protected]>
selldinesh pushed a commit to selldinesh/sonic-mgmt that referenced this pull request Dec 11, 2025
Add a checker for system led status
Skip some case when device doesn't have fan and psu

Signed-off-by: selldinesh <[email protected]>
echuawu pushed a commit to echuawu/sonic-mgmt that referenced this pull request Dec 12, 2025
Add a checker for system led status
Skip some case when device doesn't have fan and psu
saravanan-nexthop pushed a commit to saravanan-nexthop/sonic-mgmt that referenced this pull request Dec 15, 2025
Add a checker for system led status
Skip some case when device doesn't have fan and psu

Signed-off-by: Saravanan <[email protected]>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 16, 2025
Add a checker for system led status
Skip some case when device doesn't have fan and psu

Signed-off-by: Guy Shemesh <[email protected]>
AharonMalkin pushed a commit to AharonMalkin/sonic-mgmt that referenced this pull request Dec 16, 2025
Add a checker for system led status
Skip some case when device doesn't have fan and psu

Signed-off-by: Aharon Malkin <[email protected]>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 21, 2025
Add a checker for system led status
Skip some case when device doesn't have fan and psu

Signed-off-by: Guy Shemesh <[email protected]>
venu-nexthop pushed a commit to venu-nexthop/sonic-mgmt that referenced this pull request Jan 13, 2026
Add a checker for system led status
Skip some case when device doesn't have fan and psu
yifan-nexthop pushed a commit to nexthop-ai/sonic-mgmt that referenced this pull request Jan 14, 2026
Add a checker for system led status
Skip some case when device doesn't have fan and psu

Signed-off-by: YiFan Wang <[email protected]>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Jan 26, 2026
Add a checker for system led status
Skip some case when device doesn't have fan and psu

Signed-off-by: Guy Shemesh <[email protected]>
lakshmi-nexthop pushed a commit to lakshmi-nexthop/sonic-mgmt that referenced this pull request Jan 28, 2026
Add a checker for system led status
Skip some case when device doesn't have fan and psu

Signed-off-by: Lakshmi Yarramaneni <[email protected]>
ytzur1 pushed a commit to ytzur1/sonic-mgmt that referenced this pull request Jan 29, 2026
Add a checker for system led status
Skip some case when device doesn't have fan and psu
ytzur1 pushed a commit to ytzur1/sonic-mgmt that referenced this pull request Feb 2, 2026
Add a checker for system led status
Skip some case when device doesn't have fan and psu

Signed-off-by: Yael Tzur <[email protected]>
abhishek-nexthop pushed a commit to nexthop-ai/sonic-mgmt that referenced this pull request Feb 6, 2026
Add a checker for system led status
Skip some case when device doesn't have fan and psu
rraghav-cisco pushed a commit to rraghav-cisco/sonic-mgmt that referenced this pull request Feb 13, 2026
Add a checker for system led status
Skip some case when device doesn't have fan and psu

Signed-off-by: Raghavendran Ramanathan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants