fix for led color in test_system_health.py#22675
Merged
StormLiangMS merged 2 commits intosonic-net:masterfrom Mar 4, 2026
Merged
fix for led color in test_system_health.py#22675StormLiangMS merged 2 commits intosonic-net:masterfrom
StormLiangMS merged 2 commits intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run |
github-actions
bot
requested review from
Junchao-Mellanox,
anamehra and
xwjiang-ms
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
Hi @donlope-cisco , please soign CLA and fix DCO error. |
anamehra
reviewed
Feb 28, 2026
anamehra
reviewed
Feb 28, 2026
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Don Lopez <[email protected]>
Signed-off-by: Don Lopez <[email protected]>
donlope-cisco
force-pushed
the
31509_code
branch
from
330b116 to
bb4dc56
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
wsycqyz
added
the
Request for 202511 branch
anamehra
approved these changes
Mar 3, 2026
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
What is the motivation for this PR? The assert in this function was triggering when run on simulators and HW devices How did you do it? How did you verify/test it? Verified with SIM Signed-off-by: Don Lopez <[email protected]> Signed-off-by: mssonicbld <[email protected]>
Collaborator
|
Cherry-pick PR to 202511: #22730 |
11 tasks
vmittal-msft
pushed a commit
that referenced
this pull request
Mar 4, 2026
What is the motivation for this PR? The assert in this function was triggering when run on simulators and HW devices How did you do it? How did you verify/test it? Verified with SIM Signed-off-by: Don Lopez <[email protected]> Signed-off-by: mssonicbld <[email protected]> Co-authored-by: donlope-cisco <[email protected]>
ksravani-hcl
pushed a commit
to ksravani-hcl/sonic-mgmt
that referenced
this pull request
Mar 10, 2026
What is the motivation for this PR? The assert in this function was triggering when run on simulators and HW devices How did you do it? How did you verify/test it? Verified with SIM Signed-off-by: Don Lopez <[email protected]>
aronovic
pushed a commit
to aronovic/sonic-mgmt
that referenced
this pull request
Mar 10, 2026
What is the motivation for this PR? The assert in this function was triggering when run on simulators and HW devices How did you do it? How did you verify/test it? Verified with SIM Signed-off-by: Don Lopez <[email protected]> Signed-off-by: Mihut Aronovici <[email protected]>
selldinesh
pushed a commit
to selldinesh/sonic-mgmt
that referenced
this pull request
Mar 16, 2026
What is the motivation for this PR? The assert in this function was triggering when run on simulators and HW devices How did you do it? How did you verify/test it? Verified with SIM Signed-off-by: Don Lopez <[email protected]> Signed-off-by: selldinesh <[email protected]>
abhishek-nexthop
pushed a commit
to nexthop-ai/sonic-mgmt
that referenced
this pull request
Mar 17, 2026
What is the motivation for this PR? The assert in this function was triggering when run on simulators and HW devices How did you do it? How did you verify/test it? Verified with SIM Signed-off-by: Don Lopez <[email protected]> Signed-off-by: Abhishek <[email protected]>
Contributor
|
Hey @Junchao-Mellanox , it looks like this test fix has led to failures on mlnx sn2700 platforms. Thanks |
vrajeshe
pushed a commit
to vrajeshe/sonic-mgmt
that referenced
this pull request
Mar 23, 2026
What is the motivation for this PR? The assert in this function was triggering when run on simulators and HW devices How did you do it? How did you verify/test it? Verified with SIM Signed-off-by: Don Lopez <[email protected]> Signed-off-by: Venkata Gouri Rajesh Etla <[email protected]>
12 tasks
ravaliyel
pushed a commit
to ravaliyel/sonic-mgmt
that referenced
this pull request
Mar 27, 2026
What is the motivation for this PR? The assert in this function was triggering when run on simulators and HW devices How did you do it? How did you verify/test it? Verified with SIM Signed-off-by: Don Lopez <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Changed the code in check_system_health_led_info() to use the keys to led_color, rather then hard coded (and incorrect in default case) colors.
Type of change
Back port request
Approach
What is the motivation for this PR?
The assert in this function was triggering when run on simulators and HW devices
How did you do it?
How did you verify/test it?
Verified with SIM
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation
Note that this bug has been seen in different topologies and may have duplicates.