[cherry-pick] Issue 20728: Enhance configlet/test_add_rack.py for ipv6-only topos (#21591)#23321
Merged
vmittal-msft merged 1 commit intosonic-net:202511from Mar 27, 2026
Conversation
…onic-net#21591) * Issue 20728: Enhance configlet/test_add_rack.py for ipv6-only topos Currently, the test checks for both ipv4 and ipv6 neighbors unconditionally, and will fail if either is missing. Change that behavior to instead check to see if neighbors exist before running the bgp checks. Add a failure case if no neighbors are found in either AF. This way the test is AF-agnostic. Signed-off-by: Anders Linn <[email protected]> * Address review comments Signed-off-by: Anders Linn <[email protected]> --------- Signed-off-by: Anders Linn <[email protected]>
anders-nexthop
requested review from
BYGX-wcr,
wsycqyz,
xwjiang-ms,
yejianquan and
yutongzhang-microsoft
as code owners
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
12 tasks
Collaborator
|
AI agent on behalf of Ying.\n\nFound 'print(' in diff.\n\n |
Contributor
Author
@yxieca the |
yxieca
approved these changes
Mar 26, 2026
Collaborator
yxieca
left a comment
yxieca
left a comment
There was a problem hiding this comment.
AI agent on behalf of Ying. Reviewed; no issues found.
vmittal-msft
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Cherry-pick of #21591 to 202511.
Summary:
Currently, the test checks for both ipv4 and ipv6 neighbors unconditionally, and will fail if either is missing. Change that behavior to instead check to see if neighbors exist before running the bgp checks. Add a failure case if no neighbors are found in either AF. This way the test is AF-agnostic.
Fixes #20728
Type of change
Back port request
Approach
What is the motivation for this PR?
Cherry-pick of #21591 as requested by @weiguo-nvidia.
How did you do it?
git cherry-pick 331f5944applied cleanly with no conflicts.How did you verify/test it?
Verified in master via #21591.
Any platform specific information?
N/A
Supported testbed topology if it's a new test case?
N/A
— anders-bot (AI-assisted, on behalf of @anders-nexthop)