Issue 20728: Enhance configlet/test_add_rack.py for ipv6-only topos by anders-nexthop · Pull Request #21591 · sonic-net/sonic-mgmt

anders-nexthop · 2025-12-05T20:21:46Z

Description of PR

Summary:
Currently, the test checks for both ipv4 and ipv6 neighbors unconditionally, and will fail if either is missing. Change that behavior to instead check to see if neighbors exist before running the bgp checks. Add a failure case if no neighbors are found in either AF. This way the test is AF-agnostic.

Closes #20728

Type of change

Back port request

Approach

What is the motivation for this PR?

Extend coverage for IPv6-only topos

How did you do it?

Add logic to check whether v4/v6 neighbor ips exist before checking whether they are up. If no neighbor ips are found at all, the test fails.

How did you verify/test it?

Ran the test on a vs topo with only v6 neighbors. It fails before these changes and passes after they are added.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

mssonicbld · 2025-12-05T20:21:54Z

/azp run

azure-pipelines · 2025-12-05T20:22:07Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-12-05T20:49:44Z

/azp run

azure-pipelines · 2025-12-05T20:49:57Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-12-05T20:50:52Z

/azp run

azure-pipelines · 2025-12-05T20:51:05Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-12-06T01:12:58Z

/azp run

azure-pipelines · 2025-12-06T01:13:11Z

Azure Pipelines successfully started running 1 pipeline(s).

anders-nexthop · 2025-12-08T18:38:12Z

/azpw

mssonicbld · 2025-12-10T15:42:13Z

/azp run

azure-pipelines · 2025-12-10T15:42:28Z

Azure Pipelines successfully started running 1 pipeline(s).

bingwang-ms · 2025-12-10T16:17:53Z

@yanmo96 Can you help review this PR? Thanks

mssonicbld · 2026-02-04T04:54:08Z

/azp run

azure-pipelines · 2026-02-04T04:54:22Z

Azure Pipelines successfully started running 1 pipeline(s).

anders-nexthop · 2026-02-04T15:59:41Z

/azpw run

mssonicbld · 2026-02-04T15:59:44Z

/AzurePipelines run

azure-pipelines · 2026-02-04T16:00:00Z

Azure Pipelines successfully started running 1 pipeline(s).

yanmo96

LGTM

azure-pipelines · 2026-03-12T06:30:03Z

Azure Pipelines successfully started running 1 pipeline(s).

anders-nexthop · 2026-03-12T16:56:49Z

/azpw run

mssonicbld · 2026-03-12T16:56:52Z

/AzurePipelines run

azure-pipelines · 2026-03-12T16:57:08Z

Azure Pipelines successfully started running 1 pipeline(s).

anders-nexthop · 2026-03-13T04:53:55Z

@yxieca here's another one that's passing all the checks

yanmo96 · 2026-03-13T16:43:37Z

Hi @anders-nexthop trying to merge, but some conflicts need to be resolve

Currently, the test checks for both ipv4 and ipv6 neighbors unconditionally, and will fail if either is missing. Change that behavior to instead check to see if neighbors exist before running the bgp checks. Add a failure case if no neighbors are found in either AF. This way the test is AF-agnostic. Signed-off-by: Anders Linn <[email protected]>

Signed-off-by: Anders Linn <[email protected]>

mssonicbld · 2026-03-13T16:50:45Z

/azp run

azure-pipelines · 2026-03-13T16:50:59Z

Azure Pipelines successfully started running 1 pipeline(s).

anders-nexthop · 2026-03-13T16:51:34Z

Thanks @yanmo96 yes some conflicts just came in, i have resolved them and updated the PR.

anders-nexthop · 2026-03-13T21:05:03Z

@yanmo96 all checks are passing now

yanmo96

LGTM

…onic-net#21591) * Issue 20728: Enhance configlet/test_add_rack.py for ipv6-only topos Currently, the test checks for both ipv4 and ipv6 neighbors unconditionally, and will fail if either is missing. Change that behavior to instead check to see if neighbors exist before running the bgp checks. Add a failure case if no neighbors are found in either AF. This way the test is AF-agnostic. Signed-off-by: Anders Linn <[email protected]> * Address review comments Signed-off-by: Anders Linn <[email protected]> --------- Signed-off-by: Anders Linn <[email protected]> Signed-off-by: selldinesh <[email protected]>

…onic-net#21591) * Issue 20728: Enhance configlet/test_add_rack.py for ipv6-only topos Currently, the test checks for both ipv4 and ipv6 neighbors unconditionally, and will fail if either is missing. Change that behavior to instead check to see if neighbors exist before running the bgp checks. Add a failure case if no neighbors are found in either AF. This way the test is AF-agnostic. Signed-off-by: Anders Linn <[email protected]> * Address review comments Signed-off-by: Anders Linn <[email protected]> --------- Signed-off-by: Anders Linn <[email protected]> Signed-off-by: Abhishek <[email protected]>

weiguo-nvidia · 2026-03-23T03:22:41Z

Hi @anders-nexthop ,

202511 branch also need this fix, could you help cherry-pick? thanks

…onic-net#21591) * Issue 20728: Enhance configlet/test_add_rack.py for ipv6-only topos Currently, the test checks for both ipv4 and ipv6 neighbors unconditionally, and will fail if either is missing. Change that behavior to instead check to see if neighbors exist before running the bgp checks. Add a failure case if no neighbors are found in either AF. This way the test is AF-agnostic. Signed-off-by: Anders Linn <[email protected]> * Address review comments Signed-off-by: Anders Linn <[email protected]> --------- Signed-off-by: Anders Linn <[email protected]> Signed-off-by: Venkata Gouri Rajesh Etla <[email protected]>

PR sonic-net#22895 added BGP session convergence wait before DB comparison in generic_patch_add_t0(), but unconditionally checks both IPv4 and IPv6 BGP sessions. On IPv6-only topologies (e.g. t1-isolated-v6-d56u1-lag), tor_data["ip"]["remote"] is empty, causing is_bgp_session_established() to fail. Fix by checking whether each neighbor IP exists before waiting for the BGP session, consistent with the chk_any_bgp_session() approach from PR sonic-net#21591. Change-Id: I694fd17b7b49b4ce4ece53e0521773b71f301b70 Signed-off-by: weiguo-nvidia <[email protected]>

…onic-net#21591) * Issue 20728: Enhance configlet/test_add_rack.py for ipv6-only topos Currently, the test checks for both ipv4 and ipv6 neighbors unconditionally, and will fail if either is missing. Change that behavior to instead check to see if neighbors exist before running the bgp checks. Add a failure case if no neighbors are found in either AF. This way the test is AF-agnostic. Signed-off-by: Anders Linn <[email protected]> * Address review comments Signed-off-by: Anders Linn <[email protected]> --------- Signed-off-by: Anders Linn <[email protected]>

anders-nexthop · 2026-03-25T20:20:20Z

Hi @weiguo-nvidia, cherry-pick to 202511 is up at #23321.

— anders-bot (AI-assisted, on behalf of @anders-nexthop)

…#23241) What is the motivation for this PR?\nPR #22895 added BGP session convergence wait before DB comparison in generic_patch_add_t0(), but unconditionally checks both IPv4 and IPv6 BGP sessions. On IPv6-only topologies (e.g. t1-isolated-v6-d56u1-lag), tor_data["ip"]["remote"] is empty, causing is_bgp_session_established() to fail.\n\nHow did you do it?\nFix by checking whether each neighbor IP exists before waiting for the BGP session, consistent with the chk_any_bgp_session() approach from PR #21591.\n\nHow did you verify/test it?\nRegression test pass\n\nSigned-off-by:\nweiguo-nvidia <[email protected]>

…onic-net#21591) * Issue 20728: Enhance configlet/test_add_rack.py for ipv6-only topos Currently, the test checks for both ipv4 and ipv6 neighbors unconditionally, and will fail if either is missing. Change that behavior to instead check to see if neighbors exist before running the bgp checks. Add a failure case if no neighbors are found in either AF. This way the test is AF-agnostic. Signed-off-by: Anders Linn <[email protected]> * Address review comments Signed-off-by: Anders Linn <[email protected]> --------- Signed-off-by: Anders Linn <[email protected]>

…sonic-net#23241) What is the motivation for this PR?\nPR sonic-net#22895 added BGP session convergence wait before DB comparison in generic_patch_add_t0(), but unconditionally checks both IPv4 and IPv6 BGP sessions. On IPv6-only topologies (e.g. t1-isolated-v6-d56u1-lag), tor_data["ip"]["remote"] is empty, causing is_bgp_session_established() to fail.\n\nHow did you do it?\nFix by checking whether each neighbor IP exists before waiting for the BGP session, consistent with the chk_any_bgp_session() approach from PR sonic-net#21591.\n\nHow did you verify/test it?\nRegression test pass\n\nSigned-off-by:\nweiguo-nvidia <[email protected]>

…21591) (#23321) * Issue 20728: Enhance configlet/test_add_rack.py for ipv6-only topos Currently, the test checks for both ipv4 and ipv6 neighbors unconditionally, and will fail if either is missing. Change that behavior to instead check to see if neighbors exist before running the bgp checks. Add a failure case if no neighbors are found in either AF. This way the test is AF-agnostic. * Address review comments --------- Signed-off-by: Anders Linn <[email protected]>

github-actions bot requested review from wsycqyz, xwjiang-ms and yejianquan December 5, 2025 20:21

anders-nexthop mentioned this pull request Dec 5, 2025

Bug:[IPv6 only topo] [test_add_rack] test_add_rack not updated to IPv6 only topology #20728

Closed

anders-nexthop force-pushed the anders.20728.test_add_rack-for-ipv6 branch from 901068c to 71be742 Compare December 5, 2025 20:49

anders-nexthop force-pushed the anders.20728.test_add_rack-for-ipv6 branch from 71be742 to ede382f Compare December 5, 2025 20:50

anders-nexthop force-pushed the anders.20728.test_add_rack-for-ipv6 branch from ede382f to aa1938f Compare December 6, 2025 01:12

github-actions bot requested review from BYGX-wcr and yutongzhang-microsoft December 6, 2025 01:13

anders-nexthop force-pushed the anders.20728.test_add_rack-for-ipv6 branch from aa1938f to fbf5115 Compare December 10, 2025 15:42

yxieca requested a review from yanmo96 December 10, 2025 16:17

anders-nexthop force-pushed the anders.20728.test_add_rack-for-ipv6 branch from fbf5115 to c23e5ca Compare February 4, 2026 04:54

yanmo96 previously approved these changes Feb 26, 2026

View reviewed changes

anders-nexthop added 2 commits March 13, 2026 16:49

Address review comments

40c4d72

Signed-off-by: Anders Linn <[email protected]>

anders-nexthop dismissed yxieca’s stale review via 40c4d72 March 13, 2026 16:50

anders-nexthop force-pushed the anders.20728.test_add_rack-for-ipv6 branch from ac5e4bd to 40c4d72 Compare March 13, 2026 16:50

yanmo96 approved these changes Mar 13, 2026

View reviewed changes

yanmo96 merged commit 331f594 into sonic-net:master Mar 13, 2026
16 checks passed

weiguo-nvidia mentioned this pull request Mar 24, 2026

Fix IPv6-only topology support in generic_patch BGP convergence check #23241

Merged

12 tasks

anders-nexthop mentioned this pull request Mar 25, 2026

[cherry-pick] Issue 20728: Enhance configlet/test_add_rack.py for ipv6-only topos (#21591) #23321

Merged

12 tasks

Copilot AI mentioned this pull request Mar 26, 2026

Review PRs opened in the last 48 hours by humans #23330

Draft

Conversation

anders-nexthop commented Dec 5, 2025

Description of PR

Type of change

Back port request

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Uh oh!

mssonicbld commented Dec 5, 2025

Uh oh!

azure-pipelines bot commented Dec 5, 2025

Uh oh!

mssonicbld commented Dec 5, 2025

Uh oh!

azure-pipelines bot commented Dec 5, 2025

Uh oh!

mssonicbld commented Dec 5, 2025

Uh oh!

azure-pipelines bot commented Dec 5, 2025

Uh oh!

mssonicbld commented Dec 6, 2025

Uh oh!

azure-pipelines bot commented Dec 6, 2025

Uh oh!

anders-nexthop commented Dec 8, 2025

Uh oh!

mssonicbld commented Dec 10, 2025

Uh oh!

azure-pipelines bot commented Dec 10, 2025

Uh oh!

bingwang-ms commented Dec 10, 2025

Uh oh!

mssonicbld commented Feb 4, 2026

Uh oh!

azure-pipelines bot commented Feb 4, 2026

Uh oh!

anders-nexthop commented Feb 4, 2026

Uh oh!

mssonicbld commented Feb 4, 2026

Uh oh!

azure-pipelines bot commented Feb 4, 2026

Uh oh!

yanmo96 left a comment

Choose a reason for hiding this comment

Uh oh!

azure-pipelines bot commented Mar 12, 2026

Uh oh!

anders-nexthop commented Mar 12, 2026

Uh oh!

mssonicbld commented Mar 12, 2026

Uh oh!

azure-pipelines bot commented Mar 12, 2026

Uh oh!

anders-nexthop commented Mar 13, 2026

Uh oh!

yanmo96 commented Mar 13, 2026

Uh oh!

mssonicbld commented Mar 13, 2026

Uh oh!

azure-pipelines bot commented Mar 13, 2026

Uh oh!

anders-nexthop commented Mar 13, 2026

Uh oh!

anders-nexthop commented Mar 13, 2026

Uh oh!

yanmo96 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

weiguo-nvidia commented Mar 23, 2026

Uh oh!

anders-nexthop commented Mar 25, 2026

Uh oh!

Reviewers

Assignees