Fix ipfwd/test_dip_sip.py for v6 topo#23315
Merged
StormLiangMS merged 1 commit intosonic-net:masterfrom Mar 26, 2026
Merged
Conversation
Skip test_ipv4_forwarding for v6 topo Fix test_ipv6_forwarding by skipping IPv4 operations in setup and teardown fixtures Signed-off-by: markxiao <[email protected]>
github-actions
bot
requested review from
BYGX-wcr,
xwjiang-ms and
yutongzhang-microsoft
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
Note that 202412 has a fix that is not compatible with master/202511: Azure/sonic-mgmt.msft#707 |
yxieca
approved these changes
Mar 26, 2026
Collaborator
yxieca
left a comment
yxieca
left a comment
There was a problem hiding this comment.
AI agent on behalf of Ying. Reviewed; no issues found.
StormLiangMS
approved these changes
Mar 26, 2026
Collaborator
StormLiangMS
left a comment
StormLiangMS
left a comment
There was a problem hiding this comment.
@markx-arista — Reviewed. LGTM overall ✅
All 18 CI checks pass, DCO/CLA clean. The fix correctly guards IPv4 code paths for v6-only topologies and populates _host_mac for IPv6 interfaces (was missing before).
Minor nits (non-blocking):
- Approach section blank in PR description — would be helpful to briefly note the fix strategy for future reference.
- Trailing whitespace on line 97 of
test_dip_sip.py(after the closing"). - Style inconsistency:
setup_static_routecachesis_v6_topo = is_ipv6_only_topology(tbinfo)whilesetup_teardowncalls it inline — minor but worth making consistent.
None of these block merge. Approve.
StormLiangMS
added
Request for 202511 branch
Collaborator
|
@markx-arista PR conflicts with 202511 branch |
Contributor
Author
|
@StormLiangMS There is PR conflict on 202511 because this PR #19931 is not on 202511 yet, can you cherry-pick that one to 202511 first? Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Skip test_ipv4_forwarding for v6 topo
Fix test_ipv6_forwarding by skipping IPv4 operations in setup and teardown fixtures
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation