Skip to content

adjust test_dip_sip.py to ipv6 only topology#707

Merged
yanmo96 merged 2 commits intoAzure:202412from
ytzur1:new_dip_sip
Oct 28, 2025
Merged

adjust test_dip_sip.py to ipv6 only topology#707
yanmo96 merged 2 commits intoAzure:202412from
ytzur1:new_dip_sip

Conversation

@ytzur1
Copy link

@ytzur1 ytzur1 commented Sep 16, 2025

Description of PR

Adjust test_dip_sip.py to ipv6 only topology
Modified get_lag_facts and get_ports_facts to support ipv6 only topo, and adjusted the cases to run with this topo.
This PR is only for 202412 branch, because the following PR - sonic-net/sonic-mgmt#17058 was not CP to this branch

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
  • Skipped for non-supported platforms
  • Test case improvement

Approach

What is the motivation for this PR?

fix test to run as expected on ipv6 only topo

How did you do it?

selected the ipv6 ip option for lags and ports facts
and only run ipv6 validation on the test itself.

How did you verify/test it?

internal nvidia regression

@Pterosaur Pterosaur requested a review from yanmo96 September 21, 2025 01:59
Copy link

@yanmo96 yanmo96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@r12f
Copy link
Contributor

r12f commented Oct 24, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@r12f
Copy link
Contributor

r12f commented Oct 28, 2025

hi @ytzur1 , although we have all signed off, but CI is failing static analysis and need update.

@ytzur1
Copy link
Author

ytzur1 commented Oct 28, 2025

Hi @r12f ,
resolved

@yanmo96 yanmo96 merged commit 5a7eb08 into Azure:202412 Oct 28, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants