Skip to content

[multi-asic] Add multi-asic support for test_dip_sip#19931

Merged
rlhui merged 1 commit intosonic-net:masterfrom
vishal-nokia:test_dip_sip_fix
Mar 22, 2026
Merged

[multi-asic] Add multi-asic support for test_dip_sip#19931
rlhui merged 1 commit intosonic-net:masterfrom
vishal-nokia:test_dip_sip_fix

Conversation

@vishal-nokia
Copy link
Contributor

@vishal-nokia vishal-nokia commented Jul 30, 2025

Summary:

  • add multi-asic support for testcases in test_dip_sip.py
  • refactor code to use sonic CLI for route addition/deletion

Fixes #19769

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202205
  • 202305
  • 202311
  • 202405
  • 202411
  • 202505
  • 202511

Approach

What is the motivation for this PR?

Multi-asic support was missing for test cases in test_dip_sip.py

How did you do it?

  • Add mutli-asic support for route check, addition and deletion.
  • Enhanced test cases to use SONiC CLI

How did you verify/test it?

Run tests on single-asic and multi-asic DUTs

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

image

- add multi-asic support for testcases
- refactor code to use sonic CLI for route addition/deletion
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@abdosi abdosi self-requested a review July 30, 2025 17:13
@rlhui rlhui requested review from YatishSVC and rawal01 March 4, 2026 18:30
@rlhui
Copy link

rlhui commented Mar 4, 2026

@arista-setu please help review this one? thanks.

Copy link
Collaborator

@yxieca yxieca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI agent on behalf of Ying. Reviewed; no issues found.

Copy link
Contributor

@rawal01 rawal01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@YatishSVC YatishSVC requested a review from arlakshm March 20, 2026 00:00
@rlhui rlhui merged commit 6cfb756 into sonic-net:master Mar 22, 2026
14 checks passed
vrajeshe pushed a commit to vrajeshe/sonic-mgmt that referenced this pull request Mar 23, 2026
- add multi-asic support for testcases
- refactor code to use sonic CLI for route addition/deletion

Signed-off-by: Venkata Gouri Rajesh Etla <vrajeshe@cisco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Bug: [Chassis] MultiAsics support is needed for test_dip_sip testcases in ipfwd suite

7 participants