Skip to content

GCU: skip ECN test for certain Cisco platforms #23213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dcaugher wants to merge 8 commits into from
Closed

GCU: skip ECN test for certain Cisco platforms #23213

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
77722f1
Skip ECN config update test for GR2 platforms (MIGSOFTWAR-33801)
dcaugher Feb 4, 2026
5e2f84d
remove Cisco-specific issue comment
dcaugher Feb 4, 2026
bc3e95d
broaden skip condition
Feb 4, 2026
0f6bd71
Fix type hints for optional OTLP imports to prevent NameError
dcaugher Feb 18, 2026
938ba77
Merge upstream/master into master
dcaugher Mar 11, 2026
305a4a1
Merge branch 'sonic-net:master' into master
dcaugher Mar 24, 2026
afe030d
avoid GCU ECN test for currently unsupported Cisco platforms
dcaugher Feb 10, 2026
1e367e0
address review comments
dcaugher Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/common/plugins/conditional_mark/tests_mark_conditions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2507,10 +2507,10 @@ generic_config_updater/test_dynamic_acl.py::test_gcu_acl_forward_rule_replacemen

generic_config_updater/test_ecn_config_update.py::test_ecn_config_updates:
skip:
reason: "This test is not run on this asic type, topology, or version currently"
reason: "WRED dynamic config updates not implemented in SAI for PAC/GR2 ASICs"
conditions_logical_operator: "OR"
conditions:
- "hwsku in ['Cisco-8800-LC-48H-C48']"
- "hwsku in ['Cisco-8800-LC-48H-C48', 'Cisco-8122-O128S2', 'Cisco-8122-O64']"
- "topo_type in ['m0', 'mx', 'm1']"
- "release in ['202211']"
- "https://github.com/sonic-net/sonic-buildimage/issues/22295 and platform in ['x86_64-nvidia_sn5600-r0', 'x86_64-nvidia_sn5640-r0']"
Expand Down
2 changes: 2 additions & 0 deletions tests/generic_config_updater/test_ecn_config_update.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
"""Tests for ECN/WRED configuration updates via Generic Config Updater.
"""
import ast
from functools import cmp_to_key
import logging
Expand Down
Loading