fix for led color in test_system_health.py (sonic-net#22675)

What is the motivation for this PR?
The assert in this function was triggering when run on simulators and HW devices

How did you do it?
How did you verify/test it?
Verified with SIM

Signed-off-by: Don Lopez <[email protected]>
Signed-off-by: Venkata Gouri Rajesh Etla <[email protected]>

Author: donlope-cisco

tests/system_health/test_system_health.py

@@ -63,6 +63,12 @@
 EXPECT_PSU_HOT = '{} temperature is too hot'
 EXPECT_PSU_INVALID_VOLTAGE = '{} voltage is out of range'
 
+DEFAULT_LED_CONFIG = {
+    'fault': 'red',
+    'normal': 'green',
+    'booting': 'red'
+}
+
 
 @pytest.fixture(autouse=True, scope="module")
 def check_image_version(duthost):
@@ -516,12 +522,19 @@ def check_system_health_led_info(duthost):
     status_dict = {name: status for name, status in status_data}
     logger.info(f"Status dict is {status_dict}")
 
+    led_cfg = get_system_health_config(duthost, "led_color", DEFAULT_LED_CONFIG)
+
+    system_status_lower = system_led_status.lower()
     if all(status == "OK" for status in status_dict.values()):
-        assert system_led_status.lower() == 'green', \
-            f"System status LED is not green, but it is {system_led_status}"
+        # Logic for healthy system: must match the 'normal' key value
+        expected_normal = led_cfg["normal"].lower()
+        assert system_status_lower == expected_normal, \
+            f"System status LED is not the configured 'normal' color ({expected_normal}), but it is {system_led_status}"
     else:
-        assert system_led_status.lower() in ["yellow", "amber", "red"], \
-            f"System status LED is not yellow, amber, or red, but it is {system_led_status}"
+        # Logic for faulted system: Iterate through led_cfg to find a match among non-normal keys
+        not_normal = {color for key, color in led_cfg.items() if key != "normal"}
+        assert system_status_lower in not_normal, \
+            f"System status LED '{system_led_status}' does not match any colors defined in config: {not_normal}"
 
     return True