[mmu probing] pr01.docs: Add MMU threshold probing framework design#22539
Merged
StormLiangMS merged 1 commit intosonic-net:masterfrom Mar 25, 2026
Merged
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
XuChen-MSFT
requested review from
StormLiangMS,
bingwang-ms,
kperumalbfn,
wsycqyz and
yxieca
and removed request for
mihirpat1,
r12f and
wangxin
XuChen-MSFT
changed the title
This was referenced Feb 23, 2026
Add comprehensive design document for MMU threshold probing framework, including: - Three-phase probing algorithms (upper/lower bound + threshold detection) - Executor protocol for platform abstraction - Observer pattern for metrics tracking - Template method pattern for test case framework - Integration with SONiC QoS test infrastructure Signed-off-by: Xu Chen <[email protected]>
XuChen-MSFT
force-pushed
the
xuchen3/mmu_probe/pr01-documentation
branch
from
320c509 to
2ed9f72
Compare
Collaborator
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
StormLiangMS
approved these changes
Mar 25, 2026
Collaborator
StormLiangMS
left a comment
StormLiangMS
left a comment
There was a problem hiding this comment.
✅ LGTM — Excellent design documentation
Comprehensive 1,700-line design doc that thoroughly covers the probing methodology. Highlights:
- Quantitative evidence: Real hardware data from Mellanox SN4600C and Arista 7260CX3 backs every design decision
- Error accumulation analysis (§3.4): Clear demonstration of why Range-Based composite probing fails (up to 528% error on TD3) and why Step-by-Step Point Probing is necessary
- Step-size optimization (§3.4.8): Empirical comparison on physical hardware — step_size=2 as optimal balance (0.39% error, 61.8 min) is well-justified
- Architecture diagrams: Four-role separation (ProbingBase/Algorithm/Executor/Observer) is clearly explained with UML and sequence diagrams
Minor: Some UTF-8 box-drawing characters may render with artifacts depending on the viewer, but the content is clear regardless.
12 tasks
ravaliyel
pushed a commit
to ravaliyel/sonic-mgmt
that referenced
this pull request
Mar 27, 2026
Add comprehensive design document for MMU threshold probing framework, including: - Three-phase probing algorithms (upper/lower bound + threshold detection) - Executor protocol for platform abstraction - Observer pattern for metrics tracking - Template method pattern for test case framework - Integration with SONiC QoS test infrastructure Signed-off-by: Xu Chen <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Add comprehensive design document for MMU threshold probing framework,
including:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
qos refactoring
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation
relevant PRs:
[mmu probing] pr01.docs: Add MMU threshold probing framework design
[mmu probing] pr02.probe: Add core probing algorithms with essential data structures
[mmu probing] pr03.probe: Add probing executors and executor registry
[mmu probing] pr04.probe: Add observer pattern for metrics tracking
[mmu probing] pr05.probe: Add stream manager and buffer occupancy controller
[mmu probing] pr06.probe: Add base framework and all probing implementations
[mmu probing] pr07.test: Add comprehensive unit tests for probe framework
[mmu probing] pr08.test: Add integration tests for end-to-end probing workflows
[mmu probing] pr09.test: Add production probe test and infrastructure updates