[mmu probing] pr10.test: Add supplementary UTs and IT for review findings#23341
Open
XuChen-MSFT wants to merge 3 commits intosonic-net:masterfrom
Open
[mmu probing] pr10.test: Add supplementary UTs and IT for review findings#23341XuChen-MSFT wants to merge 3 commits intosonic-net:masterfrom
XuChen-MSFT wants to merge 3 commits intosonic-net:masterfrom
Conversation
3 new/updated UTs for LowerBoundProbingAlgorithm: - test_lower_bound_returns_1_when_threshold_always_triggered (order 8350) - test_lower_bound_returns_1_with_various_upper_bounds (order 8351) - Updated test_run_no_infinite_loop_at_current_one (order 8340): assert 1 not None - Updated test_run_maximum_iterations_exceeded (order 8260): assert 1 not None - Updated test_run_reaches_minimum_value (order 8270): assert 1 not None 1 new IT for PfcXoffProbing: - test_pfc_xoff_lower_bound_returns_value_not_none: threshold=1, verify probe succeeds with lower_bound=1 instead of failing Validates fix in PR sonic-net#22540: lower bound returns 1 instead of None when threshold triggered at minimum packet count. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Xu Chen <xuchen3@microsoft.com>
Collaborator
|
/azp run |
12 tasks
|
Azure Pipelines successfully started running 1 pipeline(s). |
…istency 2 new UTs for ThresholdRangeProbingAlgorithm: - test_backtrack_nudge_bounds_check (order 8890): verifies max(0,...) prevents negative merged_start when nudging near lower_bound=0 - test_precision_int_consistency (order 8891): verifies int() wrapper on precision target for type-consistent comparison 1 updated UT: - test_precision_check_at_small_threshold_with_bad_spot (order 8870): updated expectation for max(0,...) bounds check interaction with backtrack near 0 Validates fix in PR sonic-net#22540: backtrack nudge bounds + precision int. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Xu Chen <xuchen3@microsoft.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
XuChen-MSFT
requested review from
StormLiangMS,
ZhaohuiS,
lipxu,
wsycqyz and
yxieca
and removed request for
lipxu
F541: f-string is missing placeholders at test_pfc_xoff_probing.py:1128. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Xu Chen <xuchen3@microsoft.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Supplementary unit tests and integration tests for the MMU threshold probing framework,
covering edge cases identified during review of PR #22540.
Test Changes:
Validates fix in PR #22540: lower bound algorithm returns 1 instead of None when threshold
is triggered at minimum packet count.
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
qos refactoring - supplementary tests for review findings
How did you do it?
How did you verify/test it?
TDD: RED (3 UT + 1 IT fail before fix) → GREEN (all pass after fix) → REGRESSION (444 UT + 58 IT pass)
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation
relevant PRs:
[mmu probing] pr02.probe: Add core probing algorithms
[mmu probing] pr01-pr09 series