[mmu probing] pr04.probe: Add observer pattern for metrics tracking#22542
Merged
XuChen-MSFT merged 2 commits intosonic-net:masterfrom Mar 24, 2026
Merged
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
XuChen-MSFT
requested review from
StormLiangMS,
bingwang-ms,
kperumalbfn,
wsycqyz and
yxieca
This was referenced Feb 23, 2026
yxieca
previously approved these changes
Feb 23, 2026
Collaborator
yxieca
left a comment
yxieca
left a comment
There was a problem hiding this comment.
Deep review done. Observer config/implementation looks sound; no issues found.
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yxieca
approved these changes
Feb 24, 2026
Collaborator
yxieca
left a comment
yxieca
left a comment
There was a problem hiding this comment.
Re-reviewed updates; no new issues found.
Implement observer pattern for probing metrics collection and monitoring: Observer Configuration: - ObserverConfig: Dataclass for observer behavior configuration Controls verbosity, detailed logging, and metrics tracking options Observer Implementation: - ProbingObserver: Observer for probing iteration tracking Collects metrics including: - Iteration counts and outcomes (SUCCESS/DROP/XOFF) - Threshold detection events - Buffer state transitions - Timing measurements - Detailed iteration history for debugging The observer pattern enables decoupled metrics collection without affecting algorithm logic, supporting both debugging and production monitoring use cases. Signed-off-by: Xu Chen <[email protected]>
Signed-off-by: Xu Chen <[email protected]>
XuChen-MSFT
force-pushed
the
xuchen3/mmu_probe/pr04-observer
branch
from
6435552 to
404df42
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ravaliyel
pushed a commit
to ravaliyel/sonic-mgmt
that referenced
this pull request
Mar 27, 2026
…onic-net#22542) * probe: Add observer pattern for metrics tracking Implement observer pattern for probing metrics collection and monitoring: Observer Configuration: - ObserverConfig: Dataclass for observer behavior configuration Controls verbosity, detailed logging, and metrics tracking options Observer Implementation: - ProbingObserver: Observer for probing iteration tracking Collects metrics including: - Iteration counts and outcomes (SUCCESS/DROP/XOFF) - Threshold detection events - Buffer state transitions - Timing measurements - Detailed iteration history for debugging The observer pattern enables decoupled metrics collection without affecting algorithm logic, supporting both debugging and production monitoring use cases. Signed-off-by: Xu Chen <[email protected]> * fix pre-commit errors Signed-off-by: Xu Chen <[email protected]> --------- Signed-off-by: Xu Chen <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Implement observer pattern for probing metrics collection and monitoring:
Observer Configuration:
Observer Implementation:
The observer pattern enables decoupled metrics collection without affecting algorithm logic, supporting both debugging and production monitoring use cases.
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
qos refactoring
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation
relevant PRs:
[mmu probing] pr01.docs: Add MMU threshold probing framework design
[mmu probing] pr02.probe: Add core probing algorithms with essential data structures
[mmu probing] pr03.probe: Add probing executors and executor registry
[mmu probing] pr04.probe: Add observer pattern for metrics tracking
[mmu probing] pr05.probe: Add stream manager and buffer occupancy controller
[mmu probing] pr06.probe: Add base framework and all probing implementations
[mmu probing] pr07.test: Add comprehensive unit tests for probe framework
[mmu probing] pr08.test: Add integration tests for end-to-end probing workflows
[mmu probing] pr09.test: Add production probe test and infrastructure updates