[Platform API][Chassis] Compare applicable data against values from platform.json#2209
Merged
jleveque merged 12 commits intosonic-net:masterfrom Sep 23, 2020
jleveque:enhance_chassis_tests
Merged
[Platform API][Chassis] Compare applicable data against values from platform.json#2209jleveque merged 12 commits intosonic-net:masterfrom jleveque:enhance_chassis_tests
jleveque merged 12 commits intosonic-net:masterfrom
jleveque:enhance_chassis_tests
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
vdahiya12
approved these changes
Sep 12, 2020
3 tasks
yxieca
approved these changes
Sep 14, 2020
jleveque
added a commit
that referenced
this pull request
Sep 14, 2020
…n Python 2 (#2210) Python 2 has two string types, `str` and `unicode`. Both share a `basestring` superclass. In Python 3, there is only one `str` type. This patch allows the platform API tests to consider a string type valid whether it is ASCII (`str`) or Unicode in Python 2. It also future-proofs the inevitable transition to Python 3 by checking the executing Python version. Note that test_chassis.py is not modified here, as the change is being applied as part of #2209
added 2 commits
September 14, 2020 20:03
This comment has been minimized.
This comment has been minimized.
vdahiya12
reviewed
Sep 14, 2020
Contributor
Author
|
Retest vsimage please |
Contributor
Author
|
Retest this please |
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
``` 323dc34 [neighsyncd] increase neighsyncd timeout (sonic-net#2209) 7f99941 Remove redundant and problematic code to skip "pool" field in buffer profile handling (sonic-net#2197) f3a0feb [Vxlanmgr] vnet netdev cleanup during config reload fix (sonic-net#2191) 13ccaba Fix issue: sometimes PFC WD unable to create zero buffer pool (sonic-net#2185) ``` Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
5bb99c7 Validate LAG has members before mirror session create (sonic-net#2130) ec6c8af [vxlan] Remove tunnel map objects on VNET tunnel removal (sonic-net#2150) 7e7db19 [BFD]Registering BFD state change callback during session creation (sonic-net#2202) 618fe07 [VNET]Fixing nexthop group delete during route change (sonic-net#2198) 91b66df [portsorch]: Prevent LAG member configuration when port has active ACL binding (sonic-net#2165) 29de9d0 Remove redundant and problematic code to skip "pool" field in buffer profile handling (sonic-net#2197) ded0b45 [PBH] Implement Edit Flows (sonic-net#2169) 2ee0f49 [neighsyncd] increase neighsyncd timeout (sonic-net#2209) a0160c0 [QosOrch] The notifications cannot be drained in QosOrch in case the first one needs to retry (sonic-net#2206)
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
[neighsyncd] increase neighsyncd timeout (sonic-net#2209) Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
For chassis tests where known facts are available in the platform.json file, compare actual values against those facts
Also update to handle both
strandunicodestring types in Python 2.Type of change
Approach
What is the motivation for this PR?
To improve the quality of the Chassis platform API test
How did you do it?
For chassis tests where known facts are available in the platform.json file, compare actual values against those facts
How did you verify/test it?
Run Chassis tests on a device with a populated platform.json present
Any platform specific information?
Platform must have a populated platform.json present