[LogAnalyzer] Skip LogAnalyzer if test case is skipped#2191
Merged
bingwang-ms merged 1 commit intosonic-net:masterfrom Sep 11, 2020
Merged
Conversation
Currently, LogAnalyzer still analyze log file even test case is skipped, which may result in a confusing test result. This commit fix this issue
lolyu
approved these changes
Sep 9, 2020
neethajohn
approved these changes
Sep 9, 2020
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
``` 323dc34 [neighsyncd] increase neighsyncd timeout (sonic-net#2209) 7f99941 Remove redundant and problematic code to skip "pool" field in buffer profile handling (sonic-net#2197) f3a0feb [Vxlanmgr] vnet netdev cleanup during config reload fix (sonic-net#2191) 13ccaba Fix issue: sometimes PFC WD unable to create zero buffer pool (sonic-net#2185) ``` Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
17315fc (HEAD -> 202111, origin/202111) [Vxlanmgr] vnet netdev cleanup during config reload fix (sonic-net#2191) f820af3 [aclorch] Do not fail ACL rule remove flow if rule already deleted (sonic-net#2183)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Skip LogAnalyzer if test case is skipped
Currently, LogAnalyzer still analyze log file even test case is skipped, which may result in a confusing test result. This commit fix this issue
Type of change
Approach
What is the motivation for this PR?
Currently, LogAnalyzer still analyze log file when test case is skipped, which may result in a confusing test result.
This commit address this issue.
How did you do it?
Add a check before LogAnalyzer starting analyze logs. If test case is skipped, then LogAnalyzer is skipped.
How did you verify/test it?
Verified on Arista-7260, and confirm that LogAnalyzer is skipped.
Any platform specific information?
No.
Supported testbed topology if it's a new test case?
N/A
Documentation
No.