Merged
Conversation
baiwei0427
requested changes
Sep 11, 2020
docs/PFC-test-plan.md
Outdated
| #### Test Configuration | ||
|
|
||
| - On SONiC Device Under Test (DUT) configure lossless priority of all values Pi (0 \<= i \<= | ||
| 7). |
Contributor
There was a problem hiding this comment.
We don't need to enable PFC on all the priorities. We just need to enable PFC on required priorities, e.g., 3 and 4.
Contributor
Author
There was a problem hiding this comment.
Changed the description to reflect priorities of 3 and 4
docs/PFC-test-plan.md
Outdated
| 7). | ||
| - Configure following traffic items on the Keysight device: | ||
| 1. Test data traffic: A traffic item from the Keysight Tx port with all the 8 priorities Pi (0<= i <= 7), DSCP values from (0 - 63) and enable flow group by PFC Queue. Traffic should be configured with 100% line rate. | ||
| 2. GLOBAL PAUSE storm: Persistent Global pause frames from the Keysight Rx port to the Keysight Tx port. And the inter-frame transmission interval should be smaller than per-frame global pause duration. |
Contributor
There was a problem hiding this comment.
per-frame global pause duration -> per-frame pause duration
Contributor
Author
There was a problem hiding this comment.
Modification done as "per-frame global pause duration -> per-frame pause duration"
docs/PFC-test-plan.md
Outdated
| 3. Keep the Test data traffic running for a fixed duration (eg 5sec) and then stop the traffic item. | ||
| 4. Verify the following: | ||
| * Keysight Rx port should receive all the 'Test data traffic'. There should not be any loss observed. Throughput should be close to link capacity. | ||
| * SONiC DUT will discard all Global pause frames. |
Contributor
There was a problem hiding this comment.
There is no way to check if SONiC will discard all global pause frames.
docs/PFC-test-plan.md
Outdated
| 4. Verify the following: | ||
| * Keysight Rx port should receive all the 'Test data traffic'. There should not be any loss observed. Throughput should be close to link capacity. | ||
| * SONiC DUT will discard all Global pause frames. | ||
| 5. Stop the GLOBAL PAUSE storm. No newline at end of file |
Contributor
There was a problem hiding this comment.
Change the order of 4 and 5.
Contributor
Author
There was a problem hiding this comment.
Got your point. Changed the point as suggested.
Contributor
|
retest this please |
baiwei0427
requested changes
Sep 23, 2020
baiwei0427
approved these changes
Sep 23, 2020
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
* [202012] - sonic-swss submodule update to include following commits: fca407a (HEAD) [VNET]Fixing nexthop group delete during route change (sonic-net#2198) a9b6b47 [vxlan] Remove tunnel map objects on VNET tunnel removal (sonic-net#2208) 74e9b9f [FdbOrch] SAI_FDB_EVENT_MOVE generates update with empty update.entry.port_name (sonic-net#2201) 0a99445 [202012][BFD]Registering BFD state change callback during session creation (sonic-net#2203) aebe4a1 [VS test] skip dpb flaky test (sonic-net#2195) (sonic-net#2207)
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
5bb99c7 Validate LAG has members before mirror session create (sonic-net#2130) ec6c8af [vxlan] Remove tunnel map objects on VNET tunnel removal (sonic-net#2150) 7e7db19 [BFD]Registering BFD state change callback during session creation (sonic-net#2202) 618fe07 [VNET]Fixing nexthop group delete during route change (sonic-net#2198) 91b66df [portsorch]: Prevent LAG member configuration when port has active ACL binding (sonic-net#2165) 29de9d0 Remove redundant and problematic code to skip "pool" field in buffer profile handling (sonic-net#2197) ded0b45 [PBH] Implement Edit Flows (sonic-net#2169) 2ee0f49 [neighsyncd] increase neighsyncd timeout (sonic-net#2209) a0160c0 [QosOrch] The notifications cannot be drained in QosOrch in case the first one needs to retry (sonic-net#2206)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # 2197 ( Addition of Test Case - Global Pause into PFC Test Plan )
Type of change
Documentation of Test Case
Test Case - Objective
Test Case - Configuration
Test Steps
Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation