Improve anchor definition in conditional mark by wangxin · Pull Request #21943 · sonic-net/sonic-mgmt

wangxin · 2026-01-15T02:49:14Z

Description of PR

Summary:
Fixes # (issue)

Type of change

Back port request

Approach

What is the motivation for this PR?

PR #20326 introduced anchors in the conditional mark yaml files. The anchors are defined in a dummy entry for test_pretest.py.

PR #20382 updated code to add exception for the sort checking of test_pretest.py in conditional mark yaml files.

These changes made it complicated when we do need to skip something for test_pretest.py.

How did you do it?

This change fixed the problem by using a real dummy entry for defining the yaml anchors.

The code of skipping test_pretest.py in sort checking in conditional mark yaml file is also removed.

This change also improved a variable name in conditional mark and fixed a few typos.

How did you verify/test it?

PR tests can cover the verification.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

PR sonic-net#20326 introduced anchors in the conditional mark yaml files. The anchors are defined in a dummy entry for test_pretest.py. PR sonic-net#20382 updated code to add exception for the sort checking of test_pretest.py in conditional mark yaml files. These changes made it complicated when we do need to skip something for test_pretest.py. This change fixed the problem by using a real dummy entry for defining the yaml anchors. The code of skipping test_pretest.py in sort checking in conditional mark yaml file is also removed. This change also improved a variable name in conditional mark and fixed a few typos. Signed-off-by: Xin Wang <xiwang5@microsoft.com>

mssonicbld · 2026-01-15T02:49:21Z

/azp run

azure-pipelines · 2026-01-15T02:49:35Z

Azure Pipelines successfully started running 1 pipeline(s).

PR sonic-net#20326 introduced anchors in the conditional mark yaml files. The anchors are defined in a dummy entry for test_pretest.py. PR sonic-net#20382 updated code to add exception for the sort checking of test_pretest.py in conditional mark yaml files. These changes made it complicated when we do need to skip something for test_pretest.py. This change fixed the problem by using a real dummy entry for defining the yaml anchors. The code of skipping test_pretest.py in sort checking in conditional mark yaml file is also removed. This change also improved a variable name in conditional mark and fixed a few typos. Signed-off-by: Xin Wang <xiwang5@microsoft.com> Signed-off-by: Priyansh Tratiya <ptratiya@microsoft.com>

PR sonic-net#20326 introduced anchors in the conditional mark yaml files. The anchors are defined in a dummy entry for test_pretest.py. PR sonic-net#20382 updated code to add exception for the sort checking of test_pretest.py in conditional mark yaml files. These changes made it complicated when we do need to skip something for test_pretest.py. This change fixed the problem by using a real dummy entry for defining the yaml anchors. The code of skipping test_pretest.py in sort checking in conditional mark yaml file is also removed. This change also improved a variable name in conditional mark and fixed a few typos. Signed-off-by: Xin Wang <xiwang5@microsoft.com> Signed-off-by: Andoni Sanguesa <andoniesanguesa@gmail.com>

PR sonic-net#20326 introduced anchors in the conditional mark yaml files. The anchors are defined in a dummy entry for test_pretest.py. PR sonic-net#20382 updated code to add exception for the sort checking of test_pretest.py in conditional mark yaml files. These changes made it complicated when we do need to skip something for test_pretest.py. This change fixed the problem by using a real dummy entry for defining the yaml anchors. The code of skipping test_pretest.py in sort checking in conditional mark yaml file is also removed. This change also improved a variable name in conditional mark and fixed a few typos. Signed-off-by: Xin Wang <xiwang5@microsoft.com> Signed-off-by: Saravanan Sellappa <saravanan@nexthop.ai>

PR sonic-net#20326 introduced anchors in the conditional mark yaml files. The anchors are defined in a dummy entry for test_pretest.py. PR sonic-net#20382 updated code to add exception for the sort checking of test_pretest.py in conditional mark yaml files. These changes made it complicated when we do need to skip something for test_pretest.py. This change fixed the problem by using a real dummy entry for defining the yaml anchors. The code of skipping test_pretest.py in sort checking in conditional mark yaml file is also removed. This change also improved a variable name in conditional mark and fixed a few typos. Signed-off-by: Xin Wang <xiwang5@microsoft.com> Signed-off-by: Yael Tzur <ytzur@nvidia.com>

PR sonic-net#20326 introduced anchors in the conditional mark yaml files. The anchors are defined in a dummy entry for test_pretest.py. PR sonic-net#20382 updated code to add exception for the sort checking of test_pretest.py in conditional mark yaml files. These changes made it complicated when we do need to skip something for test_pretest.py. This change fixed the problem by using a real dummy entry for defining the yaml anchors. The code of skipping test_pretest.py in sort checking in conditional mark yaml file is also removed. This change also improved a variable name in conditional mark and fixed a few typos. Signed-off-by: Xin Wang <xiwang5@microsoft.com>

PR sonic-net#20326 introduced anchors in the conditional mark yaml files. The anchors are defined in a dummy entry for test_pretest.py. PR sonic-net#20382 updated code to add exception for the sort checking of test_pretest.py in conditional mark yaml files. These changes made it complicated when we do need to skip something for test_pretest.py. This change fixed the problem by using a real dummy entry for defining the yaml anchors. The code of skipping test_pretest.py in sort checking in conditional mark yaml file is also removed. This change also improved a variable name in conditional mark and fixed a few typos. Signed-off-by: Xin Wang <xiwang5@microsoft.com> Signed-off-by: nnelluri-cisco <nnelluri@cisco.com>

PR sonic-net#20326 introduced anchors in the conditional mark yaml files. The anchors are defined in a dummy entry for test_pretest.py. PR sonic-net#20382 updated code to add exception for the sort checking of test_pretest.py in conditional mark yaml files. These changes made it complicated when we do need to skip something for test_pretest.py. This change fixed the problem by using a real dummy entry for defining the yaml anchors. The code of skipping test_pretest.py in sort checking in conditional mark yaml file is also removed. This change also improved a variable name in conditional mark and fixed a few typos. Signed-off-by: Xin Wang <xiwang5@microsoft.com> Signed-off-by: Raghavendran Ramanathan <rraghav@cisco.com>

PR sonic-net#20326 introduced anchors in the conditional mark yaml files. The anchors are defined in a dummy entry for test_pretest.py. PR sonic-net#20382 updated code to add exception for the sort checking of test_pretest.py in conditional mark yaml files. These changes made it complicated when we do need to skip something for test_pretest.py. This change fixed the problem by using a real dummy entry for defining the yaml anchors. The code of skipping test_pretest.py in sort checking in conditional mark yaml file is also removed. This change also improved a variable name in conditional mark and fixed a few typos. Signed-off-by: Xin Wang <xiwang5@microsoft.com> Signed-off-by: Zhuohui Tan <zhuohui.tan@amd.com>

PR sonic-net#20326 introduced anchors in the conditional mark yaml files. The anchors are defined in a dummy entry for test_pretest.py. PR sonic-net#20382 updated code to add exception for the sort checking of test_pretest.py in conditional mark yaml files. These changes made it complicated when we do need to skip something for test_pretest.py. This change fixed the problem by using a real dummy entry for defining the yaml anchors. The code of skipping test_pretest.py in sort checking in conditional mark yaml file is also removed. This change also improved a variable name in conditional mark and fixed a few typos. Signed-off-by: Xin Wang <xiwang5@microsoft.com> Signed-off-by: Abhishek <abhishek@nexthop.ai>

PR sonic-net#20326 introduced anchors in the conditional mark yaml files. The anchors are defined in a dummy entry for test_pretest.py. PR sonic-net#20382 updated code to add exception for the sort checking of test_pretest.py in conditional mark yaml files. These changes made it complicated when we do need to skip something for test_pretest.py. This change fixed the problem by using a real dummy entry for defining the yaml anchors. The code of skipping test_pretest.py in sort checking in conditional mark yaml file is also removed. This change also improved a variable name in conditional mark and fixed a few typos. Signed-off-by: Xin Wang <xiwang5@microsoft.com>

PR sonic-net#20326 introduced anchors in the conditional mark yaml files. The anchors are defined in a dummy entry for test_pretest.py. PR sonic-net#20382 updated code to add exception for the sort checking of test_pretest.py in conditional mark yaml files. These changes made it complicated when we do need to skip something for test_pretest.py. This change fixed the problem by using a real dummy entry for defining the yaml anchors. The code of skipping test_pretest.py in sort checking in conditional mark yaml file is also removed. This change also improved a variable name in conditional mark and fixed a few typos. Signed-off-by: Xin Wang <xiwang5@microsoft.com> Signed-off-by: selldinesh <dinesh.sellappan@keysight.com>

PR sonic-net#20326 introduced anchors in the conditional mark yaml files. The anchors are defined in a dummy entry for test_pretest.py. PR sonic-net#20382 updated code to add exception for the sort checking of test_pretest.py in conditional mark yaml files. These changes made it complicated when we do need to skip something for test_pretest.py. This change fixed the problem by using a real dummy entry for defining the yaml anchors. The code of skipping test_pretest.py in sort checking in conditional mark yaml file is also removed. This change also improved a variable name in conditional mark and fixed a few typos. Signed-off-by: Xin Wang <xiwang5@microsoft.com> Signed-off-by: opcoder0 <110003254+opcoder0@users.noreply.github.com>

PR sonic-net#20326 introduced anchors in the conditional mark yaml files. The anchors are defined in a dummy entry for test_pretest.py. PR sonic-net#20382 updated code to add exception for the sort checking of test_pretest.py in conditional mark yaml files. These changes made it complicated when we do need to skip something for test_pretest.py. This change fixed the problem by using a real dummy entry for defining the yaml anchors. The code of skipping test_pretest.py in sort checking in conditional mark yaml file is also removed. This change also improved a variable name in conditional mark and fixed a few typos. Signed-off-by: Xin Wang <xiwang5@microsoft.com> Signed-off-by: Raghavendran Ramanathan <rraghav@cisco.com>

PR sonic-net#20326 introduced anchors in the conditional mark yaml files. The anchors are defined in a dummy entry for test_pretest.py. PR sonic-net#20382 updated code to add exception for the sort checking of test_pretest.py in conditional mark yaml files. These changes made it complicated when we do need to skip something for test_pretest.py. This change fixed the problem by using a real dummy entry for defining the yaml anchors. The code of skipping test_pretest.py in sort checking in conditional mark yaml file is also removed. This change also improved a variable name in conditional mark and fixed a few typos. Signed-off-by: Xin Wang <xiwang5@microsoft.com> Signed-off-by: Sudarshan Kumar (from Dev Box) <sudakumar@microsoft.com>

wangxin requested review from davidm-arista and xwjiang-ms January 15, 2026 02:49

github-actions bot requested review from BYGX-wcr and yutongzhang-microsoft January 15, 2026 02:49

qiluo-msft approved these changes Jan 15, 2026

View reviewed changes

wangxin merged commit 5c22743 into sonic-net:master Jan 15, 2026
21 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve anchor definition in conditional mark#21943

Improve anchor definition in conditional mark#21943
wangxin merged 1 commit intosonic-net:masterfrom
wangxin:fix-conditional-mark-anchor

wangxin commented Jan 15, 2026

Uh oh!

mssonicbld commented Jan 15, 2026

Uh oh!

azure-pipelines bot commented Jan 15, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

wangxin commented Jan 15, 2026

Description of PR

Type of change

Back port request

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Uh oh!

mssonicbld commented Jan 15, 2026

Uh oh!

azure-pipelines bot commented Jan 15, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants