Skipping PFCWD tests for lossy topos & add anchor section by davidm-arista · Pull Request #20326 · sonic-net/sonic-mgmt

davidm-arista · 2025-08-19T19:16:02Z

Description of PR

Summary:
This is adding a new section to the tests_mark_conditions.yaml file so that common conditions can be defined once, and then re-used in the rest of this file.

This section currently only defines lossyTopos, and this change uses that throughout the tests_mark_conditions.yaml file.

Type of change

Back port request

mssonicbld · 2025-08-19T19:16:10Z

/azp run

azure-pipelines · 2025-08-19T19:16:24Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-08-19T20:42:01Z

/azp run

azure-pipelines · 2025-08-19T20:42:14Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-08-19T21:21:31Z

/azp run

azure-pipelines · 2025-08-19T21:21:44Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-08-22T16:23:53Z

/azp run

azure-pipelines · 2025-08-22T16:24:07Z

Azure Pipelines successfully started running 1 pipeline(s).

davidm-arista · 2025-08-22T22:53:35Z

I created #20382 to merge before this, to allow this PR to pass its checks

Ensure pre-test is first item in conditional mark check, because pre-test runs before everything else, and it makes the most sense at the top of the file. Also this change goes with #20326 This change will allow that PR to pass its PR checks.

This is adding a new section to the tests_mark_conditions.yaml file so that common conditions can be defined once, and then re-used in the rest of this file. This section currently only defines lossyTopos, and this change uses that throughout the tests_mark_conditions.yaml file.

mssonicbld · 2025-09-09T00:40:14Z

/azp run

azure-pipelines · 2025-09-09T00:40:27Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-09-09T06:07:26Z

/azp run

azure-pipelines · 2025-09-09T06:07:41Z

Azure Pipelines successfully started running 1 pipeline(s).

…t#20382) Ensure pre-test is first item in conditional mark check, because pre-test runs before everything else, and it makes the most sense at the top of the file. Also this change goes with sonic-net#20326 This change will allow that PR to pass its PR checks.

Summary: Ensure pre-test is first item in conditional mark check, because pre-test runs before everything else, and it makes the most sense at the top of the file. Also this change goes with sonic-net/sonic-mgmt#20326 This change will allow that PR to pass its PR checks. ### Type of change - [X] Testbed and Framework(new/improvement) ### Back port request - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [X] 202505 ### Approach #### What is the motivation for this PR? To allow sonic-net/sonic-mgmt#20326 to pass the PR checks #### How did you verify/test it? Running it manually on PR 20326 #### Any platform specific information? No #### Supported testbed topology if it's a new test case? N/A

…mark check (#689) Summary: Ensure pre-test is first item in conditional mark check, because pre-test runs before everything else, and it makes the most sense at the top of the file. Also this change goes with sonic-net/sonic-mgmt#20326 This change will allow that PR to pass its PR checks. ### Type of change - [X] Testbed and Framework(new/improvement) ### Back port request - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [X] 202505 ### Approach #### What is the motivation for this PR? To allow sonic-net/sonic-mgmt#20326 to pass the PR checks #### How did you verify/test it? Running it manually on PR 20326 #### Any platform specific information? No #### Supported testbed topology if it's a new test case? N/A

Ensure pre-test is first item in conditional mark check, because pre-test runs before everything else, and it makes the most sense at the top of the file. Also this change goes with #20326 This change will allow that PR to pass its PR checks.

…20326) This is adding a new section to the tests_mark_conditions.yaml file so that common conditions can be defined once, and then re-used in the rest of this file. This section currently only defines lossyTopos, and this change uses that throughout the tests_mark_conditions.yaml file. Signed-off-by: Aharon Malkin <[email protected]>

…net#20642) sonic-net#20326 was missing a "conditions_logical_operator: or", which this PR adds. Since that PR has not merged to any branches yet, this only needed for master Signed-off-by: Aharon Malkin <[email protected]>

…t#20382) Ensure pre-test is first item in conditional mark check, because pre-test runs before everything else, and it makes the most sense at the top of the file. Also this change goes with sonic-net#20326 This change will allow that PR to pass its PR checks. Signed-off-by: Guy Shemesh <[email protected]>

…20326) This is adding a new section to the tests_mark_conditions.yaml file so that common conditions can be defined once, and then re-used in the rest of this file. This section currently only defines lossyTopos, and this change uses that throughout the tests_mark_conditions.yaml file. Signed-off-by: Guy Shemesh <[email protected]>

…net#20642) sonic-net#20326 was missing a "conditions_logical_operator: or", which this PR adds. Since that PR has not merged to any branches yet, this only needed for master Signed-off-by: Guy Shemesh <[email protected]>

…t#20382) Ensure pre-test is first item in conditional mark check, because pre-test runs before everything else, and it makes the most sense at the top of the file. Also this change goes with sonic-net#20326 This change will allow that PR to pass its PR checks.

…20326) This is adding a new section to the tests_mark_conditions.yaml file so that common conditions can be defined once, and then re-used in the rest of this file. This section currently only defines lossyTopos, and this change uses that throughout the tests_mark_conditions.yaml file.

…net#20642) sonic-net#20326 was missing a "conditions_logical_operator: or", which this PR adds. Since that PR has not merged to any branches yet, this only needed for master

PR sonic-net#20326 introduced anchors in the conditional mark yaml files. The anchors are defined in a dummy entry for test_pretest.py. PR sonic-net#20382 updated code to add exception for the sort checking of test_pretest.py in conditional mark yaml files. These changes made it complicated when we do need to skip something for test_pretest.py. This change fixed the problem by using a real dummy entry for defining the yaml anchors. The code of skipping test_pretest.py in sort checking in conditional mark yaml file is also removed. This change also improved a variable name in conditional mark and fixed a few typos. Signed-off-by: Xin Wang <[email protected]>

PR #20326 introduced anchors in the conditional mark yaml files. The anchors are defined in a dummy entry for test_pretest.py. PR #20382 updated code to add exception for the sort checking of test_pretest.py in conditional mark yaml files. These changes made it complicated when we do need to skip something for test_pretest.py. This change fixed the problem by using a real dummy entry for defining the yaml anchors. The code of skipping test_pretest.py in sort checking in conditional mark yaml file is also removed. This change also improved a variable name in conditional mark and fixed a few typos. Signed-off-by: Xin Wang <[email protected]>

PR sonic-net#20326 introduced anchors in the conditional mark yaml files. The anchors are defined in a dummy entry for test_pretest.py. PR sonic-net#20382 updated code to add exception for the sort checking of test_pretest.py in conditional mark yaml files. These changes made it complicated when we do need to skip something for test_pretest.py. This change fixed the problem by using a real dummy entry for defining the yaml anchors. The code of skipping test_pretest.py in sort checking in conditional mark yaml file is also removed. This change also improved a variable name in conditional mark and fixed a few typos. Signed-off-by: Xin Wang <[email protected]> Signed-off-by: Priyansh Tratiya <[email protected]>

PR sonic-net#20326 introduced anchors in the conditional mark yaml files. The anchors are defined in a dummy entry for test_pretest.py. PR sonic-net#20382 updated code to add exception for the sort checking of test_pretest.py in conditional mark yaml files. These changes made it complicated when we do need to skip something for test_pretest.py. This change fixed the problem by using a real dummy entry for defining the yaml anchors. The code of skipping test_pretest.py in sort checking in conditional mark yaml file is also removed. This change also improved a variable name in conditional mark and fixed a few typos. Signed-off-by: Xin Wang <[email protected]> Signed-off-by: Andoni Sanguesa <[email protected]>

PR sonic-net#20326 introduced anchors in the conditional mark yaml files. The anchors are defined in a dummy entry for test_pretest.py. PR sonic-net#20382 updated code to add exception for the sort checking of test_pretest.py in conditional mark yaml files. These changes made it complicated when we do need to skip something for test_pretest.py. This change fixed the problem by using a real dummy entry for defining the yaml anchors. The code of skipping test_pretest.py in sort checking in conditional mark yaml file is also removed. This change also improved a variable name in conditional mark and fixed a few typos. Signed-off-by: Xin Wang <[email protected]> Signed-off-by: Saravanan Sellappa <[email protected]>

…t#20382) Ensure pre-test is first item in conditional mark check, because pre-test runs before everything else, and it makes the most sense at the top of the file. Also this change goes with sonic-net#20326 This change will allow that PR to pass its PR checks. Signed-off-by: Guy Shemesh <[email protected]>

…20326) This is adding a new section to the tests_mark_conditions.yaml file so that common conditions can be defined once, and then re-used in the rest of this file. This section currently only defines lossyTopos, and this change uses that throughout the tests_mark_conditions.yaml file. Signed-off-by: Guy Shemesh <[email protected]>

…net#20642) sonic-net#20326 was missing a "conditions_logical_operator: or", which this PR adds. Since that PR has not merged to any branches yet, this only needed for master Signed-off-by: Guy Shemesh <[email protected]>

…t#20382) Ensure pre-test is first item in conditional mark check, because pre-test runs before everything else, and it makes the most sense at the top of the file. Also this change goes with sonic-net#20326 This change will allow that PR to pass its PR checks. Signed-off-by: Lakshmi Yarramaneni <[email protected]>

…20326) This is adding a new section to the tests_mark_conditions.yaml file so that common conditions can be defined once, and then re-used in the rest of this file. This section currently only defines lossyTopos, and this change uses that throughout the tests_mark_conditions.yaml file. Signed-off-by: Lakshmi Yarramaneni <[email protected]>

…net#20642) sonic-net#20326 was missing a "conditions_logical_operator: or", which this PR adds. Since that PR has not merged to any branches yet, this only needed for master Signed-off-by: Lakshmi Yarramaneni <[email protected]>

…t#20382) Ensure pre-test is first item in conditional mark check, because pre-test runs before everything else, and it makes the most sense at the top of the file. Also this change goes with sonic-net#20326 This change will allow that PR to pass its PR checks. Signed-off-by: Yael Tzur <[email protected]>

…20326) This is adding a new section to the tests_mark_conditions.yaml file so that common conditions can be defined once, and then re-used in the rest of this file. This section currently only defines lossyTopos, and this change uses that throughout the tests_mark_conditions.yaml file. Signed-off-by: Yael Tzur <[email protected]>

…net#20642) sonic-net#20326 was missing a "conditions_logical_operator: or", which this PR adds. Since that PR has not merged to any branches yet, this only needed for master Signed-off-by: Yael Tzur <[email protected]>

PR sonic-net#20326 introduced anchors in the conditional mark yaml files. The anchors are defined in a dummy entry for test_pretest.py. PR sonic-net#20382 updated code to add exception for the sort checking of test_pretest.py in conditional mark yaml files. These changes made it complicated when we do need to skip something for test_pretest.py. This change fixed the problem by using a real dummy entry for defining the yaml anchors. The code of skipping test_pretest.py in sort checking in conditional mark yaml file is also removed. This change also improved a variable name in conditional mark and fixed a few typos. Signed-off-by: Xin Wang <[email protected]> Signed-off-by: Yael Tzur <[email protected]>

PR sonic-net#20326 introduced anchors in the conditional mark yaml files. The anchors are defined in a dummy entry for test_pretest.py. PR sonic-net#20382 updated code to add exception for the sort checking of test_pretest.py in conditional mark yaml files. These changes made it complicated when we do need to skip something for test_pretest.py. This change fixed the problem by using a real dummy entry for defining the yaml anchors. The code of skipping test_pretest.py in sort checking in conditional mark yaml file is also removed. This change also improved a variable name in conditional mark and fixed a few typos. Signed-off-by: Xin Wang <[email protected]>

PR sonic-net#20326 introduced anchors in the conditional mark yaml files. The anchors are defined in a dummy entry for test_pretest.py. PR sonic-net#20382 updated code to add exception for the sort checking of test_pretest.py in conditional mark yaml files. These changes made it complicated when we do need to skip something for test_pretest.py. This change fixed the problem by using a real dummy entry for defining the yaml anchors. The code of skipping test_pretest.py in sort checking in conditional mark yaml file is also removed. This change also improved a variable name in conditional mark and fixed a few typos. Signed-off-by: Xin Wang <[email protected]> Signed-off-by: nnelluri-cisco <[email protected]>

PR sonic-net#20326 introduced anchors in the conditional mark yaml files. The anchors are defined in a dummy entry for test_pretest.py. PR sonic-net#20382 updated code to add exception for the sort checking of test_pretest.py in conditional mark yaml files. These changes made it complicated when we do need to skip something for test_pretest.py. This change fixed the problem by using a real dummy entry for defining the yaml anchors. The code of skipping test_pretest.py in sort checking in conditional mark yaml file is also removed. This change also improved a variable name in conditional mark and fixed a few typos. Signed-off-by: Xin Wang <[email protected]> Signed-off-by: Raghavendran Ramanathan <[email protected]>

PR sonic-net#20326 introduced anchors in the conditional mark yaml files. The anchors are defined in a dummy entry for test_pretest.py. PR sonic-net#20382 updated code to add exception for the sort checking of test_pretest.py in conditional mark yaml files. These changes made it complicated when we do need to skip something for test_pretest.py. This change fixed the problem by using a real dummy entry for defining the yaml anchors. The code of skipping test_pretest.py in sort checking in conditional mark yaml file is also removed. This change also improved a variable name in conditional mark and fixed a few typos. Signed-off-by: Xin Wang <[email protected]> Signed-off-by: Zhuohui Tan <[email protected]>

PR sonic-net#20326 introduced anchors in the conditional mark yaml files. The anchors are defined in a dummy entry for test_pretest.py. PR sonic-net#20382 updated code to add exception for the sort checking of test_pretest.py in conditional mark yaml files. These changes made it complicated when we do need to skip something for test_pretest.py. This change fixed the problem by using a real dummy entry for defining the yaml anchors. The code of skipping test_pretest.py in sort checking in conditional mark yaml file is also removed. This change also improved a variable name in conditional mark and fixed a few typos. Signed-off-by: Xin Wang <[email protected]> Signed-off-by: Abhishek <[email protected]>

davidm-arista requested a review from wangxin as a code owner August 19, 2025 20:41

davidm-arista force-pushed the master-lossyToposPfcwdSkipping branch from 9ef9278 to 1ee66cc Compare August 19, 2025 21:21

davidm-arista force-pushed the master-lossyToposPfcwdSkipping branch from 1ee66cc to 903f443 Compare August 22, 2025 16:23

davidm-arista mentioned this pull request Aug 22, 2025

Ensure pre-test is the first item in conditional mark check #20382

Merged

7 tasks

davidm-arista force-pushed the master-lossyToposPfcwdSkipping branch from 903f443 to 817ecf1 Compare September 9, 2025 00:40

sdszhang closed this Sep 9, 2025

sdszhang reopened this Sep 9, 2025

mssonicbld mentioned this pull request Sep 9, 2025

[action] [PR:20382] Ensure pre-test is the first item in conditional mark check #20581

Merged

7 tasks

mssonicbld mentioned this pull request Sep 9, 2025

[action] [PR:20382] Ensure pre-test is the first item in conditional mark check Azure/sonic-mgmt.msft#689

Merged

7 tasks

sdszhang closed this Sep 11, 2025

sdszhang reopened this Sep 11, 2025

wangxin mentioned this pull request Jan 15, 2026

Improve anchor definition in conditional mark #21943

Merged

12 tasks

Conversation

davidm-arista commented Aug 19, 2025

Description of PR

Type of change

Back port request

Uh oh!

mssonicbld commented Aug 19, 2025

Uh oh!

azure-pipelines bot commented Aug 19, 2025

Uh oh!

mssonicbld commented Aug 19, 2025

Uh oh!

azure-pipelines bot commented Aug 19, 2025

Uh oh!

mssonicbld commented Aug 19, 2025

Uh oh!

azure-pipelines bot commented Aug 19, 2025

Uh oh!

mssonicbld commented Aug 22, 2025

Uh oh!

azure-pipelines bot commented Aug 22, 2025

Uh oh!

davidm-arista commented Aug 22, 2025

Uh oh!

mssonicbld commented Sep 9, 2025

Uh oh!

azure-pipelines bot commented Sep 9, 2025

Uh oh!

mssonicbld commented Sep 9, 2025

Uh oh!

azure-pipelines bot commented Sep 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants